Skip to content

armgit / mocha

Public Imported from GitHub
0

☕️ Classic, reliable, trusted test framework for Node.js and the browser

remove fn.call() from filter util

TJ Holowaychukb84907d50cff
diff --git a/lib/utils.js b/lib/utils.js
index 0df5b272..308519d0 100644
--- a/lib/utils.js
+++ b/lib/utils.js
@@ -95,8 +95,7 @@ exports.filter = function(arr, fn){
for (var i = 0, l = arr.length; i < l; i++) {
var val = arr[i];
- if (fn.call(scope, val, i, arr))
- ret.push(val);
+ if (fn(val, i, arr)) ret.push(val);
}
return ret;
diff --git a/mocha.js b/mocha.js
index 3e7bf1c4..268f63b1 100644
--- a/mocha.js
+++ b/mocha.js
@@ -4474,7 +4474,7 @@ var ignore = ['node_modules', '.git'];
* @api private
*/
-exports.escape = function(html) {
+exports.escape = function(html){
return String(html)
.replace(/&/g, '&amp;')
.replace(/"/g, '&quot;')
@@ -4491,7 +4491,7 @@ exports.escape = function(html) {
* @api private
*/
-exports.forEach = function(arr, fn, scope) {
+exports.forEach = function(arr, fn, scope){
for (var i = 0, l = arr.length; i < l; i++)
fn.call(scope, arr[i], i);
};
@@ -4505,7 +4505,7 @@ exports.forEach = function(arr, fn, scope) {
* @api private
*/
-exports.indexOf = function (arr, obj, start) {
+exports.indexOf = function(arr, obj, start){
for (var i = start || 0, l = arr.length; i < l; i++) {
if (arr[i] === obj)
return i;
@@ -4523,7 +4523,7 @@ exports.indexOf = function (arr, obj, start) {
* @api private
*/
-exports.reduce = function(arr, fn, val, scope) {
+exports.reduce = function(arr, fn, val, scope){
var rval = val;
for (var i = 0, l = arr.length; i < l; i++) {
@@ -4542,13 +4542,12 @@ exports.reduce = function(arr, fn, val, scope) {
* @api private
*/
-exports.filter = function(arr, fn, scope) {
+exports.filter = function(arr, fn){
var ret = [];
for (var i = 0, l = arr.length; i < l; i++) {
var val = arr[i];
- if (fn.call(scope, val, i, arr))
- ret.push(val);
+ if (fn(val, i, arr)) ret.push(val);
}
return ret;