☕️ Classic, reliable, trusted test framework for Node.js and the browser
fix: use main instead of exports for the package entry point (#6193)
Mostafa Nazaric32a696f0963
diff --git a/package.json b/package.jsonindex 0b0d481c..1108287d 100644--- a/package.json+++ b/package.json@@ -31,10 +31,7 @@"homepage": "https://mochajs.org/","logo": "https://cldup.com/S9uQ-cOLYz.svg","notifyLogo": "https://ibin.co/4QuRuGjXvl36.png",- "exports": {- ".": "./index.js",- "./*": "./*"- },+ "main": "./index.js","bin": {"mocha": "./bin/mocha.js"},diff --git a/test/integration/package-entrypoint.spec.cjs b/test/integration/package-entrypoint.spec.cjsindex fd9aa23a..f438d2fe 100644--- a/test/integration/package-entrypoint.spec.cjs+++ b/test/integration/package-entrypoint.spec.cjs@@ -5,46 +5,72 @@ const os = require("node:os");const path = require("node:path");const { invokeNode } = require("./helpers.cjs");+async function invokeNodeWithLinkedMocha(args) {+ const repoRoot = path.resolve(__dirname, "..", "..");+ const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "mocha-package-root-"));+ const packageDir = path.join(tempDir, "node_modules", "mocha");++ fs.mkdirSync(path.dirname(packageDir), { recursive: true });++ try {+ if (process.platform === "win32") {+ fs.symlinkSync(repoRoot, packageDir, "junction");+ } else {+ fs.symlinkSync(repoRoot, packageDir);+ }++ return await new Promise((resolve, reject) => {+ invokeNode(+ args,+ (err, res) => {+ if (err) {+ reject(err);+ return;+ }+ resolve(res);+ },+ { cwd: tempDir, stdio: ["ignore", "pipe", "pipe"] },+ );+ });+ } finally {+ fs.rmSync(tempDir, { recursive: true, force: true });+ }+}+describe("package entrypoint", function () {it("should resolve the package root without DEP0151 warnings", async function () {- const repoRoot = path.resolve(__dirname, "..", "..");- const tempDir = fs.mkdtempSync(- path.join(os.tmpdir(), "mocha-package-root-"),- );- const packageDir = path.join(tempDir, "node_modules", "mocha");-- fs.mkdirSync(path.dirname(packageDir), { recursive: true });-- try {- if (process.platform === "win32") {- fs.symlinkSync(repoRoot, packageDir, "junction");- } else {- fs.symlinkSync(repoRoot, packageDir);- }-- const result = await new Promise((resolve, reject) => {- invokeNode(- [- "--input-type=module",- "-e",- "import {describe, it} from 'mocha'; console.log(typeof describe, typeof it);",- ],- (err, res) => {- if (err) {- reject(err);- return;- }- resolve(res);- },- { cwd: tempDir, stdio: ["ignore", "pipe", "pipe"] },- );- });-- expect(result.code, "to be", 0);- expect(result.output, "to contain", "function function");- expect(result.output, "not to contain", "DEP0151");- } finally {- fs.rmSync(tempDir, { recursive: true, force: true });- }+ const result = await invokeNodeWithLinkedMocha([+ "--input-type=module",+ "-e",+ "import {describe, it} from 'mocha'; console.log(typeof describe, typeof it);",+ ]);++ expect(result.code, "to be", 0);+ expect(result.output, "to contain", "function function");+ expect(result.output, "not to contain", "DEP0151");+ });++ it("should resolve deep subpaths without a file extension", async function () {+ const result = await invokeNodeWithLinkedMocha([+ "-e",+ "require.resolve('mocha/lib/reporters/base');" ++ "require.resolve('mocha/lib/stats-collector');" ++ "console.log('resolved deep subpaths');",+ ]);++ expect(result.code, "to be", 0);+ expect(result.output, "to contain", "resolved deep subpaths");+ });++ it("should resolve deep subpaths with a file extension", async function () {+ const result = await invokeNodeWithLinkedMocha([+ "-e",+ "require.resolve('mocha/lib/reporters/base.js');" ++ "require.resolve('mocha/lib/stats-collector.js');" ++ "console.log('resolved deep subpaths');",+ ]);++ expect(result.code, "to be", 0);+ expect(result.output, "to contain", "resolved deep subpaths");});});