Skip to content

armgit / mocha

Public Imported from GitHub
0

☕️ Classic, reliable, trusted test framework for Node.js and the browser

build(docs/dev-deps): use JS-native `fetch` to get supporters data instead of external `needle` (#5643)

Đỗ Trọng Hảie37e56fbe6a1
diff --git a/docs-next/package-lock.json b/docs-next/package-lock.json
index 2bbf77ae..ee018254 100644
--- a/docs-next/package-lock.json
+++ b/docs-next/package-lock.json
@@ -13,7 +13,6 @@
"astro": "^5.16.6",
"astro-og-canvas": "^0.7.2",
"debug": "^4.4.3",
- "needle": "^3.3.1",
"sharp": "^0.34.5",
"starlight-package-managers": "^0.11.1",
"typescript": "^5.9.3",
@@ -3954,18 +3953,6 @@
"@babel/runtime": "^7.23.2"
}
},
- "node_modules/iconv-lite": {
- "version": "0.6.3",
- "resolved": "https://registry.npmjs.org/iconv-lite/-/iconv-lite-0.6.3.tgz",
- "integrity": "sha512-4fCk79wshMdzMp2rH06qWrJE4iolqLhCUH+OiuIgU++RB0+94NlDL81atO7GX55uUKueo0txHNtvEyI6D7WdMw==",
- "license": "MIT",
- "dependencies": {
- "safer-buffer": ">= 2.1.2 < 3.0.0"
- },
- "engines": {
- "node": ">=0.10.0"
- }
- },
"node_modules/import-meta-resolve": {
"version": "4.2.0",
"resolved": "https://registry.npmjs.org/import-meta-resolve/-/import-meta-resolve-4.2.0.tgz",
@@ -5378,22 +5365,6 @@
"node": "^10 || ^12 || ^13.7 || ^14 || >=15.0.1"
}
},
- "node_modules/needle": {
- "version": "3.3.1",
- "resolved": "https://registry.npmjs.org/needle/-/needle-3.3.1.tgz",
- "integrity": "sha512-6k0YULvhpw+RoLNiQCRKOl09Rv1dPLr8hHnVjHqdolKwDrdNyk+Hmrthi4lIGPPz3r39dLx0hsF5s40sZ3Us4Q==",
- "license": "MIT",
- "dependencies": {
- "iconv-lite": "^0.6.3",
- "sax": "^1.2.4"
- },
- "bin": {
- "needle": "bin/needle"
- },
- "engines": {
- "node": ">= 4.4.x"
- }
- },
"node_modules/neotraverse": {
"version": "0.6.18",
"resolved": "https://registry.npmjs.org/neotraverse/-/neotraverse-0.6.18.tgz",
@@ -6279,12 +6250,6 @@
"queue-microtask": "^1.2.2"
}
},
- "node_modules/safer-buffer": {
- "version": "2.1.2",
- "resolved": "https://registry.npmjs.org/safer-buffer/-/safer-buffer-2.1.2.tgz",
- "integrity": "sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==",
- "license": "MIT"
- },
"node_modules/sax": {
"version": "1.4.3",
"resolved": "https://registry.npmjs.org/sax/-/sax-1.4.3.tgz",
diff --git a/docs-next/package.json b/docs-next/package.json
index 54450dd8..6fa982a3 100644
--- a/docs-next/package.json
+++ b/docs-next/package.json
@@ -17,7 +17,6 @@
"astro": "^5.16.6",
"astro-og-canvas": "^0.7.2",
"debug": "^4.4.3",
- "needle": "^3.3.1",
"sharp": "^0.34.5",
"starlight-package-managers": "^0.11.1",
"typescript": "^5.9.3",
diff --git a/docs/_data/supporters.js b/docs/_data/supporters.js
index 238b64cf..6962889e 100755
--- a/docs/_data/supporters.js
+++ b/docs/_data/supporters.js
@@ -18,7 +18,6 @@
const { writeFile, mkdir, rm } = require("node:fs").promises;
const { resolve } = require("node:path");
const debug = require("debug")("mocha:docs:data:supporters");
-const needle = require("needle");
const blocklist = new Set(require("./blocklist.json"));
/**
@@ -105,14 +104,15 @@ const fetchImage = process.env.MOCHA_DOCS_SKIP_IMAGE_DOWNLOAD
: async (supporter) => {
try {
const { avatar: url } = supporter;
- const { body: imageBuf, headers } = await needle("get", url, {
- open_timeout: 30000,
+ const response = await fetch(url, {
+ signal: AbortSignal.timeout(30000),
});
- if (headers["content-type"].startsWith("text/html")) {
+ if (response.headers.get("content-type")?.startsWith("text/html")) {
throw new TypeError(
"received html and expected a png; outage likely",
);
}
+ const imageBuf = Buffer.from(await response.arrayBuffer());
debug("fetched %s", url);
const filePath = resolve(SUPPORTER_IMAGE_PATH, supporter.id + ".png");
await writeFile(filePath, imageBuf);
@@ -139,13 +139,16 @@ const getAllOrders = async (slug = "mochajs") => {
// Handling pagination if necessary (2 pages for ~1400 results in May 2019)
while (true) {
- const result = await needle(
- "post",
- API_ENDPOINT,
- { query: SUPPORTER_QUERY, variables },
- { json: true },
- );
- const orders = result.body.data.account.orders.nodes;
+ const response = await fetch(API_ENDPOINT, {
+ method: "POST",
+ headers: { "Content-Type": "application/json" },
+ body: JSON.stringify({
+ query: SUPPORTER_QUERY,
+ variables: variables,
+ }),
+ });
+ const result = await response.json();
+ const orders = result.data.account.orders.nodes;
allOrders = [...allOrders, ...orders];
variables.offset += GRAPHQL_PAGE_SIZE;
if (orders.length < GRAPHQL_PAGE_SIZE) {
diff --git a/package-lock.json b/package-lock.json
index 83bc1723..862f8382 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -60,7 +60,6 @@
"karma-mocha-reporter": "^2.2.5",
"karma-sauce-launcher": "^4.3.6",
"knip": "^5.61.3",
- "needle": "^2.5.0",
"npm-run-all2": "^6.2.0",
"nyc": "^17.1.0",
"prettier": "3.6.2",
@@ -14844,34 +14843,6 @@
"integrity": "sha512-OWND8ei3VtNC9h7V60qff3SVobHr996CTwgxubgyQYEpg290h9J0buyECNNJexkFm5sOajh5G116RYA1c8ZMSw==",
"dev": true
},
- "node_modules/needle": {
- "version": "2.9.1",
- "resolved": "https://registry.npmjs.org/needle/-/needle-2.9.1.tgz",
- "integrity": "sha512-6R9fqJ5Zcmf+uYaFgdIHmLwNldn5HbK8L5ybn7Uz+ylX/rnOsSp1AHcvQSrCaFN+qNM1wpymHqD7mVasEOlHGQ==",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "debug": "^3.2.6",
- "iconv-lite": "^0.4.4",
- "sax": "^1.2.4"
- },
- "bin": {
- "needle": "bin/needle"
- },
- "engines": {
- "node": ">= 4.4.x"
- }
- },
- "node_modules/needle/node_modules/debug": {
- "version": "3.2.7",
- "resolved": "https://registry.npmjs.org/debug/-/debug-3.2.7.tgz",
- "integrity": "sha512-CFjzYYAi4ThfiQvizrFQevTTXHtnCqWfe7x1AhgEscTz6ZbLbfoLRLPugTQyBth6f8ZERVUSyWHFD/7Wu4t1XQ==",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "ms": "^2.1.1"
- }
- },
"node_modules/negotiator": {
"version": "0.6.3",
"resolved": "https://registry.npmjs.org/negotiator/-/negotiator-0.6.3.tgz",
@@ -16986,13 +16957,6 @@
"node": ">=10"
}
},
- "node_modules/sax": {
- "version": "1.4.3",
- "resolved": "https://registry.npmjs.org/sax/-/sax-1.4.3.tgz",
- "integrity": "sha512-yqYn1JhPczigF94DMS+shiDMjDowYO6y9+wB/4WgO0Y19jWYk0lQ4tuG5KI7kj4FTp1wxPj5IFfcrz/s1c3jjQ==",
- "dev": true,
- "license": "BlueOak-1.0.0"
- },
"node_modules/schema-utils": {
"version": "3.1.1",
"resolved": "https://registry.npmjs.org/schema-utils/-/schema-utils-3.1.1.tgz",
diff --git a/package.json b/package.json
index 2275a783..bcb30cdf 100644
--- a/package.json
+++ b/package.json
@@ -146,7 +146,6 @@
"karma-mocha-reporter": "^2.2.5",
"karma-sauce-launcher": "^4.3.6",
"knip": "^5.61.3",
- "needle": "^2.5.0",
"npm-run-all2": "^6.2.0",
"nyc": "^17.1.0",
"prettier": "3.6.2",