☕️ Classic, reliable, trusted test framework for Node.js and the browser
replace phantomjs with puppeteer for browser tests; closes #3128
Andrew Krawchyke54370eaa4b1
diff --git a/.travis.yml b/.travis.ymlindex abd5efa8..8c51ccf2 100644--- a/.travis.yml+++ b/.travis.yml@@ -52,6 +52,7 @@ addons:- .karma/- ./mocha.jssauce_connect: true+ chrome: stablecache:directories:- ~/.npmdiff --git a/README.md b/README.mdindex 52e03aaa..a118407c 100644--- a/README.md+++ b/README.md@@ -11,7 +11,7 @@1. Increase test coverage on Node.js and browser- Increase integration coverage for all reporters- `html` reporter must be tested in browser- - ~~Basic console reporters (*not* `nyan`, `landing`, etc.) must be tested in **both** browser and Node.js contexts; PhantomJS can consume all console reporters~~+ - ~~Basic console reporters (*not* `nyan`, `landing`, etc.) must be tested in **both** browser and Node.js contexts~~- ~~Filesystem-based reporters must be tested in Node.js context~~- **UPDATE - May 24 2017**: Thanks to [community contributions](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#mag-coverage), the coverage on most reporters has increased dramatically! The `html` reporter is still in [dire need of coverage](https://coveralls.io/builds/11674428/source?filename=lib%2Freporters%2Fhtml.js).- Increase coverage against all interfaces (`exports` in particular). Ideally this becomes a "matrix" where we repeat sets of integration tests across all interfaces.diff --git a/appveyor.yml b/appveyor.ymlindex 6fbb0cd8..1583df4d 100644--- a/appveyor.yml+++ b/appveyor.yml@@ -10,7 +10,6 @@ install:- ps: Install-Product node $env:nodejs_version x64- set CI=true- set PATH=%APPDATA%\npm;c:\MinGW\bin;%PATH%- - set PHANTOMJS_CDNURL=https://cnpmjs.org/downloads- npm install -g npm- npm install- copy c:\MinGW\bin\mingw32-make.exe c:\MinGW\bin\make.exediff --git a/karma.conf.js b/karma.conf.jsindex 836e83bb..1880b1e2 100644--- a/karma.conf.js+++ b/karma.conf.js@@ -51,7 +51,7 @@ module.exports = config => {},reporters: ['mocha'],colors: true,- browsers: ['PhantomJS'],+ browsers: ['ChromeHeadless'],logLevel: config.LOG_INFO,client: {mocha: {diff --git a/package-lock.json b/package-lock.jsonindex e08d1de7..3d48edf3 100644--- a/package-lock.json+++ b/package-lock.json@@ -2840,12 +2840,6 @@"is-arrayish": "0.2.1"}},- "es6-promise": {- "version": "4.0.5",- "resolved": "https://registry.npmjs.org/es6-promise/-/es6-promise-4.0.5.tgz",- "integrity": "sha1-eILzCt3lskDM+n99eMVIMwlRrkI=",- "dev": true- },"esanimate": {"version": "1.1.0","resolved": "https://registry.npmjs.org/esanimate/-/esanimate-1.1.0.tgz",@@ -3440,55 +3434,6 @@"is-extglob": "1.0.0"}},- "extract-zip": {- "version": "1.6.5",- "resolved": "https://registry.npmjs.org/extract-zip/-/extract-zip-1.6.5.tgz",- "integrity": "sha1-maBnNbbqIOqbcF13ms/8yHz/BEA=",- "dev": true,- "requires": {- "concat-stream": "1.6.0",- "debug": "2.2.0",- "mkdirp": "0.5.0",- "yauzl": "2.4.1"- },- "dependencies": {- "concat-stream": {- "version": "1.6.0",- "resolved": "https://registry.npmjs.org/concat-stream/-/concat-stream-1.6.0.tgz",- "integrity": "sha1-CqxmL9Ur54lk1VMvaUeE5wEQrPc=",- "dev": true,- "requires": {- "inherits": "2.0.3",- "readable-stream": "2.3.3",- "typedarray": "0.0.6"- }- },- "debug": {- "version": "2.2.0",- "resolved": "https://registry.npmjs.org/debug/-/debug-2.2.0.tgz",- "integrity": "sha1-+HBX6ZWxofauaklgZkE3vFbwOdo=",- "dev": true,- "requires": {- "ms": "0.7.1"- }- },- "mkdirp": {- "version": "0.5.0",- "resolved": "https://registry.npmjs.org/mkdirp/-/mkdirp-0.5.0.tgz",- "integrity": "sha1-HXMHam35hs2TROFecfzAWkyavxI=",- "dev": true,- "requires": {- "minimist": "0.0.8"- }- },- "ms": {- "version": "0.7.1",- "resolved": "https://registry.npmjs.org/ms/-/ms-0.7.1.tgz",- "integrity": "sha1-nNE8A62/8ltl7/3nzoZO6VIBcJg=",- "dev": true- }- }- },"extsprintf": {"version": "1.3.0","resolved": "https://registry.npmjs.org/extsprintf/-/extsprintf-1.3.0.tgz",@@ -3701,17 +3646,6 @@"null-check": "1.0.0"}},- "fs-extra": {- "version": "1.0.0",- "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-1.0.0.tgz",- "integrity": "sha1-zTzl9+fLYUWIP8rjGR6Yd/hYeVA=",- "dev": true,- "requires": {- "graceful-fs": "4.1.11",- "jsonfile": "2.4.0",- "klaw": "1.3.1"- }- },"fs.realpath": {"version": "1.0.0","resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz",@@ -5357,16 +5291,6 @@"minimalistic-assert": "1.0.0"}},- "hasha": {- "version": "2.2.0",- "resolved": "https://registry.npmjs.org/hasha/-/hasha-2.2.0.tgz",- "integrity": "sha1-eNfL/B5tZjA/55g3NlmEUXsvbuE=",- "dev": true,- "requires": {- "is-stream": "1.1.0",- "pinkie-promise": "2.0.1"- }- },"hashish": {"version": "0.0.4","resolved": "https://registry.npmjs.org/hashish/-/hashish-0.0.4.tgz",@@ -6202,15 +6126,6 @@"integrity": "sha1-PAQ0dD35Pi9cQq7nsZvLSDV19OE=","dev": true},- "jsonfile": {- "version": "2.4.0",- "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-2.4.0.tgz",- "integrity": "sha1-NzaitCi4e72gzIO1P6PWM6NcKug=",- "dev": true,- "requires": {- "graceful-fs": "4.1.11"- }- },"jsonify": {"version": "0.0.0","resolved": "https://registry.npmjs.org/jsonify/-/jsonify-0.0.0.tgz",@@ -6362,16 +6277,6 @@"strip-ansi": "4.0.0"}},- "karma-phantomjs-launcher": {- "version": "1.0.4",- "resolved": "https://registry.npmjs.org/karma-phantomjs-launcher/-/karma-phantomjs-launcher-1.0.4.tgz",- "integrity": "sha1-0jyjSAG9qYY60xjju0vUBisTrNI=",- "dev": true,- "requires": {- "lodash": "4.17.4",- "phantomjs-prebuilt": "2.1.15"- }- },"karma-sauce-launcher": {"version": "1.2.0","resolved": "https://registry.npmjs.org/karma-sauce-launcher/-/karma-sauce-launcher-1.2.0.tgz",@@ -6384,12 +6289,6 @@"wd": "1.4.1"}},- "kew": {- "version": "0.7.0",- "resolved": "https://registry.npmjs.org/kew/-/kew-0.7.0.tgz",- "integrity": "sha1-edk9LTM2PW/dKXCzNdkUGtWR15s=",- "dev": true- },"kind-of": {"version": "3.2.2","resolved": "https://registry.npmjs.org/kind-of/-/kind-of-3.2.2.tgz",@@ -6399,15 +6298,6 @@"is-buffer": "1.1.5"}},- "klaw": {- "version": "1.3.1",- "resolved": "https://registry.npmjs.org/klaw/-/klaw-1.3.1.tgz",- "integrity": "sha1-QIhDO0azsbolnXh4XY6W9zugJDk=",- "dev": true,- "requires": {- "graceful-fs": "4.1.11"- }- },"labeled-stream-splicer": {"version": "2.0.0","resolved": "https://registry.npmjs.org/labeled-stream-splicer/-/labeled-stream-splicer-2.0.0.tgz",@@ -10065,196 +9955,6 @@"integrity": "sha1-Ywn04OX6kT7BxpMHrjZLSzd8nns=","dev": true},- "phantomjs-prebuilt": {- "version": "2.1.15",- "resolved": "https://registry.npmjs.org/phantomjs-prebuilt/-/phantomjs-prebuilt-2.1.15.tgz",- "integrity": "sha1-IPhugtM0nFBZF1J3RbekEeCLOQM=",- "dev": true,- "requires": {- "es6-promise": "4.0.5",- "extract-zip": "1.6.5",- "fs-extra": "1.0.0",- "hasha": "2.2.0",- "kew": "0.7.0",- "progress": "1.1.8",- "request": "2.81.0",- "request-progress": "2.0.1",- "which": "1.2.14"- },- "dependencies": {- "ajv": {- "version": "4.11.8",- "resolved": "https://registry.npmjs.org/ajv/-/ajv-4.11.8.tgz",- "integrity": "sha1-gv+wKynmYq5TvcIK8VlHcGc5xTY=",- "dev": true,- "requires": {- "co": "4.6.0",- "json-stable-stringify": "1.0.1"- }- },- "assert-plus": {- "version": "0.2.0",- "resolved": "https://registry.npmjs.org/assert-plus/-/assert-plus-0.2.0.tgz",- "integrity": "sha1-104bh+ev/A24qttwIfP+SBAasjQ=",- "dev": true- },- "aws-sign2": {- "version": "0.6.0",- "resolved": "https://registry.npmjs.org/aws-sign2/-/aws-sign2-0.6.0.tgz",- "integrity": "sha1-FDQt0428yU0OW4fXY81jYSwOeU8=",- "dev": true- },- "boom": {- "version": "2.10.1",- "resolved": "https://registry.npmjs.org/boom/-/boom-2.10.1.tgz",- "integrity": "sha1-OciRjO/1eZ+D+UkqhI9iWt0Mdm8=",- "dev": true,- "requires": {- "hoek": "2.16.3"- }- },- "cryptiles": {- "version": "2.0.5",- "resolved": "https://registry.npmjs.org/cryptiles/-/cryptiles-2.0.5.tgz",- "integrity": "sha1-O9/s3GCBR8HGcgL6KR59ylnqo7g=",- "dev": true,- "requires": {- "boom": "2.10.1"- }- },- "form-data": {- "version": "2.1.4",- "resolved": "https://registry.npmjs.org/form-data/-/form-data-2.1.4.tgz",- "integrity": "sha1-M8GDrPGTJ27KqYFDpp6Uv+4XUNE=",- "dev": true,- "requires": {- "asynckit": "0.4.0",- "combined-stream": "1.0.5",- "mime-types": "2.1.17"- }- },- "har-schema": {- "version": "1.0.5",- "resolved": "https://registry.npmjs.org/har-schema/-/har-schema-1.0.5.tgz",- "integrity": "sha1-0mMTX0MwfALGAq/I/pWXDAFRNp4=",- "dev": true- },- "har-validator": {- "version": "4.2.1",- "resolved": "https://registry.npmjs.org/har-validator/-/har-validator-4.2.1.tgz",- "integrity": "sha1-M0gdDxu/9gDdID11gSpqX7oALio=",- "dev": true,- "requires": {- "ajv": "4.11.8",- "har-schema": "1.0.5"- }- },- "hawk": {- "version": "3.1.3",- "resolved": "https://registry.npmjs.org/hawk/-/hawk-3.1.3.tgz",- "integrity": "sha1-B4REvXwWQLD+VA0sm3PVlnjo4cQ=",- "dev": true,- "requires": {- "boom": "2.10.1",- "cryptiles": "2.0.5",- "hoek": "2.16.3",- "sntp": "1.0.9"- }- },- "hoek": {- "version": "2.16.3",- "resolved": "https://registry.npmjs.org/hoek/-/hoek-2.16.3.tgz",- "integrity": "sha1-ILt0A9POo5jpHcRxCo/xuCdKJe0=",- "dev": true- },- "http-signature": {- "version": "1.1.1",- "resolved": "https://registry.npmjs.org/http-signature/-/http-signature-1.1.1.tgz",- "integrity": "sha1-33LiZwZs0Kxn+3at+OE0qPvPkb8=",- "dev": true,- "requires": {- "assert-plus": "0.2.0",- "jsprim": "1.4.1",- "sshpk": "1.13.1"- }- },- "json-stable-stringify": {- "version": "1.0.1",- "resolved": "https://registry.npmjs.org/json-stable-stringify/-/json-stable-stringify-1.0.1.tgz",- "integrity": "sha1-mnWdOcXy/1A/1TAGRu1EX4jE+a8=",- "dev": true,- "requires": {- "jsonify": "0.0.0"- }- },- "performance-now": {- "version": "0.2.0",- "resolved": "https://registry.npmjs.org/performance-now/-/performance-now-0.2.0.tgz",- "integrity": "sha1-M+8wxcd9TqIcWlOGnZG1bY8lVeU=",- "dev": true- },- "progress": {- "version": "1.1.8",- "resolved": "https://registry.npmjs.org/progress/-/progress-1.1.8.tgz",- "integrity": "sha1-4mDHj2Fhzdmw5WzD4Khd4Xx6V74=",- "dev": true- },- "qs": {- "version": "6.4.0",- "resolved": "https://registry.npmjs.org/qs/-/qs-6.4.0.tgz",- "integrity": "sha1-E+JtKK1rD/qpExLNO/cI7TUecjM=",- "dev": true- },- "request": {- "version": "2.81.0",- "resolved": "https://registry.npmjs.org/request/-/request-2.81.0.tgz",- "integrity": "sha1-xpKJRqDgbF+Nb4qTM0af/aRimKA=",- "dev": true,- "requires": {- "aws-sign2": "0.6.0",- "aws4": "1.6.0",- "caseless": "0.12.0",- "combined-stream": "1.0.5",- "extend": "3.0.1",- "forever-agent": "0.6.1",- "form-data": "2.1.4",- "har-validator": "4.2.1",- "hawk": "3.1.3",- "http-signature": "1.1.1",- "is-typedarray": "1.0.0",- "isstream": "0.1.2",- "json-stringify-safe": "5.0.1",- "mime-types": "2.1.17",- "oauth-sign": "0.8.2",- "performance-now": "0.2.0",- "qs": "6.4.0",- "safe-buffer": "5.1.1",- "stringstream": "0.0.5",- "tough-cookie": "2.3.3",- "tunnel-agent": "0.6.0",- "uuid": "3.1.0"- }- },- "sntp": {- "version": "1.0.9",- "resolved": "https://registry.npmjs.org/sntp/-/sntp-1.0.9.tgz",- "integrity": "sha1-ZUEYTMkK7qbG57NeJlkIJEPGYZg=",- "dev": true,- "requires": {- "hoek": "2.16.3"- }- },- "which": {- "version": "1.2.14",- "resolved": "https://registry.npmjs.org/which/-/which-1.2.14.tgz",- "integrity": "sha1-mofEN48D6CfOyvGs31bHNsAcFOU=",- "dev": true,- "requires": {- "isexe": "2.0.0"- }- }- }- },"pify": {"version": "2.3.0","resolved": "https://registry.npmjs.org/pify/-/pify-2.3.0.tgz",@@ -12702,15 +12402,6 @@"uuid": "3.1.0"}},- "request-progress": {- "version": "2.0.1",- "resolved": "https://registry.npmjs.org/request-progress/-/request-progress-2.0.1.tgz",- "integrity": "sha1-XTa7V5YcZzqlt4jbyBQf3yO0Tgg=",- "dev": true,- "requires": {- "throttleit": "1.0.0"- }- },"require-uncached": {"version": "1.0.3","resolved": "https://registry.npmjs.org/require-uncached/-/require-uncached-1.0.3.tgz",@@ -13874,12 +13565,6 @@"integrity": "sha1-f17oI66AUgfACvLfSoTsP8+lcLQ=","dev": true},- "throttleit": {- "version": "1.0.0",- "resolved": "https://registry.npmjs.org/throttleit/-/throttleit-1.0.0.tgz",- "integrity": "sha1-nnhYNtr0Z0MUWlmEtiaNgoUorGw=",- "dev": true- },"through": {"version": "2.3.8","resolved": "https://registry.npmjs.org/through/-/through-2.3.8.tgz",diff --git a/package.json b/package.jsonindex 3635bba8..7a9ec8d5 100644--- a/package.json+++ b/package.json@@ -24,6 +24,7 @@"amsul (https://github.com/amsul)","Andreas Brekken <[email protected]> (https://github.com/abrkn)","Andreas Lind <[email protected]> (https://github.com/papandreou)",+ "Andrew Krawchyk <[email protected]> (https://github.com/akrawchyk)","Andrew Miller <[email protected]> (https://github.com/vnikiti)","Andrew Nesbitt <[email protected]> (https://github.com/andrew)","Andrey Popp <[email protected]> (https://github.com/andreypopp)",@@ -343,7 +344,6 @@"karma-expect": "^1.1.2","karma-mocha": "^1.3.0","karma-mocha-reporter": "^2.2.4",- "karma-phantomjs-launcher": "^1.0.4","karma-sauce-launcher": "^1.2.0","markdown-toc": "^1.2.0","markdownlint-cli": "^0.6.0",