Skip to content

armgit / mocha

Public Imported from GitHub
0

☕️ Classic, reliable, trusted test framework for Node.js and the browser

Run eslint check correctly with forked PRs (#4606)

JeongHoon Byun (a.k.a Outsider)eb338fde965d
diff --git a/.github/workflows/mocha.yml b/.github/workflows/mocha.yml
index 745cb4b1..4857876b 100644
--- a/.github/workflows/mocha.yml
+++ b/.github/workflows/mocha.yml
@@ -31,29 +31,18 @@ jobs:
- 15
steps:
- uses: actions/checkout@v2
- - uses: actions/setup-node@v1
+ - uses: actions/setup-node@v2
with:
node-version: '${{ matrix.node }}'
- run: npm install --production
- run: npm run test:smoke
- eslint:
- name: ESLint Check
+ lint:
+ name: Linting code and markdown
runs-on: ubuntu-latest
needs: smoke
steps:
- - uses: actions/checkout@v2
- - uses: bradennapier/[email protected]
- with:
- issueSummary: false
- npmInstall: false
-
- markdown:
- name: Markdown Check
- runs-on: ubuntu-latest
- needs: smoke
- steps:
- - uses: actions/setup-node@v1
+ - uses: actions/setup-node@v2
with:
node-version: 14
- uses: actions/checkout@v2
@@ -66,8 +55,8 @@ jobs:
ubuntu-latest-node-v14-
- name: Install Dependencies
run: npm ci --ignore-scripts
- - name: 'Check Markdown'
- run: npm start lint.markdown
+ - name: 'Check lint'
+ run: npm start lint
test-node:
name: 'Node.js [v${{ matrix.node }} / ${{ matrix.os }}]'
@@ -148,7 +137,7 @@ jobs:
- name: Install libnotify-bin (Linux)
if: "${{ matrix.os == 'ubuntu-latest' }}"
run: sudo apt-get install libnotify-bin
- - uses: actions/setup-node@v1
+ - uses: actions/setup-node@v2
with:
node-version: '${{ matrix.node }}'
- uses: actions/checkout@v2
@@ -186,7 +175,7 @@ jobs:
timeout-minutes: 20
runs-on: ubuntu-latest
steps:
- - uses: actions/setup-node@v1
+ - uses: actions/setup-node@v2
with:
node-version: 14
- uses: actions/checkout@v2
diff --git a/.github/workflows/purge-expired-artifacts.yml b/.github/workflows/purge-expired-artifacts.yml
deleted file mode 100644
index 44692d7d..00000000
--- a/.github/workflows/purge-expired-artifacts.yml
+++ /dev/null
@@ -1,20 +0,0 @@
-# Deletes expired artifacts, which are not removed automatically by github.
-
-name: 'Purge expired artifacts'
-
-on:
- schedule:
- - cron: '0 1 * * *'
-
- # Allows you to run this workflow manually from the Actions tab
- workflow_dispatch:
-
-jobs:
- purge-artifacts:
- runs-on: ubuntu-latest
- steps:
- - uses: LKP-RnD/purge-expired-artifacts-action@v4
- with:
- token: ${{ secrets.GITHUB_TOKEN }}
- repo_to_purge: "mochajs/mocha"
- dry_run: "false"