Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(svg): reject nonfinite SVGNumber mutations
ldm008d17733fc74
diff --git a/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rs b/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rsindex 3a03f7079..e50a68415 100644--- a/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rs+++ b/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rs@@ -536,7 +536,7 @@ pub(super) fn svg_number_setter<'s>(if !require_svg_receiver(scope, args.this(), "SVGNumber", "value setter") {return;}- let value = match webidl::convert::<webidl::UnrestrictedDouble>(+ let value = match webidl::convert::<webidl::Double>(scope,args.get(0),webidl::Context::member("SVGNumber", "value"),diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rsindex 0e7b7ce95..a4d677c23 100644--- a/moli-renderer-v8/src/script_vm/tests/mod.rs+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs@@ -2168,6 +2168,7 @@ mod rendering_update;mod script_terminal_completion;mod streams;mod svg_filter_interfaces;+mod svg_number_validation;mod svg_root_factory_receivers;mod svg_switch_mpath_interfaces;mod url_components;diff --git a/moli-renderer-v8/src/script_vm/tests/svg_number_validation.rs b/moli-renderer-v8/src/script_vm/tests/svg_number_validation.rsnew file mode 100644index 000000000..cb2d1798d--- /dev/null+++ b/moli-renderer-v8/src/script_vm/tests/svg_number_validation.rs@@ -0,0 +1,37 @@+use super::*;++#[test]+fn svg_numbers_reject_nonfinite_values_without_mutating_the_list() {+ let mut vm = new_parsed_test_vm(+ "https://svg-number-validation.test/",+ "<!doctype html><html><body><iframe></iframe></body></html>",+ );+ assert_eq!(vm.eval(r#"(() => {+ const ns = 'http://www.w3.org/2000/svg';+ const child = document.querySelector('iframe').contentWindow;+ const check = (ok, label) => { if (!ok) throw Error(label); };+ const error = f => { try { f(); } catch (e) { return e; } };+ for (const realm of [window, child]) {+ const text = realm.document.createElementNS(ns, 'text');+ text.setAttribute('rotate', '10 20');+ const list = text.rotate.baseVal;+ const number = list.getItem(0);+ const setter = Object.getOwnPropertyDescriptor(realm.SVGNumber.prototype, 'value').set;+ for (const invalid of [NaN, Infinity, -Infinity, Symbol(), 1n]) {+ check(error(() => { number.value = invalid; }) instanceof realm.TypeError, 'invalid numeric value');+ check(number.value === 10 && list.getItem(1).value === 20, 'atomic numeric state');+ check(text.getAttribute('rotate') === '10 20', 'atomic owner attribute');+ }+ let conversions = 0;+ const value = { valueOf() { conversions++; return 30; } };+ for (const receiver of [{}, Object.create(number), new Proxy(number, {})]) {+ check(error(() => setter.call(receiver, value)) instanceof realm.TypeError, 'invalid numeric receiver');+ }+ check(conversions === 0, 'receiver validation precedes numeric conversion');+ number.value = value;+ check(conversions === 1 && number.value === 30, 'valid numeric conversion');+ check(text.getAttribute('rotate') === '30 20' && list.getItem(1).value === 20, 'valid owner reflection');+ }+ return true;+ })()"#).unwrap(), "true");+}