Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(window): avoid replaying completed auxiliary document lifecycle
ldm009bcbd0566ff
diff --git a/moli-protocol-server/src/protocol_server/tests/cdp_dynamic_page/auxiliary_page_identity.rs b/moli-protocol-server/src/protocol_server/tests/cdp_dynamic_page/auxiliary_page_identity.rsindex 41c358225..f11c634af 100644--- a/moli-protocol-server/src/protocol_server/tests/cdp_dynamic_page/auxiliary_page_identity.rs+++ b/moli-protocol-server/src/protocol_server/tests/cdp_dynamic_page/auxiliary_page_identity.rs@@ -136,6 +136,32 @@ async fn auxiliary_page_borrowed_close_uses_the_window_receiver() {abort_test_cdp_server(server).await;}+#[tokio::test(flavor = "multi_thread", worker_threads = 2)]+async fn auxiliary_initial_document_adoption_keeps_completed_lifecycle() {+ let (addr, server) = spawn_test_protocol_server().await;+ let (mut browser, _) =+ connect_async(format!("ws://{addr}/devtools/browser/{DEFAULT_BROWSER_ID}"))+ .await+ .unwrap();+ let opener_id = create_dynamic_target(&mut browser, 1).await;+ let mut opener = connect_dynamic_page(addr, &opener_id).await;+ let (_, mut child) = open_auxiliary(+ addr,+ &mut opener,+ "window.initialEvents=[];p.addEventListener('load',()=>initialEvents.push('load'));p.addEventListener('pageshow',()=>initialEvents.push('pageshow'))",+ )+ .await;+ assert_eq!(+ evaluate_window_name_probe(&mut opener, 2, "initialEvents",).await,+ json!([]),+ );+ assert_eq!(+ evaluate_window_name_probe(&mut child, 3, "document.readyState").await,+ json!("complete"),+ );+ abort_test_cdp_server(server).await;+}+#[tokio::test(flavor = "multi_thread", worker_threads = 2)]async fn auxiliary_page_keeps_synchronous_state_and_both_window_proxies_across_navigation() {let (fixture_addr, _fixture) = spawn_dedicated_fixture_server(diff --git a/moli-renderer-v8/src/runtime/page_vm/document_lifecycle_turn.rs b/moli-renderer-v8/src/runtime/page_vm/document_lifecycle_turn.rsindex cbe89e43b..afd08c638 100644--- a/moli-renderer-v8/src/runtime/page_vm/document_lifecycle_turn.rs+++ b/moli-renderer-v8/src/runtime/page_vm/document_lifecycle_turn.rs@@ -223,6 +223,22 @@ impl PageVm {self.activate_ready_document_replacement_lifecycle_admission(admission)?;}let document = self.document_lifecycle.identity();+ // Synchronous auxiliary Pages already have a complete initial Document.+ // Adopting that Page must observe its milestones without replaying the+ // parser lifecycle and firing load/pageshow on the opener's listeners.+ if work.is_empty()+ && matches!(+ self.document_lifecycle_wait_outcome(+ crate::runtime::RendererDocumentLifecycleMilestone::Load,+ ),+ RendererDocumentLifecycleWaitOutcome::Reached(_)+ )+ {+ self.set_target_stage(stage);+ return Ok(DocumentLifecycleTurnOutcome::idle(+ DocumentLifecycleTurnAction::ReachedStage(stage),+ ));+ }let has_sealed_main_parser_script_queue = work.iter().any(|item| item.main_parser_deferred_scripts_owner().is_some());