Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(selectors): honor native document design mode
ldm00d3d81829c0f
diff --git a/moli-dom/src/native/document.rs b/moli-dom/src/native/document.rsindex 1b24603fc..c4e90222b 100644--- a/moli-dom/src/native/document.rs+++ b/moli-dom/src/native/document.rs@@ -51,6 +51,7 @@ pub struct Document {ready_state: DocumentReadyState,quirks_mode: QuirksMode,kind: DocumentKind,+ design_mode_enabled: bool,css_target: Option<NativeNodeId>,default_language: Option<Box<str>>,source_last_modified_ms: Option<f64>,@@ -70,6 +71,7 @@ impl Document {ready_state: DocumentReadyState::Complete,quirks_mode: QuirksMode::NoQuirks,kind: DocumentKind::Html,+ design_mode_enabled: false,css_target: None,default_language: None,source_last_modified_ms: None,@@ -84,6 +86,7 @@ impl Document {ready_state: DocumentReadyState::Complete,quirks_mode: QuirksMode::NoQuirks,kind: DocumentKind::Xml,+ design_mode_enabled: false,css_target: None,default_language: None,source_last_modified_ms: None,@@ -126,6 +129,10 @@ impl Document {self.kind == DocumentKind::Html}+ pub fn design_mode_enabled(&self) -> bool {+ self.design_mode_enabled+ }+pub fn fallback_base_url(&self) -> &Url {self.base_url_state.fallback_base_url()}@@ -159,6 +166,10 @@ impl Document {self.content_type = content_type.into().into_boxed_str();}+ pub fn set_design_mode_enabled(&mut self, design_mode_enabled: bool) {+ self.design_mode_enabled = design_mode_enabled;+ }+pub fn set_css_target(&mut self, target: Option<NativeNodeId>) -> bool {if self.css_target == target {return false;diff --git a/moli-dom/src/native/host/clone.rs b/moli-dom/src/native/host/clone.rsindex 587ca8458..4430f1f3a 100644--- a/moli-dom/src/native/host/clone.rs+++ b/moli-dom/src/native/host/clone.rs@@ -489,12 +489,10 @@ impl DomHost {if !allow_document {return None;}- self.dom.create_node(- super::NodeData::Document(document.clone()),- None,- false,- false,- )+ let mut document = document.clone();+ document.set_design_mode_enabled(false);+ self.dom+ .create_node(super::NodeData::Document(document), None, false, false)}super::NodeData::DocumentType(doctype) => {self.create_document_type(doctype.name(), doctype.public_id(), doctype.system_id())@@ -626,6 +624,24 @@ mod tests {depth}+ #[test]+ fn document_clone_starts_with_design_mode_disabled() {+ let mut host = test_host();+ let document = host.document_handle();+ assert!(host.set_document_design_mode_enabled_for_handle(document, true));+ for deep in [false, true] {+ let clone = host.clone_node(document, deep).expect("document clone");+ assert_eq!(+ host.document_design_mode_enabled_for_handle(clone),+ Some(false)+ );+ }+ assert_eq!(+ host.document_design_mode_enabled_for_handle(document),+ Some(true)+ );+ }+#[test]fn script_clone_drops_trusted_source_state() {let mut host = test_host();diff --git a/moli-dom/src/native/host/document.rs b/moli-dom/src/native/host/document.rsindex 7d8f7689b..1d9301c61 100644--- a/moli-dom/src/native/host/document.rs+++ b/moli-dom/src/native/host/document.rs@@ -931,6 +931,34 @@ impl DomHost {.map(Document::quirks_mode)}+ pub fn document_design_mode_enabled_for_handle(+ &self,+ document_handle: DomHandle,+ ) -> Option<bool> {+ self.node(document_handle)+ .and_then(Node::as_document)+ .map(Document::design_mode_enabled)+ }++ pub fn set_document_design_mode_enabled_for_handle(+ &mut self,+ document_handle: DomHandle,+ design_mode_enabled: bool,+ ) -> bool {+ let Some(document) = self+ .node_mut(document_handle)+ .and_then(|node| node.data_mut().as_document_mut())+ else {+ return false;+ };+ if document.design_mode_enabled() == design_mode_enabled {+ return false;+ }+ document.set_design_mode_enabled(design_mode_enabled);+ self.record_mutation(MutationScope::QueryState);+ true+ }+pub fn document_base_url(&self) -> Option<Url> {self.document_base_url_for_handle(self.document_handle())}diff --git a/moli-renderer-v8/src/document_runtime.rs b/moli-renderer-v8/src/document_runtime.rsindex 4126a45ee..e150ffa43 100644--- a/moli-renderer-v8/src/document_runtime.rs+++ b/moli-renderer-v8/src/document_runtime.rs@@ -727,7 +727,6 @@ pub(super) struct DocumentRuntime {selector_engine: QueryEngine,selector_debug: SelectorDebugCounters,document: HostDocumentState,- design_mode_documents: HashSet<DomHandle>,script_execution_control: crate::script_execution_control::RendererScriptExecutionControl,author_styles_disabled: bool,bypass_content_security_policy: bool,diff --git a/moli-renderer-v8/src/document_runtime/dom_facade.rs b/moli-renderer-v8/src/document_runtime/dom_facade.rsindex f40a31ed7..ad9389366 100644--- a/moli-renderer-v8/src/document_runtime/dom_facade.rs+++ b/moli-renderer-v8/src/document_runtime/dom_facade.rs@@ -14,18 +14,14 @@ use html5ever::tree_builder::QuirksMode;// selector semantics or orchestrate mutation side effects on their own.impl DocumentRuntime {pub(crate) fn document_design_mode_enabled(&self, document: DomHandle) -> bool {- self.design_mode_documents.contains(&document)+ self.dom_host+ .document_design_mode_enabled_for_handle(document)+ .unwrap_or(false)}pub(crate) fn set_document_design_mode_enabled(&mut self, document: DomHandle, enabled: bool) {- if !self.dom_host.node(document).is_some_and(Node::is_document) {- return;- }- if enabled {- self.design_mode_documents.insert(document);- } else {- self.design_mode_documents.remove(&document);- }+ self.dom_host+ .set_document_design_mode_enabled_for_handle(document, enabled);}pub(crate) fn snapshot_document(&self) -> NativeDom {diff --git a/moli-renderer-v8/src/document_runtime/runtime_core.rs b/moli-renderer-v8/src/document_runtime/runtime_core.rsindex c189211b8..396309c8c 100644--- a/moli-renderer-v8/src/document_runtime/runtime_core.rs+++ b/moli-renderer-v8/src/document_runtime/runtime_core.rs@@ -73,7 +73,6 @@ impl DocumentRuntime {selector_engine: QueryEngine,selector_debug: SelectorDebugCounters::default(),document,- design_mode_documents: HashSet::new(),script_execution_control: Default::default(),author_styles_disabled: false,bypass_content_security_policy: false,@@ -202,7 +201,6 @@ impl DocumentRuntime {selector_engine: _,selector_debug: _,document: _,- design_mode_documents: _,script_execution_control: _,author_styles_disabled: _,bypass_content_security_policy: _,diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/shadow_dom.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/shadow_dom.rsindex d2109c2af..a1e71b60b 100644--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/shadow_dom.rs+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/shadow_dom.rs@@ -2105,25 +2105,42 @@ fn document_design_mode_controls_content_editable_without_crossing_shadow_roots(const inside = document.createElement('span');root.appendChild(inside);document.body.append(inherited, disabled);- const before = [document.designMode, inherited.isContentEditable].join(':');+ const before = [+ document.designMode,+ inherited.isContentEditable,+ inherited.matches(':read-write'),+ inherited.matches(':read-only')+ ].join(':');document.designMode = 'ON';const enabled = [document.designMode,inherited.isContentEditable,disabled.isContentEditable,- inside.isContentEditable+ inside.isContentEditable,+ inherited.matches(':read-write'),+ inherited.matches(':read-only'),+ disabled.matches(':read-write'),+ inside.matches(':read-write')].join(':');document.designMode = 'invalid';const afterInvalid = document.designMode;document.designMode = 'off';- const disabledAgain = [document.designMode, inherited.isContentEditable].join(':');+ const disabledAgain = [+ document.designMode,+ inherited.isContentEditable,+ inherited.matches(':read-write'),+ inherited.matches(':read-only')+ ].join(':');return [before, enabled, afterInvalid, disabledAgain].join('|');})()"#,).expect("Document designMode contenteditable probe should evaluate");- assert_eq!(result, "off:false|on:true:false:false|on|off:false");+ assert_eq!(+ result,+ "off:false:false:true|on:true:false:false:true:false:false:false|on|off:false:false:true"+ );}#[test]diff --git a/moli-selector/src/lib.rs b/moli-selector/src/lib.rsindex a7c1155c4..65921821e 100644--- a/moli-selector/src/lib.rs+++ b/moli-selector/src/lib.rs@@ -1356,6 +1356,33 @@ mod tests {);}+ #[test]+ fn dom_api_selectors_design_mode_marks_connected_elements_read_write() {+ let url = url::Url::parse("https://example.test/").unwrap();+ let mut host = DomHost::from_dom(NativeDom::new_html(url));+ host.reset_html_document_shell();+ let body = host.document_body_handle().unwrap();+ let paragraph = host.create_element("p");+ let blocked = host.create_element("div");+ assert!(host.set_attribute(blocked, "contenteditable", "false"));+ let detached = host.create_element("section");+ assert!(host.append_child(body, paragraph));+ assert!(host.append_child(body, blocked));+ assert!(host.set_document_design_mode_enabled_for_handle(host.document_handle(), true));++ let engine = QueryEngine;+ assert!(+ engine+ .matches_host(&host, paragraph, ":read-write")+ .unwrap()+ );+ assert!(!engine.matches_host(&host, paragraph, ":read-only").unwrap());+ assert!(!engine.matches_host(&host, blocked, ":read-write").unwrap());+ assert!(engine.matches_host(&host, blocked, ":read-only").unwrap());+ assert!(!engine.matches_host(&host, detached, ":read-write").unwrap());+ assert!(engine.matches_host(&host, detached, ":read-only").unwrap());+ }+#[test]fn dom_api_selectors_lang_uses_nearest_language_attribute() {let url = url::Url::parse("https://example.test/").unwrap();diff --git a/moli-selector/src/stylo/query/pseudo.rs b/moli-selector/src/stylo/query/pseudo.rsindex 9a1d980b1..ce304c473 100644--- a/moli-selector/src/stylo/query/pseudo.rs+++ b/moli-selector/src/stylo/query/pseudo.rs@@ -369,13 +369,19 @@ impl<'a> QueryElement<'a> {pub(super) fn is_editable(self) -> bool {let mut current = Some(self.handle);while let Some(handle) = current {- if let Some(element) = self.host.node(handle).and_then(Node::as_element)+ let Some(node) = self.host.node(handle) else {+ return false;+ };+ if let Some(document) = node.as_document() {+ return document.design_mode_enabled();+ }+ if let Some(element) = node.as_element()&& let Some(value) = element.attribute("contenteditable")&& let Some(is_editable) = contenteditable_value_is_editable(value){return is_editable;}- current = self.host.node(handle).and_then(Node::parent_node);+ current = node.parent_node();}false}