Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

Fix oversized replaced element sizing

ldm02371164e10bf
diff --git a/moli-layout/src/replaced.rs b/moli-layout/src/replaced.rs
index 6b274f0fc..8aa26d5b2 100644
--- a/moli-layout/src/replaced.rs
+++ b/moli-layout/src/replaced.rs
@@ -220,13 +220,15 @@ pub(crate) fn measure_replaced(
.min_size
.maybe_resolve(parent_size, resolve_stylo_calc_value)
.maybe_sub(box_sizing_adjustment);
+ // Available space is not an implicit `max-width`/`max-height`. Blink
+ // resolves a replaced atomic inline's used size before line breaking and
+ // lets an oversized result overflow; only authored max-size constraints
+ // belong in this clamp.
let mut max_size = style
.max_size
.maybe_resolve(preferred_basis, resolve_stylo_calc_value)
- .or(available_space.into_options())
- .maybe_min(available_space.into_options())
- .maybe_max(min_size)
- .maybe_sub(box_sizing_adjustment);
+ .maybe_sub(box_sizing_adjustment)
+ .maybe_max(min_size);
// A replaced element's intrinsic min/max-content constraint transfers a
// definite preferred size in the opposite axis through its preferred
diff --git a/moli-layout/tests/main_layout_contract.rs b/moli-layout/tests/main_layout_contract.rs
index 1ec20bfd3..6af100af8 100644
--- a/moli-layout/tests/main_layout_contract.rs
+++ b/moli-layout/tests/main_layout_contract.rs
@@ -63,6 +63,20 @@ impl FixtureNode {
}),
}
}
+
+ fn iframe(label: &'static str) -> Self {
+ Self {
+ label,
+ semantics: LayoutElementSemantics::new(
+ LayoutNamespace::Html,
+ "iframe",
+ LayoutElementCategory::Generic,
+ Some(LayoutReplacedKind::Frame),
+ ),
+ children: Vec::new(),
+ replaced_metrics: None,
+ }
+ }
}
#[derive(Debug)]
@@ -827,6 +841,41 @@ fn centered_grid_item_with_percent_height_and_auto_block_margin_keeps_intrinsic_
);
}
+#[test]
+fn oversized_percentage_inline_iframe_is_not_clamped_to_the_line_width() {
+ let source = FixtureSource {
+ nodes: vec![
+ FixtureNode::div("root", vec![1]),
+ FixtureNode::iframe("iframe"),
+ ],
+ };
+ let mut styles = FixtureStyles::default();
+ styles.0.insert(
+ 0,
+ fixed_box(LayoutDisplay::Block, 200.0, 100.0, PaintColor::TRANSPARENT),
+ );
+ styles.0.insert(
+ 1,
+ resolved(
+ LayoutDisplay::Inline,
+ Style {
+ size: Size {
+ width: percent(1.25),
+ height: length(40.0),
+ },
+ ..Style::default()
+ },
+ BLUE,
+ ),
+ );
+
+ let snapshot = render(&source, &mut styles, PaintViewport::new(300, 200, 1.0));
+ assert_rect(
+ solid_rect(&snapshot, BLUE),
+ PaintRect::new(0.0, 0.0, 250.0, 40.0),
+ );
+}
+
#[test]
fn static_insets_are_ignored_but_relative_insets_shift_the_box() {
let source = FixtureSource {
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs
index a99e5978a..8d1c9da48 100644
--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs
+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs
@@ -3367,6 +3367,36 @@ fn computed_width_resolves_percent_against_parent_and_child_frame_viewport() {
assert_eq!(result, "100px|100px");
}
+#[test]
+fn transformed_oversized_inline_iframe_uses_its_containing_block_percentage_basis() {
+ let mut vm = new_storage_test_vm("https://inline-iframe-percentage-size.test/");
+
+ let result = vm
+ .eval(
+ r#"
+(() => {
+ const html = document.documentElement || document.appendChild(document.createElement('html'));
+ const body = document.body || html.appendChild(document.createElement('body'));
+ const container = document.createElement('div');
+ container.style.cssText = 'width:auto;max-width:200px;height:100px;overflow:hidden';
+ const frame = document.createElement('iframe');
+ frame.style.cssText = 'width:calc(100% / 0.8);height:50px;border:0;transform:scale(0.8);transform-origin:0 0';
+ container.appendChild(frame);
+ body.appendChild(container);
+ const rect = frame.getBoundingClientRect();
+ return [
+ frame.offsetWidth,
+ frame.clientWidth,
+ rect.width
+ ].join('|');
+})()
+"#,
+ )
+ .expect("transformed inline iframe geometry should evaluate");
+
+ assert_eq!(result, "250|250|200");
+}
+
#[test]
fn computed_horizontal_margin_reads_preserve_retained_style_viewport_context() {
let mut vm = new_storage_test_vm("https://computed-margin-retained-context.test/");