Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(cssom): return independent live computed style declarations
ldm0240bb9ba2d23
diff --git a/moli-renderer-v8/src/native_bridge/bridge/wrappers.rs b/moli-renderer-v8/src/native_bridge/bridge/wrappers.rsindex 669ff4271..cd69582d8 100644--- a/moli-renderer-v8/src/native_bridge/bridge/wrappers.rs+++ b/moli-renderer-v8/src/native_bridge/bridge/wrappers.rs@@ -2,6 +2,12 @@ use super::super::{BridgeHandle, ComputedStyleDescriptor, DomTokenListKind, JsCouse super::NativeDomBridge;use crate::document_runtime::DomHandle;+#[derive(Clone, Copy, PartialEq, Eq)]+enum BridgeWrapperIdentity {+ Canonical,+ NewObject,+}+impl NativeDomBridge {pub(crate) fn install_default_world_wrapper_cache(&self, context: v8::Local<'_, v8::Context>) {self.identity.install_default_world_wrapper_cache(context);@@ -48,6 +54,16 @@ impl NativeDomBridge {scope: &mut v8::PinScope<'s, 'i>,host_ptr: *mut JsContextHost,handle: BridgeHandle,+ ) -> Option<v8::Local<'s, v8::Object>> {+ self.materialize_bridge_wrapper(scope, host_ptr, handle, BridgeWrapperIdentity::Canonical)+ }++ fn materialize_bridge_wrapper<'s, 'i>(+ &mut self,+ scope: &mut v8::PinScope<'s, 'i>,+ host_ptr: *mut JsContextHost,+ handle: BridgeHandle,+ identity: BridgeWrapperIdentity,) -> Option<v8::Local<'s, v8::Object>> {let current_host =crate::util::context_host_ptr_from_context_slot(scope.get_current_context())?;@@ -61,17 +77,23 @@ impl NativeDomBridge {.window_execution_context(scope, owner, dispatch_scope)?.1;let scope = &mut v8::ContextScope::new(scope, context);- return self.wrap_bridge_handle(scope, host_ptr, handle);+ return self.materialize_bridge_wrapper(scope, host_ptr, handle, identity);}+ // A reflector describes the native read source. NewObject declarations+ // can share that descriptor while their JS objects remain independent.let reflector_id = self.identity.reflector_id(&handle);- if let Some(wrapper) = self.identity.cached_wrapper(scope, reflector_id) {+ if identity == BridgeWrapperIdentity::Canonical+ && let Some(wrapper) = self.identity.cached_wrapper(scope, reflector_id)+ {return Some(wrapper);}let wrapper = self.bindings.instantiate_wrapper(scope, host_ptr, handle, reflector_id);- self.identity.cache_wrapper(scope, reflector_id, wrapper);+ if identity == BridgeWrapperIdentity::Canonical {+ self.identity.cache_wrapper(scope, reflector_id, wrapper);+ }Some(wrapper)}@@ -153,17 +175,18 @@ impl NativeDomBridge {self.wrap_bridge_handle(scope, runtime_ptr, BridgeHandle::Style(handle))}- pub(crate) fn wrap_computed_style<'s, 'i>(+ pub(crate) fn create_computed_style<'s, 'i>(&mut self,scope: &mut v8::PinScope<'s, 'i>,runtime_ptr: *mut JsContextHost,handle: DomHandle,descriptor: ComputedStyleDescriptor,) -> Option<v8::Local<'s, v8::Object>> {- self.wrap_bridge_handle(+ self.materialize_bridge_wrapper(scope,runtime_ptr,BridgeHandle::ComputedStyle(handle, std::rc::Rc::new(descriptor)),+ BridgeWrapperIdentity::NewObject,)}}diff --git a/moli-renderer-v8/src/native_bridge/context_host/popups.rs b/moli-renderer-v8/src/native_bridge/context_host/popups.rsindex dcb29d407..bfe6e2d27 100644--- a/moli-renderer-v8/src/native_bridge/context_host/popups.rs+++ b/moli-renderer-v8/src/native_bridge/context_host/popups.rs@@ -4751,7 +4751,7 @@ fn lightweight_popup_get_computed_style_callback<'s>(let host = unsafe { &mut *host_ptr };let Some(style) = host.native_bridge_mut()- .wrap_computed_style(scope, host_ptr, target, descriptor)+ .create_computed_style(scope, host_ptr, target, descriptor)else {rv.set_null();return;diff --git a/moli-renderer-v8/src/native_bridge/document/detached_install/accessors/iframe_style.rs b/moli-renderer-v8/src/native_bridge/document/detached_install/accessors/iframe_style.rsindex 8bea41be2..d7f119b46 100644--- a/moli-renderer-v8/src/native_bridge/document/detached_install/accessors/iframe_style.rs+++ b/moli-renderer-v8/src/native_bridge/document/detached_install/accessors/iframe_style.rs@@ -76,7 +76,7 @@ fn detached_iframe_get_computed_style_callback<'s>(let host = unsafe { &mut *runtime_ptr };let Some(style) =host.native_bridge_mut()- .wrap_computed_style(scope, runtime_ptr, target, descriptor)+ .create_computed_style(scope, runtime_ptr, target, descriptor)else {rv.set_null();return;diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rsindex c32393428..854b983bd 100644--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs@@ -65,3 +65,5 @@ mod stylesheet_and_document_lifecycle;mod cssom_arguments;mod cssom_write_conversion;++mod cssom_identity;diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style/cssom_identity.js b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style/cssom_identity.jsnew file mode 100644index 000000000..f70db52f1--- /dev/null+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style/cssom_identity.js@@ -0,0 +1,123 @@+(() => {+ const checks = [];+ const record = (name, verify) => {+ try { checks.push({name, passed: verify() === true}); }+ catch (error) { checks.push({name, passed: false, error: String(error)}); }+ };+ const frame = document.createElement('iframe');+ document.body.appendChild(frame);+ const popup = window.open('about:blank', '_blank');+ const owners = [window, frame.contentWindow, popup];+ const realmObservations = [];+ try {+ for (const [ownerIndex, owner] of owners.entries()) {+ const doc = owner.document;+ const sheet = doc.createElement('style');+ sheet.textContent = '.cssom-identity-target::before { content: "x"; color: rgb(4, 5, 6); }';+ doc.head.appendChild(sheet);+ const html = doc.createElement('div'), svg = doc.createElementNS('http://www.w3.org/2000/svg', 'svg');+ const detached = doc.createElement('div');+ for (const target of [html, svg, detached]) {+ target.setAttribute('class', 'cssom-identity-target');+ target.style.color = 'rgb(1, 2, 3)';+ }+ doc.body.append(html, svg);+ for (const [kind, target] of [['HTML', html], ['SVG', svg], ['detached', detached]]) {+ for (const [pseudoName, pseudo, expected] of [+ ['originating', undefined, 'rgb(1, 2, 3)'], ['nullable', null, 'rgb(1, 2, 3)'],+ ['empty string', '', 'rgb(1, 2, 3)'], ['before', '::before', 'rgb(4, 5, 6)'],+ ['single colon before', ':before', 'rgb(4, 5, 6)'], ['invalid', '::unknown-pseudo', ''],+ ['part', '::part(token)', ''],+ ]) {+ const label = `owner ${ownerIndex}/${kind}/${pseudoName}`;+ const first = owner.getComputedStyle(target, pseudo);+ const second = owner.getComputedStyle(target, pseudo);+ const originalPrototype = Object.getPrototypeOf(first);+ record(label + '/new object', () => first !== second);+ // Popup interface-global exposure is a separate, existing main gap.+ // Its NewObject, prototype independence and live-state checks still run.+ if (ownerIndex !== 2)+ record(label + '/platform brand', () => second instanceof owner.CSSStyleDeclaration);+ record(label + '/value', () => second.color === (kind === 'detached' ? '' : expected));+ try {+ record(label + '/own expando', () => {+ first.__identityMarker = 'first';+ return Object.hasOwn(first, '__identityMarker');+ });+ record(label + '/own descriptor', () => {+ Object.defineProperty(first, '__identityDescriptor', {value: 17, configurable: true});+ return Object.getOwnPropertyDescriptor(first, '__identityDescriptor').value === 17;+ });+ record(label + '/expando isolated', () => !Object.hasOwn(second, '__identityMarker'));+ record(label + '/descriptor isolated', () => Object.getOwnPropertyDescriptor(second, '__identityDescriptor') === undefined);+ Object.setPrototypeOf(first, Object.create(originalPrototype));+ record(label + '/prototype isolated', () => Object.getPrototypeOf(second) === originalPrototype);+ record(label + '/third object', () => {+ const third = owner.getComputedStyle(target, pseudo);+ return third !== first && third !== second && Object.getPrototypeOf(third) === originalPrototype;+ });+ } finally {+ Object.setPrototypeOf(first, originalPrototype);+ delete first.__identityMarker;+ delete first.__identityDescriptor;+ }+ }+ const one = owner.getComputedStyle(target), two = owner.getComputedStyle(target);+ const inline = target.style;+ target.style.color = 'rgb(7, 8, 9)';+ record(`owner ${ownerIndex}/${kind}/held first stays live`, () => one.color === (kind === 'detached' ? '' : 'rgb(7, 8, 9)'));+ record(`owner ${ownerIndex}/${kind}/held second stays live`, () => two.color === (kind === 'detached' ? '' : 'rgb(7, 8, 9)'));+ record(`owner ${ownerIndex}/${kind}/inline SameObject`, () => target.style === inline);+ record(`owner ${ownerIndex}/${kind}/inline distinct`, () => inline !== one && inline !== two);+ if (typeof target.computedStyleMap === 'function') {+ const map = target.computedStyleMap();+ record(`owner ${ownerIndex}/${kind}/computed map SameObject`, () => target.computedStyleMap() === map);+ }+ target.style.color = 'rgb(1, 2, 3)';+ }+ html.remove(); svg.remove(); sheet.remove();+ }+ const root = document.createElement('div');+ root.style.color = 'rgb(1, 2, 3)';+ document.body.appendChild(root);+ const declarations = Array.from({length: 128}, () => window.getComputedStyle(root));+ record('128 calls yield 128 objects', () => new Set(declarations).size === 128);+ record('128 expando writes accepted', () => {+ for (const [index, declaration] of declarations.entries()) declaration.__identityToken = index;+ return true;+ });+ record('128 independent expandos', () => declarations.every((declaration, index) => declaration.__identityToken === index));+ root.style.color = 'rgb(10, 11, 12)';+ record('128 declarations share live native state', () => declarations.every(declaration => declaration.color === 'rgb(10, 11, 12)'));+ root.remove();+ record('128 declarations observe disconnection', () => declarations.every(declaration => declaration.length === 0));+ document.body.appendChild(root);+ record('128 declarations observe reconnection', () => declarations.every(declaration => declaration.color === 'rgb(10, 11, 12)'));+ root.remove();+ for (const [targetIndex, targetOwner] of owners.entries()) {+ const target = targetOwner.document.createElement('div');+ target.style.color = 'rgb(1, 2, 3)';+ targetOwner.document.body.appendChild(target);+ for (const [functionIndex, functionOwner] of owners.entries()) {+ for (const [receiverIndex, receiver] of owners.entries()) {+ try {+ const result = Reflect.apply(functionOwner.getComputedStyle, receiver, [target]);+ realmObservations.push({targetIndex, functionIndex, receiverIndex, null: result === null,+ color: result?.color, prototypeRealms: result === null ? [] : owners.map(owner =>+ Object.getPrototypeOf(result) === (owner.CSSStyleProperties ?? owner.CSSStyleDeclaration).prototype)});+ } catch (error) {+ realmObservations.push({targetIndex, functionIndex, receiverIndex, error: String(error)});+ }+ }+ }+ target.remove();+ }+ globalThis.__computedStyleIdentityResults = {complete: true, total: checks.length,+ passed: checks.filter(row => row.passed).length, checks, realmObservations};+ globalThis.__uiEventResults = globalThis.__computedStyleIdentityResults;+ return true;+ } finally {+ frame.remove();+ if (popup && !popup.closed) popup.close();+ }+})();diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style/cssom_identity.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style/cssom_identity.rsnew file mode 100644index 000000000..1cc47a908--- /dev/null+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style/cssom_identity.rs@@ -0,0 +1,126 @@+use super::*;++#[test]+fn computed_style_declarations_have_independent_objects_and_live_native_state() {+ let mut vm = new_storage_page_task_executor_test_vm("https://computed-style-identity.test/");+ vm.eval(include_str!("cssom_identity.js"))+ .expect("computed-style identity checks should evaluate");+ assert_eq!(+ vm.eval("__computedStyleIdentityResults.complete").unwrap(),+ "true"+ );+ assert_eq!(+ vm.eval("JSON.stringify(__computedStyleIdentityResults.checks.filter(row => !row.passed))")+ .unwrap(),+ "[]"+ );+ assert_eq!(+ vm.eval("__computedStyleIdentityResults.total === 597 && __computedStyleIdentityResults.passed === 597")+ .unwrap(),+ "true"+ );+}++#[test]+fn computed_style_declarations_are_collectible_and_reuse_native_descriptors() {+ let mut vm = new_storage_page_task_executor_test_vm("https://computed-style-identity-gc.test/");+ vm.eval(+ r#"+globalThis.identityGcTarget = document.createElement('div');+identityGcTarget.style.color = 'rgb(1, 2, 3)';+document.body.appendChild(identityGcTarget);+globalThis.identityGcHeld = getComputedStyle(identityGcTarget);+globalThis.identityGcHeldRef = new WeakRef(identityGcHeld);+globalThis.identityGcTemporary = Array.from({length: 128}, () => new WeakRef(getComputedStyle(identityGcTarget)));+globalThis.identityDescriptorProbes = Array.from({length: 128}, () => getComputedStyle(identityGcTarget));+globalThis.identityInline = identityGcTarget.style;+"#,+ )+ .unwrap();+ assert_eq!(+ vm.eval("new Set(identityDescriptorProbes).size === 128")+ .unwrap(),+ "true"+ );+ vm.with_default_context_scope_and_checkpoint_for_test(|scope, _| {+ let global = scope.get_current_context().global(scope);+ let name = v8::String::new(scope, "identityDescriptorProbes").unwrap();+ let probes =+ v8::Local::<v8::Array>::try_from(global.get(scope, name.into()).unwrap()).unwrap();+ let mut reflector = None;+ for index in 0..probes.length() {+ let wrapper =+ v8::Local::<v8::Object>::try_from(probes.get_index(scope, index).unwrap()).unwrap();+ let id = wrapper.get_internal_field(scope, 0).unwrap();+ let id = v8::Local::<v8::Number>::try_from(id).unwrap().value() as u64;+ assert_eq!(+ *reflector.get_or_insert(id),+ id,+ "new declarations should reuse their native descriptor"+ );+ }+ Ok(())+ })+ .unwrap();+ assert_eq!(vm.eval("identityGcHeld.color").unwrap(), "rgb(1, 2, 3)");+ let document = vm.document_handle_for_test();+ let cached = vm.computed_style_cache_entry_count_for_document_for_test(document);+ vm.eval(+ "identityDescriptorProbes = null; for (let i = 0; i < 512; i++) getComputedStyle(identityGcTarget).color;"+ )+ .unwrap();+ assert_eq!(+ vm.computed_style_cache_entry_count_for_document_for_test(document),+ cached,+ "new declarations must preserve the shared native style cache"+ );+ let collect = |vm: &mut crate::runtime::PageVmTaskExecutorTestHarness| {+ vm.renderer_document_isolate+ .clone()+ .with_entered_renderer_document_isolate(|isolate| {+ isolate.clear_kept_objects();+ isolate.low_memory_notification();+ Ok(())+ })+ .unwrap();+ };+ collect(&mut vm);+ assert_eq!(+ vm.eval("identityGcTemporary.every(ref => ref.deref() === undefined) && identityGcHeldRef.deref() === identityGcHeld && identityGcTarget.style === identityInline")+ .unwrap(),+ "true"+ );+ vm.eval("identityGcTarget.style.color = 'rgb(7, 8, 9)';")+ .unwrap();+ assert_eq!(vm.eval("identityGcHeld.color").unwrap(), "rgb(7, 8, 9)");+ vm.eval("identityGcHeld = null").unwrap();+ collect(&mut vm);+ assert_eq!(+ vm.eval("identityGcHeldRef.deref() === undefined").unwrap(),+ "true"+ );+}++#[test]+fn detached_iframe_computed_style_declarations_are_fresh_objects() {+ let mut vm = new_storage_page_task_executor_test_vm("https://detached-style-identity.test/");+ assert_eq!(+ vm.eval(+ r#"(() => {+const detached = document.implementation.createHTMLDocument('');+const frame = detached.createElement('iframe');+detached.body.appendChild(frame);+const child = frame.contentWindow;+const target = child.document.createElement('div');+child.document.body.appendChild(target);+const first = child.getComputedStyle(target), second = child.getComputedStyle(target);+first.__identityTag = 'first';+target.style.color = 'rgb(1, 2, 3)';+return first !== second && !Object.hasOwn(second, '__identityTag') &&+ first.color === 'rgb(1, 2, 3)' && second.color === 'rgb(1, 2, 3)';+})()"#,+ )+ .unwrap(),+ "true"+ );+}diff --git a/moli-renderer-v8/src/window_host.rs b/moli-renderer-v8/src/window_host.rsindex b1dd3654c..c8f64ac5a 100644--- a/moli-renderer-v8/src/window_host.rs+++ b/moli-renderer-v8/src/window_host.rs@@ -1159,7 +1159,7 @@ pub(crate) fn build_computed_style_object<'s>(}let style = host.native_bridge_mut()- .wrap_computed_style(scope, host_ptr, handle, descriptor)?;+ .create_computed_style(scope, host_ptr, handle, descriptor)?;let empty = v8::Boolean::new(scope, forced_empty);set_private_value(scope,