Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(navigation): construct native events in their target realm
ldm0307feab20c76
diff --git a/moli-core/tests/fixtures/runtime/navigation_event_realms.html b/moli-core/tests/fixtures/runtime/navigation_event_realms.htmlnew file mode 100644index 000000000..f386d11d0--- /dev/null+++ b/moli-core/tests/fixtures/runtime/navigation_event_realms.html@@ -0,0 +1,101 @@+<!doctype html><body><script>+window.finished = (async () => {+ await new Promise(resolve => addEventListener('load', () => setTimeout(resolve, 0), {once: true}));+ const frame = document.createElement('iframe');+ const loaded = new Promise(resolve => frame.onload = () => setTimeout(resolve, 0));+ frame.src = '/static?navigation-event-realm';+ document.body.append(frame);+ await loaded;+ const child = frame.contentWindow;+ const scenario = __SCENARIO__;+ const target = __TARGET__ === 'top' ? window : child;+ const caller = target === window ? child : window;+ const errors = [];+ const events = [];+ let reads = 0;+ const check = (condition, message) => { if (!condition) errors.push(message); };+ const names = ['Event', 'ErrorEvent', 'NavigateEvent', 'NavigationCurrentEntryChangeEvent', 'AbortController'];+ const observedNames = [...names, 'AbortSignal', 'NavigationHistoryEntry'];+ const originals = new Map([window, child].map(win =>+ [win, Object.fromEntries(observedNames.map(name => [name, win[name]]))]));+ for (const win of [window, child]) win.addEventListener('error', event => errors.push('uncaught:' + event.message));+ function tamper() {+ if (__CONSTRUCTORS__ !== 'overwritten') return;+ for (const win of [window, child]) for (const name of names) {+ Object.defineProperty(win, name, {configurable: true, get() {+ reads++;+ throw new Error('Public constructor accessed: ' + name);+ }});+ }+ }+ function record(win, receiver, event, constructor) {+ events.push(event);+ const original = originals.get(win)[constructor];+ check(event.constructor === original, event.type + ': constructor realm');+ check(Object.getPrototypeOf(event) === original.prototype, event.type + ': prototype realm');+ check(event.target === receiver && event.currentTarget === receiver, event.type + ': target');+ check(event.isTrusted && !event.bubbles && !event.composed, event.type + ': native flags');+ if (event.type === 'navigate') {+ check(event.destination instanceof win.Object, 'navigate: destination realm');+ check(Object.getPrototypeOf(event.signal) === originals.get(win).AbortSignal.prototype,+ 'navigate: signal realm');+ if (scenario === 'reject')+ event.signal.onabort = abort => record(win, event.signal, abort, 'Event');+ }+ if (event.type === 'currententrychange')+ check(Object.getPrototypeOf(event.from) === originals.get(win).NavigationHistoryEntry.prototype,+ 'currententrychange: from realm');+ if (event.type !== 'navigate' && event.type !== 'navigateerror')+ check(!event.cancelable, event.type + ': cancelable');+ }+ function observe(win) {+ const nav = win.navigation;+ for (const [type, constructor] of [+ ['navigate', 'NavigateEvent'], ['currententrychange', 'NavigationCurrentEntryChangeEvent'],+ ['navigatesuccess', 'Event'], ['navigateerror', 'ErrorEvent']+ ]) nav.addEventListener(type, event => record(win, nav, event, constructor));+ }+ {+ const nav = target.navigation;+ const methods = caller.Navigation.prototype;+ observe(target);+ tamper();+ if (scenario === 'reject') {+ const reason = new caller.TypeError('cross-window rejection');+ nav.onnavigate = event => event.intercept({handler: () => Promise.reject(reason)});+ const result = methods.navigate.call(nav, '#rejected');+ await result.committed;+ const rejection = await result.finished.then(() => null, error => error);+ const errorEvent = events.find(event => event.type === 'navigateerror');+ check(rejection === reason, 'rejection: promise error identity');+ check(errorEvent && errorEvent.error === reason, 'rejection: event error identity');+ check(errorEvent && errorEvent.message.includes('cross-window rejection'), 'rejection: message');+ } else {+ const initial = nav.currentEntry;+ await methods.navigate.call(nav, '#one').finished;+ const replaced = nav.currentEntry;+ check(Object.getPrototypeOf(replaced) === originals.get(target).NavigationHistoryEntry.prototype,+ 'navigate: entry realm');+ replaced.ondispose = event => record(target, replaced, event, 'Event');+ await methods.navigate.call(nav, '#two', {history: 'replace'}).finished;+ methods.updateCurrentEntry.call(nav, {state: {saved: true}});+ check(nav.currentEntry.getState().saved, 'updateCurrentEntry: state');+ await methods.back.call(nav).finished;+ check(nav.currentEntry === initial, 'traversal: original entry identity');+ const changes = events.filter(event => event.type === 'currententrychange');+ check(JSON.stringify(changes.map(event => event.navigationType)) ===+ JSON.stringify(['push', 'replace', null, 'traverse']), 'currententrychange: navigationType');+ check(changes[0] && changes[0].from === initial && changes[1] && changes[1].from === replaced,+ 'currententrychange: from identity');+ }+ }+ return {errors, reads, events: events.map(event => event.type)};+})().then(result => {+ document.body.dataset.result = JSON.stringify(result);+ return result;+}, error => {+ const result = {exception: String(error)};+ document.body.dataset.result = JSON.stringify(result);+ return result;+});+</script>diff --git a/moli-core/tests/history_event_realms.rs b/moli-core/tests/history_event_realms.rsnew file mode 100644index 000000000..0ab5104b2--- /dev/null+++ b/moli-core/tests/history_event_realms.rs@@ -0,0 +1,63 @@+use anyhow::Result;+use moli_core::runtime::{Browser, BrowserConfig};+use moli_test_support::FixtureServer;+use serde_json::{Value, json};+use tokio::time::Duration;+use url::Url;++async fn navigation_events(scenario: &str, target: &str, constructors: &str) -> Result<Value> {+ let markup = include_str!("fixtures/runtime/navigation_event_realms.html")+ .replace("__SCENARIO__", &serde_json::to_string(scenario)?)+ .replace("__TARGET__", &serde_json::to_string(target)?)+ .replace("__CONSTRUCTORS__", &serde_json::to_string(constructors)?);+ let server = FixtureServer::spawn().await?;+ let browser = Browser::new(BrowserConfig::default())?;+ let mut url = Url::parse(&server.url("/compat/child-dynamic-markup-document"))?;+ url.query_pairs_mut().append_pair("markup", &markup);+ let result = tokio::time::timeout(Duration::from_secs(10), async {+ let mut page = browser.fetch(url.as_str()).await?;+ page.evaluate_runtime_expression_with_await_async(+ "finished.then(value => JSON.stringify(value))",+ true,+ )+ .await+ })+ .await??;+ let result = serde_json::from_str(result["value"].as_str().unwrap())?;+ server.shutdown().await;+ Ok(result)+}++#[tokio::test(flavor = "multi_thread")]+async fn cross_window_navigation_events_use_the_target_realm_and_native_constructors() -> Result<()>+{+ for constructors in ["original", "overwritten"] {+ for target in ["top", "child"] {+ for scenario in ["success", "reject"] {+ let events = if scenario == "success" {+ json!([+ "navigate",+ "currententrychange",+ "navigatesuccess",+ "navigate",+ "currententrychange",+ "dispose",+ "navigatesuccess",+ "currententrychange",+ "navigate",+ "currententrychange",+ "navigatesuccess"+ ])+ } else {+ json!(["navigate", "currententrychange", "abort", "navigateerror"])+ };+ assert_eq!(+ navigation_events(scenario, target, constructors).await?,+ json!({"errors": [], "reads": 0, "events": events}),+ "{scenario}/{target}/{constructors}"+ );+ }+ }+ }+ Ok(())+}diff --git a/moli-renderer-v8/src/context_bootstrap/history_mutation.rs b/moli-renderer-v8/src/context_bootstrap/history_mutation.rsindex 4edfa9e32..c1c18424e 100644--- a/moli-renderer-v8/src/context_bootstrap/history_mutation.rs+++ b/moli-renderer-v8/src/context_bootstrap/history_mutation.rs@@ -197,6 +197,7 @@ fn mutate_history_object<'s>(let next_navigation_index = current_navigation_index + 1;let entry = create_navigation_entry(scope,+ owner,url.as_str(),None,next_navigation_index,@@ -216,6 +217,7 @@ fn mutate_history_object<'s>(.unwrap_or_else(|| new_navigation_entry_key().as_str().to_owned());let entry = create_navigation_entry(scope,+ owner,url.as_str(),None,current_navigation_index,diff --git a/moli-renderer-v8/src/context_bootstrap/navigation_callbacks/navigation.rs b/moli-renderer-v8/src/context_bootstrap/navigation_callbacks/navigation.rsindex 90fe9b5ab..5687f93b0 100644--- a/moli-renderer-v8/src/context_bootstrap/navigation_callbacks/navigation.rs+++ b/moli-renderer-v8/src/context_bootstrap/navigation_callbacks/navigation.rs@@ -10,7 +10,7 @@ use super::super::navigation_lifecycle::{navigation_attempt_id_from_slot, navigation_attempt_is_active, settle_navigation_committed,settle_navigation_finished_rejected_after_reactions,settle_navigation_finished_resolved_after_reactions,- settle_navigation_transition_finished_local,+ settle_navigation_finished_resolved_immediately, settle_navigation_transition_finished_local,};use super::super::navigation_window::{navigation_document_can_update_current_entry, navigation_document_is_active,@@ -1390,8 +1390,7 @@ pub(in crate::context_bootstrap) fn settle_intercepted_same_document_navigation<// committed entry captured before a reentrant navigation can replace it.set_navigation_active_intercept_settlement(scope, navigation, data);if let Some(resolve) = committed_resolve.take() {- let receiver = v8::undefined(scope).into();- let _ = resolve.call(scope, receiver, &[resolved_value]);+ settle_navigation_finished_resolved_immediately(scope, resolve, resolved_value);}if transition_resolver.is_some_and(|resolver| navigation_transition_matches_resolver(scope, navigation, resolver))@@ -1556,8 +1555,7 @@ pub(in crate::context_bootstrap) fn cancel_active_intercepted_same_document_navifinish_navigation_error_events(scope, navigation, error, &filename);let receiver = v8::undefined(scope).into();if let Some(committed_resolve) = committed_resolve {- let _ = committed_resolve.call(scope, receiver, &[resolved_value]);- resolve_navigation_transition_committed(scope, navigation, resolved_value);+ settle_navigation_committed(scope, navigation, committed_resolve, resolved_value);}if let Some(reject) = reject {let _ = reject.call(scope, receiver, &[error]);@@ -1809,9 +1807,7 @@ fn finish_intercepted_navigation_rejected<'s>(}finish_navigation_error_events(scope, navigation, error, filename);if let Some(committed_resolve) = committed_resolve {- let receiver = v8::undefined(scope).into();- let _ = committed_resolve.call(scope, receiver, &[resolved_value]);- resolve_navigation_transition_committed(scope, navigation, resolved_value);+ settle_navigation_committed(scope, navigation, committed_resolve, resolved_value);}if let Some(reject) = finished_reject {settle_navigation_finished_rejected_after_reactions(scope, reject, error);diff --git a/moli-renderer-v8/src/context_bootstrap/navigation_entry.rs b/moli-renderer-v8/src/context_bootstrap/navigation_entry.rsindex f017bdb53..11602d0b5 100644--- a/moli-renderer-v8/src/context_bootstrap/navigation_entry.rs+++ b/moli-renderer-v8/src/context_bootstrap/navigation_entry.rs@@ -118,6 +118,7 @@ pub(super) fn restore_current_navigation_entry_scroll_position<'s>(pub(super) fn create_navigation_entry<'s>(scope: &mut v8::PinScope<'s, '_>,+ owner: v8::Local<'s, v8::Object>,url: &str,referrer_policy: Option<&str>,index: u32,@@ -139,7 +140,7 @@ pub(super) fn create_navigation_entry<'s>(scroll_offset: None,}.into_ref();- wrap_native_navigation_entry(scope, entry)+ native::entry_wrapper(scope, owner, entry)}pub(in crate::context_bootstrap) fn wrap_native_navigation_entry<'s>(diff --git a/moli-renderer-v8/src/context_bootstrap/navigation_events.rs b/moli-renderer-v8/src/context_bootstrap/navigation_events.rsindex 35cb2703a..15857a9a0 100644--- a/moli-renderer-v8/src/context_bootstrap/navigation_events.rs+++ b/moli-renderer-v8/src/context_bootstrap/navigation_events.rs@@ -729,14 +729,14 @@ pub(super) fn dispatch_navigation_currententrychange<'s>(from: Option<v8::Local<'s, v8::Object>>,navigation_type: Option<&str>,) {- let global = scope.get_current_context().global(scope);- let Some(event_ctor) = global- .get(- scope,- v8str(scope, "NavigationCurrentEntryChangeEvent").into(),- )- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- else {+ let context = navigation+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);+ let Ok(event_ctor) = super::exposed_interfaces::ensure_intrinsic_interface_constructor(+ scope,+ "NavigationCurrentEntryChangeEvent",+ ) else {return;};let init = NavigationCurrentEntryChangeEventInitDeclaration {@@ -770,17 +770,13 @@ pub(super) fn dispatch_navigation_entry_dispose<'s>(scope: &mut v8::PinScope<'s, '_>,entry: v8::Local<'s, v8::Object>,) {- let global = scope.get_current_context().global(scope);- let Some(event_ctor) = global- .get(scope, v8str(scope, "Event").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- else {- return;- };- let Some(event) = event_ctor.new_instance(scope, &[v8str(scope, "dispose").into()]) else {+ let context = entry+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);+ let Some(event) = construct_original_event(scope, "dispose") else {return;};- mark_event_trusted(scope, event);let _ = dispatch_simple_event_target_event(scope,entry,@@ -794,18 +790,13 @@ pub(super) fn dispatch_navigation_success<'s>(scope: &mut v8::PinScope<'s, '_>,navigation: v8::Local<'s, v8::Object>,) {- let global = scope.get_current_context().global(scope);- let Some(event_ctor) = global- .get(scope, v8str(scope, "Event").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- else {+ let context = navigation+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);+ let Some(event) = construct_original_event(scope, "navigatesuccess") else {return;};- let Some(event) = event_ctor.new_instance(scope, &[v8str(scope, "navigatesuccess").into()])- else {- return;- };- mark_event_trusted(scope, event);let _ = dispatch_simple_event_target_event(scope,navigation,@@ -821,7 +812,15 @@ pub(super) fn dispatch_navigation_error<'s>(error: v8::Local<'s, v8::Value>,filename: &str,) {- let global = scope.get_current_context().global(scope);+ let context = navigation+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);+ let Ok(event_ctor) =+ super::exposed_interfaces::ensure_intrinsic_interface_constructor(scope, "ErrorEvent")+ else {+ return;+ };let message = error.to_string(scope).map(|value| value.to_rust_string_lossy(scope))@@ -836,10 +835,7 @@ pub(super) fn dispatch_navigation_error<'s>(.bind(scope).expect("NavigationErrorEvent init declaration should bind");let event_type = v8str(scope, "navigateerror");- let event = global- .get(scope, v8str(scope, "ErrorEvent").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- .and_then(|ctor| ctor.new_instance(scope, &[event_type.into(), init.into()]));+ let event = event_ctor.new_instance(scope, &[event_type.into(), init.into()]);let Some(event) = event else {return;};@@ -902,12 +898,14 @@ pub(super) fn dispatch_navigation_navigate_event_with_form_data_and_outcome<'s>(form_data: Option<v8::Local<'s, v8::Value>>,source_element: Option<v8::Local<'s, v8::Object>>,) -> NavigationDispatchOutcome<'s> {- let global = scope.get_current_context().global(scope);+ let context = navigation+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);let focus_reset_epoch = context_host_ptr_from_global_bridge(scope).map(|host_ptr| unsafe { &*host_ptr }.focus_change_epoch());- let Some(event_ctor) = global- .get(scope, v8str(scope, "NavigateEvent").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())+ let Ok(event_ctor) =+ super::exposed_interfaces::ensure_intrinsic_interface_constructor(scope, "NavigateEvent")else {return NavigationDispatchOutcome::proceed();};@@ -1128,21 +1126,17 @@ fn dispatch_cross_document_navigation_navigate_event_for_window_with_type_form_dlet Some(navigation) = window_navigation_for_holder(scope, owner) else {return true;};+ let context = navigation+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);if download_request.is_some() {let _ = cancel_active_navigation_event(scope, navigation);cancel_active_intercepted_same_document_navigation(scope, navigation);}- let event_ctor = owner- .get(scope, v8str(scope, "NavigateEvent").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- .or_else(|| {- scope- .get_current_context()- .global(scope)- .get(scope, v8str(scope, "NavigateEvent").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- });- let Some(event_ctor) = event_ctor else {+ let Ok(event_ctor) =+ super::exposed_interfaces::ensure_intrinsic_interface_constructor(scope, "NavigateEvent")+ else {return true;};let current_href = window_location_for_holder(scope, owner)@@ -1230,12 +1224,14 @@ pub(super) fn dispatch_navigation_traverse_event_with_outcome<'s>(target_index: u32,info: Option<v8::Local<'s, v8::Value>>,) -> NavigationDispatchOutcome<'s> {- let global = scope.get_current_context().global(scope);+ let context = navigation+ .get_creation_context(scope)+ .unwrap_or_else(|| scope.get_current_context());+ let scope = &mut v8::ContextScope::new(scope, context);let focus_reset_epoch = context_host_ptr_from_global_bridge(scope).map(|host_ptr| unsafe { &*host_ptr }.focus_change_epoch());- let Some(event_ctor) = global- .get(scope, v8str(scope, "NavigateEvent").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())+ let Ok(event_ctor) =+ super::exposed_interfaces::ensure_intrinsic_interface_constructor(scope, "NavigateEvent")else {return NavigationDispatchOutcome::proceed();};@@ -1612,10 +1608,8 @@ fn navigation_destination_entry_string_property<'s>(fn create_navigation_abort_signal<'s>(scope: &mut v8::PinScope<'s, '_>,) -> v8::Local<'s, v8::Value> {- let global = scope.get_current_context().global(scope);- let Some(controller_ctor) = global- .get(scope, v8str(scope, "AbortController").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())+ let Ok(controller_ctor) =+ super::exposed_interfaces::ensure_intrinsic_interface_constructor(scope, "AbortController")else {return v8::null(scope).into();};diff --git a/moli-renderer-v8/src/context_bootstrap/navigation_mutation/local.rs b/moli-renderer-v8/src/context_bootstrap/navigation_mutation/local.rsindex 5e3be4df1..8d07f4ea2 100644--- a/moli-renderer-v8/src/context_bootstrap/navigation_mutation/local.rs+++ b/moli-renderer-v8/src/context_bootstrap/navigation_mutation/local.rs@@ -24,6 +24,7 @@ pub(crate) fn apply_local_window_location_navigation<'s>(let state = v8::null(scope).into();let next_entry = create_navigation_entry(scope,+ owner,resolved.as_str(),None,next_navigation_index,@@ -58,6 +59,7 @@ pub(crate) fn apply_local_window_location_navigation<'s>(.unwrap_or_else(|| new_navigation_entry_key().as_str().to_owned());let entry = create_navigation_entry(scope,+ owner,resolved.as_str(),None,current_navigation_index,diff --git a/moli-renderer-v8/src/context_bootstrap/navigation_mutation/same_document.rs b/moli-renderer-v8/src/context_bootstrap/navigation_mutation/same_document.rsindex 31cee1179..4e084fea3 100644--- a/moli-renderer-v8/src/context_bootstrap/navigation_mutation/same_document.rs+++ b/moli-renderer-v8/src/context_bootstrap/navigation_mutation/same_document.rs@@ -27,6 +27,7 @@ pub(in crate::context_bootstrap) fn update_navigation_current_entry_for_same_doclet next_navigation_index = current_navigation_index + 1;let next_entry = create_navigation_entry(scope,+ owner,href,None,next_navigation_index,@@ -49,6 +50,7 @@ pub(in crate::context_bootstrap) fn update_navigation_current_entry_for_same_doc.unwrap_or_else(|| new_navigation_entry_key().as_str().to_owned());let entry = create_navigation_entry(scope,+ owner,href,None,current_navigation_index,@@ -107,6 +109,7 @@ pub(in crate::context_bootstrap) fn apply_navigation_navigate_same_document<'s>(let next_navigation_index = current_navigation_index + 1;let next_entry = create_navigation_entry(scope,+ owner,href,None,next_navigation_index,@@ -143,6 +146,7 @@ pub(in crate::context_bootstrap) fn apply_navigation_navigate_same_document<'s>(.unwrap_or_else(|| new_navigation_entry_key().as_str().to_owned());let entry = create_navigation_entry(scope,+ owner,href,None,current_navigation_index,diff --git a/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rs b/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rsindex 9637c9f9b..54ad9ed37 100644--- a/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rs+++ b/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rs@@ -94,7 +94,8 @@ const DIRECT_V8_CALL_ALLOWLIST: &[AllowedDirectCallFile] = &[),allowed("context_bootstrap/navigation_callbacks/navigation.rs",- 11,+ // Three settlement calls now go through the existing shared helpers.+ 8,DirectCallOwner::BrowserAlgorithm,),allowed(