Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
perf(style): inline single effects during DOM mutation conversion
ldm03e3d4d3e5e14
diff --git a/Cargo.lock b/Cargo.lockindex 20dbc7aa2..016b0b69e 100644--- a/Cargo.lock+++ b/Cargo.lock@@ -3142,6 +3142,7 @@ dependencies = ["serde","serde_json","serde_v8",+ "smallvec","strum","stylo","stylo_dom",diff --git a/moli-renderer-v8/Cargo.toml b/moli-renderer-v8/Cargo.tomlindex 7c20cddc8..287e451ba 100644--- a/moli-renderer-v8/Cargo.toml+++ b/moli-renderer-v8/Cargo.toml@@ -106,6 +106,7 @@ xml5ever = "0.39.0"serde = { version = "1.0.228", features = ["derive"] }serde_json = { version = "1.0.145", features = ["raw_value"] }serde_v8 = "=0.320.0"+smallvec = "1.15.1"strum = { version = "0.28.0", features = ["derive"] }# Tokio >=1.53 releases a dropped mpsc receiver's waker even while context-wide# senders remain (tokio-rs/tokio#8095). Older versions retain stopped rendererdiff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/style_invalidation.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/style_invalidation.rsindex 584c7fe70..a8f8b7173 100644--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/style_invalidation.rs+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/style_invalidation.rs@@ -972,6 +972,69 @@ fn character_data_invalidation_preserves_unaffected_subtree_cache() {assert_eq!(after, "rgb(1, 2, 3)|rgb(4, 5, 6)|rgb(7, 8, 9)");}++#[test]+fn character_data_updates_preserve_style_and_observer_notifications_in_each_document() {+ let mut vm = new_storage_test_vm("https://character-data-notifications.test/");+ let result = vm+ .eval(+ r#"+(() => {+ return JSON.stringify([document, document.implementation.createHTMLDocument('detached')].map(doc => {+ const root = doc.documentElement || doc.appendChild(doc.createElement('html'));+ const head = doc.head || root.appendChild(doc.createElement('head'));+ const body = doc.body || root.appendChild(doc.createElement('body'));+ const style = doc.createElement('style');+ style.textContent = '#target { color: rgb(4, 5, 6); } #target:empty { color: rgb(1, 2, 3); }';+ head.appendChild(style);+ const target = doc.createElement('div');+ target.id = 'target';+ const text = doc.createTextNode('');+ target.appendChild(text);+ body.appendChild(target);+ const observer = new MutationObserver(() => {});+ observer.observe(text, { characterData: true, characterDataOldValue: true });++ const colors = [getComputedStyle(target).color];+ text.appendData('first');+ colors.push(getComputedStyle(target).color);+ text.appendData('second');+ colors.push(getComputedStyle(target).color);+ text.data = '';+ colors.push(getComputedStyle(target).color);+ const records = observer.takeRecords();+ observer.disconnect();+ return [colors, records.map(record => record.oldValue),+ records.every(record => record.type === 'characterData' && record.target === text),+ text.ownerDocument === doc];+ }));+})()+"#,+ )+ .expect("text updates should preserve style and observer notifications across documents");++ let expected = serde_json::json!([+ [+ "rgb(1, 2, 3)",+ "rgb(4, 5, 6)",+ "rgb(4, 5, 6)",+ "rgb(1, 2, 3)"+ ],+ ["", "first", "firstsecond"],+ true,+ true+ ]);+ // A windowless document has empty computed declarations, but its text+ // mutations must still deliver every observer record with its old value.+ let detached_expected =+ serde_json::json!([["", "", "", ""], ["", "first", "firstsecond"], true, true]);+ assert_eq!(+ serde_json::from_str::<serde_json::Value>(&result)+ .expect("notification facts should be JSON"),+ serde_json::json!([expected, detached_expected])+ );+}+#[test]fn unrelated_sibling_combinator_character_data_invalidation_preserves_later_cache() {let mut vm = new_storage_test_vm("https://character-data-sibling-cache.test/");diff --git a/moli-renderer-v8/src/style_engine/mutation_effect.rs b/moli-renderer-v8/src/style_engine/mutation_effect.rsindex ea25c3be9..7f9186193 100644--- a/moli-renderer-v8/src/style_engine/mutation_effect.rs+++ b/moli-renderer-v8/src/style_engine/mutation_effect.rs@@ -5,6 +5,7 @@ use moli_selector::{StyloElementDependencySnapshot as StyleElementDependencySnapshot,stylo_removed_element_dependency_snapshots as removed_element_dependency_snapshots,};+use smallvec::SmallVec;use crate::{document_runtime::DomHandle,@@ -70,7 +71,19 @@ impl StyleMutationEffect {pub(crate) fn from_dom_mutation_effects(host: &DomHost,effects: &DomMutationEffects,- ) -> Vec<Self> {+ ) -> SmallVec<[Self; 1]> {+ // A single text update needs neither deduplication nor a heap buffer.+ let style = effects.style();+ if let [node] = style.character_data_mutations()+ && style.attribute_mutations().is_empty()+ && style.child_list_mutations().is_empty()+ && effects.tree().connected_roots().is_empty()+ && effects.tree().disconnected_roots().is_empty()+ && effects.slots().assignment_changes().is_empty()+ && effects.slots().changed_slots().is_empty()+ {+ return SmallVec::from_buf([Self::CharacterData { node: *node }]);+ }let mut style_effects = IndexSet::new();let connected_roots = effects.tree().connected_roots();#[cfg(debug_assertions)]