Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(svg): reflect animated integer attributes
ldm0416b8dbf4b6c
diff --git a/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs b/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rsindex 0e3ef8a5b..4b412daaf 100644--- a/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs+++ b/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs@@ -1145,7 +1145,7 @@ struct SvgAnimatedNumberTemplateAccessorsDeclaration {}#[derive(WebApiFunctionTemplate)]-#[webapi(interface = web_api_interfaces::SVGAnimatedInteger, enumerable)]+#[webapi(interface = web_api_interfaces::SVGAnimatedInteger, enumerable, receiver)]struct SvgAnimatedIntegerTemplateAccessorsDeclaration {#[webapi(accessor_property = "baseVal",diff --git a/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rs b/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rsindex f7e3f0597..75f7400fc 100644--- a/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rs+++ b/moli-renderer-v8/src/context_bootstrap/svg_runtime/callbacks.rs@@ -1824,9 +1824,12 @@ pub(super) fn svg_animated_integer_getter<'s>(rv.set_undefined();return;};+ let Some(receiver) = moli_webapi_declare::web_api_object_target(scope, args.this()) else {+ return;+ };if !require_svg_receiver(scope,- args.this(),+ receiver,"SVGAnimatedInteger",&format!("{name} getter"),) {@@ -1840,11 +1843,11 @@ pub(super) fn svg_animated_integer_getter<'s>(return;}};- sync_svg_animated_integer_from_owner_attribute(scope, args.this());- let initial_value = svg_animated_integer_property(scope, args.this())+ sync_svg_animated_integer_from_owner_attribute(scope, receiver);+ let initial_value = svg_animated_integer_property(scope, receiver).map(|property| property.initial_value).unwrap_or_default();- let value = get_private_value(scope, args.this(), slot)+ let value = get_private_value(scope, receiver, slot).and_then(|value| value.int32_value(scope)).unwrap_or(initial_value);rv.set(v8::Integer::new(scope, value).into());@@ -2022,9 +2025,12 @@ pub(super) fn svg_animated_integer_setter<'s>() else {return;};+ let Some(receiver) = moli_webapi_declare::web_api_object_target(scope, args.this()) else {+ return;+ };if !require_svg_receiver(scope,- args.this(),+ receiver,"SVGAnimatedInteger",&format!("{name} setter"),) || name != "baseVal"@@ -2042,8 +2048,8 @@ pub(super) fn svg_animated_integer_setter<'s>(return;}};- set_svg_animated_integer_values(scope, args.this(), value);- reflect_svg_animated_integer_to_owner_attribute(scope, args.this());+ set_svg_animated_integer_values(scope, receiver, value);+ reflect_svg_animated_integer_to_owner_attribute(scope, receiver);}pub(super) fn svg_animated_transform_list_getter<'s>(diff --git a/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/geometry_and_svg.rs b/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/geometry_and_svg.rsindex 42fa08daa..cc159dcaf 100644--- a/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/geometry_and_svg.rs+++ b/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/geometry_and_svg.rs@@ -2347,3 +2347,32 @@ fn svg_filter_primitives_expose_native_dom_attributes() {"true");}++#[test]+fn svg_animated_integers_use_native_identity_in_windowless_and_child_documents() {+ let mut vm = new_parsed_test_vm(+ "https://svg-animated-integer.test/",+ "<!doctype html><html><body><iframe></iframe></body></html>",+ );+ assert_eq!(vm.eval(r#"(() => {+ const ns = 'http://www.w3.org/2000/svg';+ const child = document.querySelector('iframe').contentWindow;+ const check = (ok, label) => { if (!ok) throw Error(label); };+ for (const realm of [window, child]) {+ for (const doc of [realm.document, realm.document.implementation.createHTMLDocument('')]) {+ const filter = doc.createElementNS(ns, 'feConvolveMatrix');+ const getter = Object.getOwnPropertyDescriptor(window.SVGFEConvolveMatrixElement.prototype, 'orderX').get;+ const value = getter.call(filter);+ check(value instanceof realm.SVGAnimatedInteger, 'producer realm');+ check(value === filter.orderX && value.baseVal === 3, 'retained native identity');+ filter.setAttribute('order', '4 6');+ check(value.baseVal === 4 && filter.orderY.baseVal === 6, 'attribute synchronization');+ value.baseVal = 7;+ check(filter.getAttribute('order') === '7 6', 'windowless native reflection');+ filter.removeAttribute('order');+ check(value.baseVal === 3 && value.animVal === 3, 'removed attribute default');+ }+ }+ return true;+ })()"#).unwrap(), "true");+}