Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

Fix legacy center user agent alignment

ldm04a765d821ac0
diff --git a/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs b/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs
index 376030cbe..f211a5946 100644
--- a/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs
+++ b/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs
@@ -1108,6 +1108,57 @@ document.body.innerHTML = `
.expect("atomic inline fit-content fixture should run");
}
+#[tokio::test(flavor = "current_thread")]
+async fn center_user_agent_alignment_centers_atomic_inline_children() {
+ run_page_vm_async_test(async move {
+ let loader =
+ crate::network::ResourceRequestClient::new(&FetchConfig::default()).expect("loader");
+ let mut page_vm = test_page_vm_with_loader_and_document_url(
+ &loader,
+ Vec::new(),
+ Url::parse("https://example.com/center-user-agent-alignment.html")?,
+ );
+ page_vm.vm_mut().eval(
+ r#"
+document.head.innerHTML = `<style>
+html,body{margin:0;padding:0}
+#host{width:584px;margin-left:100px;font-size:0}
+#first,#second{display:inline-block;height:20px}
+#first{width:120px}
+#second{width:100px}
+</style>`;
+document.body.innerHTML = `<center id=host><span id=first></span><span id=second></span></center>`;
+'installed'
+"#,
+ )?;
+ page_vm.vm_mut().sync_live_document_style_sources();
+
+ let geometry = page_vm.vm_mut().eval(
+ r#"JSON.stringify(Object.fromEntries(['host','first','second'].map(id=>{const r=document.getElementById(id).getBoundingClientRect();return [id,[r.x,r.y,r.width,r.height]]})))"#,
+ )?;
+ let geometry: serde_json::Value = serde_json::from_str(&geometry)?;
+ for (id, expected) in [
+ ("host", [100.0, 0.0, 584.0, 20.0]),
+ ("first", [282.0, 0.0, 120.0, 20.0]),
+ ("second", [402.0, 0.0, 100.0, 20.0]),
+ ] {
+ let actual = geometry[id]
+ .as_array()
+ .unwrap_or_else(|| panic!("missing geometry for {id}: {geometry}"));
+ for (index, expected) in expected.into_iter().enumerate() {
+ let actual = actual[index].as_f64().expect("numeric geometry") as f32;
+ assert!(
+ (actual - expected).abs() <= 0.05,
+ "{id}[{index}]: expected {expected}, got {actual}; geometry={geometry}"
+ );
+ }
+ }
+ Ok::<_, anyhow::Error>(())
+ })
+ .await
+ .expect("center user-agent alignment fixture should run");
+}
+
#[tokio::test(flavor = "current_thread")]
async fn absolute_auto_width_from_an_inline_formatting_context_shrinks_to_fit() {
run_page_vm_async_test(async move {
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs
index 004c6ed9b..d3b82facf 100644
--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs
+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/computed_style.rs
@@ -54,6 +54,30 @@ fn rendered_text_elements_use_chromium_user_agent_defaults() {
assert_eq!(result, "block|block|block");
}
+#[test]
+fn center_uses_legacy_centering_user_agent_default() {
+ let mut vm = new_parsed_test_vm(
+ "https://center-user-agent-default.test/",
+ r#"<!doctype html>
+<html><head><style>#overridden { text-align: right; }</style></head><body>
+ <center id="default">default</center>
+ <center id="overridden">overridden</center>
+</body></html>"#,
+ );
+
+ let result = vm
+ .eval(
+ r#"
+['default', 'overridden']
+ .map(id => getComputedStyle(document.getElementById(id)).textAlign)
+ .join('|')
+"#,
+ )
+ .expect("center user-agent alignment should evaluate");
+
+ assert_eq!(result, "-moz-center|right");
+}
+
#[test]
fn list_items_and_first_details_summary_use_user_agent_display_defaults() {
let mut vm = new_parsed_test_vm(
diff --git a/moli-renderer-v8/src/style_engine/ua/html.css b/moli-renderer-v8/src/style_engine/ua/html.css
index 8a9cc8acd..d73e49966 100644
--- a/moli-renderer-v8/src/style_engine/ua/html.css
+++ b/moli-renderer-v8/src/style_engine/ua/html.css
@@ -35,6 +35,11 @@ ul, ol, menu, h1, h2, h3, h4, h5, h6, hr, listing, plaintext, pre, xmp {
display: block;
}
+center {
+ /* Stylo's legacy-centering equivalent of Blink's -webkit-center. */
+ text-align: -moz-center;
+}
+
marquee,
input, textarea, select, button {
display: inline-block;