Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(wpt): match the wptserve header count limit

ldm0569a74f5205c
diff --git a/moli-benchmark/moli_benchmark/wpt_cross/server.py b/moli-benchmark/moli_benchmark/wpt_cross/server.py
index b6408b521..b44197ff7 100644
--- a/moli-benchmark/moli_benchmark/wpt_cross/server.py
+++ b/moli-benchmark/moli_benchmark/wpt_cross/server.py
@@ -25,6 +25,7 @@ from __future__ import annotations
import base64
import hashlib
import html
+import http.client
import json
import math
import mimetypes
@@ -63,6 +64,10 @@ from .case_set import (
)
+# Match wptserve's bounded header count for both requests and responses.
+http.client._MAXHEADERS = 512
+
+
DEFAULT_TESTHARNESS_TIMEOUT_SECONDS = 10.0
MAX_REQUEST_BODY_BYTES = 16 * 1024 * 1024
MAX_REQUEST_BODY_LINE_BYTES = 64 * 1024
diff --git a/moli-benchmark/tests/test_wpt_header_count.py b/moli-benchmark/tests/test_wpt_header_count.py
new file mode 100644
index 000000000..57bd7f8c6
--- /dev/null
+++ b/moli-benchmark/tests/test_wpt_header_count.py
@@ -0,0 +1,53 @@
+from __future__ import annotations
+
+import tempfile
+import unittest
+from http.client import HTTPConnection
+from pathlib import Path
+from unittest.mock import patch
+
+from moli_benchmark.wpt_cross.server import WptFixtureServer
+
+
+class HeaderCountFixtureTests(unittest.TestCase):
+ def test_more_than_250_request_and_response_headers_are_supported(self) -> None:
+ with tempfile.TemporaryDirectory() as root:
+ directory = Path(root)
+ (directory / "resources").mkdir()
+ (directory / "resources/testharness.js").write_text("// testharness")
+ (directory / "headers.txt").write_text("ok")
+ (directory / "headers.txt.headers").write_text(
+ "\n".join(f"X-Response-{index}: value-{index}" for index in range(253))
+ )
+ with patch("moli_benchmark.wpt_cross.server._global_ipv6_address", return_value=None), WptFixtureServer(directory) as server:
+ connection = HTTPConnection("127.0.0.1", server.port, timeout=2)
+ self.addCleanup(connection.close)
+ connection.request("GET", "/headers.txt", headers={
+ f"X-Request-{index}": f"value-{index}" for index in range(253)
+ })
+ response = connection.getresponse()
+ self.assertEqual(response.status, 200)
+ self.assertEqual(response.read(), b"ok")
+ for index in range(253):
+ self.assertEqual(response.headers[f"X-Response-{index}"], f"value-{index}")
+
+ def test_header_count_and_line_length_remain_bounded(self) -> None:
+ with tempfile.TemporaryDirectory() as root:
+ directory = Path(root)
+ (directory / "resources").mkdir()
+ (directory / "resources/testharness.js").write_text("// testharness")
+ with patch("moli_benchmark.wpt_cross.server._global_ipv6_address", return_value=None), WptFixtureServer(directory) as server:
+ for headers in ({f"val{index}": "value" for index in range(512)}, {"X-Long": "x" * (64 * 1024)}):
+ with self.subTest(header_count=len(headers)):
+ connection = HTTPConnection("127.0.0.1", server.port, timeout=2)
+ try:
+ connection.request("GET", "/fetch/api/resources/status.py", headers=headers)
+ response = connection.getresponse()
+ self.assertEqual(response.status, 431)
+ response.read()
+ finally:
+ connection.close()
+
+
+if __name__ == "__main__":
+ unittest.main()