Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(html): expose Document lifecycle members with native receivers

ldm06352114d1922
diff --git a/moli-renderer-v8/src/native_bridge/document.rs b/moli-renderer-v8/src/native_bridge/document.rs
index e0f6b871c..41525d96a 100644
--- a/moli-renderer-v8/src/native_bridge/document.rs
+++ b/moli-renderer-v8/src/native_bridge/document.rs
@@ -399,6 +399,11 @@ struct DocumentStatePrototypeDeclaration {
visibility_state: (),
#[webapi(accessor_property, getter = document_prerendering_getter_function)]
prerendering: (),
+ #[webapi(
+ accessor_property = "wasDiscarded",
+ getter = document_was_discarded_getter_function
+ )]
+ was_discarded: (),
#[webapi(
accessor_property,
getter = document_domain_getter_function,
@@ -1110,6 +1115,14 @@ fn document_prerendering_getter_function<'s>(
rv.set_bool(false);
}
+fn document_was_discarded_getter_function<'s>(
+ _scope: &mut v8::PinScope<'s, '_>,
+ _args: v8::FunctionCallbackArguments<'s>,
+ mut rv: v8::ReturnValue<'s, v8::Value>,
+) {
+ rv.set_bool(false);
+}
+
fn document_scrolling_element_getter_function<'s>(
scope: &mut v8::PinScope<'s, '_>,
args: v8::FunctionCallbackArguments<'s>,
diff --git a/moli-renderer-v8/src/native_bridge/element/event_handlers/generic.rs b/moli-renderer-v8/src/native_bridge/element/event_handlers/generic.rs
index 828774067..8515680b3 100644
--- a/moli-renderer-v8/src/native_bridge/element/event_handlers/generic.rs
+++ b/moli-renderer-v8/src/native_bridge/element/event_handlers/generic.rs
@@ -107,7 +107,11 @@ pub(crate) const GENERIC_EVENT_HANDLER_PROPERTIES: &[&str] = &[
"onratechange",
];
-const DOCUMENT_EVENT_HANDLER_PROPERTIES: &[&str] = &["onpointerlockchange", "onpointerlockerror"];
+const DOCUMENT_EVENT_HANDLER_PROPERTIES: &[&str] = &[
+ "onpointerlockchange",
+ "onpointerlockerror",
+ "onreadystatechange",
+];
#[derive(Clone, Copy)]
pub(crate) enum GlobalEventHandlerOwner {
@@ -507,7 +511,7 @@ fn event_handler_event_type(name: &str) -> Option<&str> {
}
fn legacy_lenient_this_event_handler(name: &str) -> bool {
- matches!(name, "onmouseenter" | "onmouseleave")
+ matches!(name, "onmouseenter" | "onmouseleave" | "onreadystatechange")
}
fn handle_invalid_event_handler_receiver<'s>(
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_bindings.rs b/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_bindings.rs
index ac9c5d13b..8e49ff65c 100644
--- a/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_bindings.rs
+++ b/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_bindings.rs
@@ -111,7 +111,7 @@ root.appendChild(frame);
.filter(|check| check["pass"] != true)
.collect();
assert_eq!(result["state"], "pass", "{failures:?}");
- assert_eq!(checks.len(), 111);
+ assert_eq!(checks.len(), 117);
}
#[test]
diff --git a/moli-renderer-v8/tests/fixtures/document-member-receivers.js b/moli-renderer-v8/tests/fixtures/document-member-receivers.js
index 718e7726f..3e7594d37 100644
--- a/moli-renderer-v8/tests/fixtures/document-member-receivers.js
+++ b/moli-renderer-v8/tests/fixtures/document-member-receivers.js
@@ -37,7 +37,8 @@ async function documentMemberReceiverProbe() {
const fn = descriptor[kind];
if (typeof fn !== 'function') continue;
const label = `${realmName}/${C.name}.${name}/${kind}`;
- const lenient = name === 'onmouseenter' || name === 'onmouseleave';
+ // HTML marks all three attributes [LegacyLenientThis].
+ const lenient = ['onmouseenter', 'onmouseleave', 'onreadystatechange'].includes(name);
const argumentLists = kind === 'get' ? [[]] : kind === 'set' ? [[poison]] :
[[], Array(5).fill(poison), ...(nodeArguments[name] ? [nodeArguments[name]] : [])];
const errors = [];
diff --git a/moli-renderer-v8/tests/fixtures/document-receivers.js b/moli-renderer-v8/tests/fixtures/document-receivers.js
index 2e82f4c3a..35a092903 100644
--- a/moli-renderer-v8/tests/fixtures/document-receivers.js
+++ b/moli-renderer-v8/tests/fixtures/document-receivers.js
@@ -15,7 +15,7 @@ async function documentReceiverProbe() {
'URL', 'documentURI', 'readyState', 'contentType', 'characterSet', 'charset',
'inputEncoding', 'compatMode', 'lastModified', 'referrer', 'defaultView',
'activeElement', 'implementation', 'fonts', 'currentScript', 'hidden',
- 'visibilityState', 'prerendering', 'domain', 'scrollingElement'
+ 'visibilityState', 'prerendering', 'wasDiscarded', 'domain', 'scrollingElement'
];
let traps = 0;
const revoked = Proxy.revocable(document, {});
@@ -71,11 +71,14 @@ async function documentReceiverProbe() {
check(`${realmName}/domain/genuine-conversion-${index}`, caught === sentinel, true);
}
check(`${realmName}/domain/conversion-count`, conversions, genuine.length);
+ const ready = Object.getOwnPropertyDescriptor(realm.Document.prototype, 'onreadystatechange');
for (const [name, descriptor] of [
+ ['onreadystatechange', ready],
['onmouseenter', Object.getOwnPropertyDescriptor(realm.HTMLElement.prototype, 'onmouseenter')],
['onmouseleave', Object.getOwnPropertyDescriptor(realm.HTMLElement.prototype, 'onmouseleave')]
]) {
- const incompatible = invalid.filter(receiver => receiver !== element);
+ const incompatible = name === 'onreadystatechange'
+ ? invalid : invalid.filter(receiver => receiver !== element);
check(`${realmName}/${name}/lenient`, incompatible.map(receiver => {
try {
return descriptor.get.call(receiver) === undefined &&