Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

refactor(cdp): register remote objects from the terminal payload

ldm06e30806c729b
diff --git a/moli-protocol/src/domains/dom/resolve/native/remote_object.rs b/moli-protocol/src/domains/dom/resolve/native/remote_object.rs
index 13701b883..c818d8445 100644
--- a/moli-protocol/src/domains/dom/resolve/native/remote_object.rs
+++ b/moli-protocol/src/domains/dom/resolve/native/remote_object.rs
@@ -137,9 +137,8 @@ fn registered_response(
group: Option<String>,
cached: Option<(String, Value)>,
) -> Response {
- let mut response = Response::success(result.clone());
+ let mut response = Response::success(result);
response.state_updates.push(Update::RemoteObjects {
- result,
object_group: group,
});
if let Some((object_id, node)) = cached {
diff --git a/moli-protocol/src/domains/native.rs b/moli-protocol/src/domains/native.rs
index a3a5a66d4..eba1e12b6 100644
--- a/moli-protocol/src/domains/native.rs
+++ b/moli-protocol/src/domains/native.rs
@@ -216,16 +216,16 @@ pub(crate) fn project_terminal_for_owner(
continue;
};
match update {
- moli_core::RendererNativeProtocolStateUpdate::RemoteObjects {
- result,
- object_group,
- } => {
+ moli_core::RendererNativeProtocolStateUpdate::RemoteObjects { object_group } => {
+ let Ok(result) = &response.result else {
+ continue;
+ };
if let Some(group) = object_group {
conn.register_runtime_remote_object_ids_from_value_for_owner_with_group(
- owner, &result, &group,
+ owner, result, &group,
);
} else {
- conn.register_runtime_remote_object_ids_from_value_for_owner(owner, &result);
+ conn.register_runtime_remote_object_ids_from_value_for_owner(owner, result);
}
}
moli_core::RendererNativeProtocolStateUpdate::DomRemoteObjectNode {
diff --git a/moli-renderer-v8/src/runtime/protocol_output/native_response.rs b/moli-renderer-v8/src/runtime/protocol_output/native_response.rs
index 81743279a..ca03a62c7 100644
--- a/moli-renderer-v8/src/runtime/protocol_output/native_response.rs
+++ b/moli-renderer-v8/src/runtime/protocol_output/native_response.rs
@@ -73,10 +73,9 @@ impl RendererNativeProtocolResponse {
/// never callbacks into a live Page, and are discarded on attachment retirement.
#[derive(Clone, Debug, PartialEq, Eq)]
pub enum RendererNativeProtocolStateUpdate {
- RemoteObjects {
- result: serde_json::Value,
- object_group: Option<String>,
- },
+ /// Register object IDs from the successful terminal result before delivery.
+ /// The reply already owns the payload; this update only retains its group.
+ RemoteObjects { object_group: Option<String> },
DomRemoteObjectNode {
object_id: String,
node: serde_json::Value,
diff --git a/moli-renderer-v8/src/runtime/protocol_output/transport_memory.rs b/moli-renderer-v8/src/runtime/protocol_output/transport_memory.rs
index b552a1b9c..527a4e108 100644
--- a/moli-renderer-v8/src/runtime/protocol_output/transport_memory.rs
+++ b/moli-renderer-v8/src/runtime/protocol_output/transport_memory.rs
@@ -34,11 +34,8 @@ fn native_terminal_charge_bytes(terminal: &super::RendererNativeCommandTerminal)
});
for update in &response.state_updates {
charge = charge.saturating_add(match update {
- super::RendererNativeProtocolStateUpdate::RemoteObjects {
- result,
- object_group,
- } => {
- json_charge(result).saturating_add(object_group.as_deref().map_or(0, string_charge))
+ super::RendererNativeProtocolStateUpdate::RemoteObjects { object_group } => {
+ object_group.as_deref().map_or(0, string_charge)
}
super::RendererNativeProtocolStateUpdate::DomRemoteObjectNode { object_id, node } => {
string_charge(object_id).saturating_add(json_charge(node))