Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(webidl): derive svg length receiver checks

ldm06f00c3dd83ac
diff --git a/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs b/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs
index 91d91b849..a614fdac3 100644
--- a/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs
+++ b/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs
@@ -897,7 +897,7 @@ struct SvgSvgElementTemplateMethodsDeclaration {
}
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::SVGLength, enumerable)]
+#[webapi(interface = web_api_interfaces::SVGLength, enumerable, receiver)]
struct SvgLengthTemplateAccessorsDeclaration {
#[webapi(
accessor_property = "unitType",
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index 91c9f0a26..df3396105 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2185,6 +2185,8 @@ mod css_keyframes_receivers;
mod device_events;
mod document_svg_root;
+mod svg_length_native_receivers;
+
mod gamepad_interfaces;
mod dom_elements;
diff --git a/moli-renderer-v8/src/script_vm/tests/svg_length_native_receivers.rs b/moli-renderer-v8/src/script_vm/tests/svg_length_native_receivers.rs
new file mode 100644
index 000000000..1ad40f984
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/svg_length_native_receivers.rs
@@ -0,0 +1,57 @@
+use super::*;
+
+#[test]
+fn svg_length_native_receivers_reject_forgery_before_conversion_in_the_callee_realm() {
+ let mut vm = new_storage_html_test_vm("https://svg-length-native-receivers.test/");
+ let result = vm.eval(r#"
+ document.body.innerHTML = '<iframe></iframe>';
+ const other = document.querySelector('iframe').contentWindow;
+ const ns = 'http://www.w3.org/2000/svg';
+ const svg = document.createElementNS(ns, 'svg'); document.body.append(svg);
+ const createSvg = name => {const node=document.createElementNS(ns,name); svg.append(node); return node;};
+ const length = svg.createSVGLength();
+ let conversions = 0;
+ let traps = 0;
+ const poison = {
+ [Symbol.toPrimitive]() { conversions++; return '3'; },
+ get subtree() { conversions++; throw new Error('unexpected options conversion'); }
+ };
+ const cases = [
+ ["SVGLength", "unitType", "get", length, [], [poison]],
+ ["SVGLength", "value", "get", length, [], [poison]],
+ ["SVGLength", "valueInSpecifiedUnits", "get", length, [], [poison]],
+ ["SVGLength", "valueAsString", "get", length, [], [poison]],
+ ["SVGLength", "value", "set", length, [7], [poison]],
+ ["SVGLength", "valueAsString", "set", length, ['7px'], [poison]],
+ ];
+ for (const realm of [window, other]) {
+ for (const [interfaceName, name, kind, value, validArgs, invalidArgs] of cases) {
+ const prototype = realm[interfaceName].prototype;
+ const descriptor = Object.getOwnPropertyDescriptor(prototype, name);
+ const operation = kind === 'method' ? prototype[name] : descriptor && descriptor[kind];
+ if (typeof operation !== 'function')
+ throw new Error(interfaceName + '.' + name + ': missing prototype member');
+ const result = Reflect.apply(operation, value, validArgs);
+ if (kind === 'get' && result === undefined)
+ throw new Error(interfaceName + '.' + name + ': genuine receiver lost native state');
+ const author = new Proxy(value, {
+ get() { traps++; throw new Error('unexpected receiver get'); },
+ getPrototypeOf() { traps++; throw new Error('unexpected receiver prototype'); }
+ });
+ const revoked = Proxy.revocable(value, {}); revoked.revoke();
+ for (const receiver of [null, undefined, {}, Object.create(value),
+ Object.create(prototype), author, revoked.proxy]) {
+ let error;
+ try { Reflect.apply(operation, receiver, invalidArgs); }
+ catch (caught) { error = caught; }
+ if (!error || Object.getPrototypeOf(error) !== realm.TypeError.prototype)
+ throw new Error(interfaceName + '.' + name + ': expected callee TypeError');
+ }
+ }
+ }
+ if (conversions !== 0 || traps !== 0)
+ throw new Error('receiver validation ran author code before rejection');
+ 'ok';
+ "#).unwrap();
+ assert_eq!(result, "ok");
+}