Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(renderer): capture console stacks without page hooks
ldm071974b7a3369
diff --git a/moli-renderer-v8/src/context_bootstrap/shared/console.rs b/moli-renderer-v8/src/context_bootstrap/shared/console.rsindex dd27e8450..dbdfbcf02 100644--- a/moli-renderer-v8/src/context_bootstrap/shared/console.rs+++ b/moli-renderer-v8/src/context_bootstrap/shared/console.rs@@ -83,15 +83,29 @@ pub(in crate::context_bootstrap) fn append_console_message<'s>(}pub(crate) fn current_console_stack(scope: &mut v8::PinScope<'_, '_>) -> Option<String> {- let message = v8_string(scope, "Console").unwrap_or_else(|| v8::String::empty(scope));- let error = v8::Exception::error(scope, message);- let object = v8::Local::<v8::Object>::try_from(error).ok()?;- let stack_key = v8_string(scope, "stack")?;- let stack = object.get(scope, stack_key.into())?;- stack- .to_string(scope)- .map(|value| value.to_rust_string_lossy(scope))- .filter(|stack| !stack.is_empty())+ let stack = v8::StackTrace::current_stack_trace(scope, 32)?;+ let mut frames = Vec::with_capacity(stack.get_frame_count());+ for index in 0..stack.get_frame_count() {+ let Some(frame) = stack.get_frame(scope, index) else {+ continue;+ };+ let function_name = frame+ .get_function_name(scope)+ .map(|name| name.to_rust_string_lossy(scope))+ .unwrap_or_default();+ let url = frame+ .get_script_name_or_source_url(scope)+ .map(|name| name.to_rust_string_lossy(scope))+ .filter(|url| !url.is_empty())+ .unwrap_or_else(|| "<anonymous>".to_owned());+ let location = format!("{url}:{}:{}", frame.get_line_number(), frame.get_column());+ if function_name.is_empty() {+ frames.push(format!("at {location}"));+ } else {+ frames.push(format!("at {function_name} ({location})"));+ }+ }+ (!frames.is_empty()).then(|| frames.join("\n"))}pub(crate) fn console_arg_remote_object_json(diff --git a/moli-renderer-v8/src/script_vm/tests/browser_api/misc.rs b/moli-renderer-v8/src/script_vm/tests/browser_api/misc.rsindex 10e883122..e2bb52d78 100644--- a/moli-renderer-v8/src/script_vm/tests/browser_api/misc.rs+++ b/moli-renderer-v8/src/script_vm/tests/browser_api/misc.rs@@ -7292,6 +7292,37 @@ fn console_debug_is_present_and_does_not_double_read_error_stack() {r#"{"beforeAccess":"","afterAccess":"","afterSpoof":"__moliWindowConsole","publicSpoof":true,"sameConsole":true,"debugType":"function","reads":1}"#);}++#[test]+fn console_does_not_invoke_error_prepare_stack_trace() {+ let mut vm = new_storage_test_vm("https://example.com/");++ let result = vm+ .eval(+ r#"+ (() => {+ let accessed = false;+ const originalPrepareStackTrace = Error.prepareStackTrace;+ try {+ Error.prepareStackTrace = () => {+ accessed = true;+ return "detected";+ };+ console.log(new Error(""));+ const afterConsole = accessed;+ void new Error("explicit stack access").stack;+ return `${afterConsole}|${accessed}`;+ } finally {+ Error.prepareStackTrace = originalPrepareStackTrace;+ }+ })()+ "#,+ )+ .expect("console Error.prepareStackTrace probe should evaluate");++ assert_eq!(result, "false|true");+}+#[test]fn zhihu_probe_navigator_profile_is_chromium_like() {let mut vm = new_storage_test_vm("https://example.com/");diff --git a/moli-renderer-v8/src/worker/thread/tests/lifecycle.rs b/moli-renderer-v8/src/worker/thread/tests/lifecycle.rsindex f70ea2a41..4c5a0f02e 100644--- a/moli-renderer-v8/src/worker/thread/tests/lifecycle.rs+++ b/moli-renderer-v8/src/worker/thread/tests/lifecycle.rs@@ -9776,6 +9776,46 @@ async fn worker_console_does_not_crash() {);}+#[tokio::test]+async fn worker_console_does_not_invoke_error_prepare_stack_trace() {+ ensure_v8();+ let mut handle = spawn_worker(+ r#"+ let accessed = false;+ const originalPrepareStackTrace = Error.prepareStackTrace;+ try {+ Error.prepareStackTrace = () => {+ accessed = true;+ return "detected";+ };+ console.log(new Error(""));+ const afterConsole = accessed;+ void new Error("explicit stack access").stack;+ postMessage(`${afterConsole}|${accessed}`);+ } finally {+ Error.prepareStackTrace = originalPrepareStackTrace;+ }+ "#+ .into(),+ "test://console_prepare_stack_trace".into(),+ );++ loop {+ let message = timeout(TIMEOUT, handle.recv())+ .await+ .expect("timed out")+ .expect("channel closed");+ match message {+ WorkerToParentMessage::Console(_) => {}+ WorkerToParentMessage::Post(payload) => {+ assert_eq!(stringify_payload(&payload), r#""false|true""#);+ break;+ }+ other => panic!("unexpected worker console probe message: {other:?}"),+ }+ }+}+// ─── Self reference ─────────────────────────────────────────────────#[tokio::test]