Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(forms): validate setRangeText offsets before clamping

ldm072bc7cbef7c0
diff --git a/moli-renderer-v8/src/native_bridge/element/forms/text_control/selection.rs b/moli-renderer-v8/src/native_bridge/element/forms/text_control/selection.rs
index a4b56ea72..62a444434 100644
--- a/moli-renderer-v8/src/native_bridge/element/forms/text_control/selection.rs
+++ b/moli-renderer-v8/src/native_bridge/element/forms/text_control/selection.rs
@@ -529,8 +529,9 @@ pub(in crate::native_bridge) fn text_control_set_range_text_callback<'s>(
let value_units = utf16_units(&value);
let value_len = value_units.len() as u32;
let (current_start, current_end) = current_selection_or_end(runtime, handle, value_len);
- let start = parsed.start.unwrap_or(current_start).min(value_len);
- let end = parsed.end.unwrap_or(current_end).min(value_len);
+ let start = parsed.start.unwrap_or(current_start);
+ let end = parsed.end.unwrap_or(current_end);
+ // Validate before clamping so reversed out-of-bounds ranges still throw.
if end < start {
throw_dom_exception(
scope,
@@ -540,6 +541,8 @@ pub(in crate::native_bridge) fn text_control_set_range_text_callback<'s>(
);
return;
}
+ let start = start.min(value_len);
+ let end = end.min(value_len);
let replacement_units = utf16_units(&parsed.replacement);
let replacement_len = replacement_units.len() as u32;
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_elements/dom_surface.rs b/moli-renderer-v8/src/script_vm/tests/dom_elements/dom_surface.rs
index 3ca93e4dc..fbfa2a4e2 100644
--- a/moli-renderer-v8/src/script_vm/tests/dom_elements/dom_surface.rs
+++ b/moli-renderer-v8/src/script_vm/tests/dom_elements/dom_surface.rs
@@ -3475,6 +3475,70 @@ fn writing_suggestions_reflects_and_inherits_nearest_ancestor_state() {
);
}
+#[test]
+fn set_range_text_validates_range_before_clamping_offsets() {
+ let mut vm = new_storage_test_vm("https://forms-selection-set-range-text-order.test/");
+
+ let result = vm
+ .eval(
+ r#"
+ (() => {
+ const failures = [];
+ const cases = [
+ ['abc', 100, 99, 'IndexSizeError', 'abc'],
+ ['abc', 4, 3, 'IndexSizeError', 'abc'],
+ ['abc', 3, 2, 'IndexSizeError', 'abc'],
+ ['', 1, 0, 'IndexSizeError', ''],
+ ['abc', -1, -2, 'IndexSizeError', 'abc'],
+ ['abc', 99, 100, null, 'abcY'],
+ ['abc', 100, 100, null, 'abcY'],
+ ['abc', 1, 100, null, 'aY'],
+ ['abc', 2 ** 32, 1, null, 'Ybc'],
+ ['', 0, 0, null, 'Y']
+ ];
+ for (const type of ['text', 'search', 'tel', 'url', 'password', 'textarea']) {
+ for (const connected of [false, true]) {
+ const field = document.createElement(type === 'textarea' ? 'textarea' : 'input');
+ if (type !== 'textarea') field.type = type;
+ if (connected) {
+ (document.body || document.documentElement || document).appendChild(field);
+ }
+ for (const [value, start, end, expectedError, expectedValue] of cases) {
+ field.value = value;
+ field.setSelectionRange(1, 2, 'backward');
+ const selection = () => JSON.stringify([
+ field.selectionStart, field.selectionEnd, field.selectionDirection
+ ]);
+ const beforeSelection = selection();
+ let errorName = null;
+ let isIndexSizeError = false;
+ try {
+ field.setRangeText('Y', start, end);
+ } catch (error) {
+ errorName = error.name;
+ isIndexSizeError = error instanceof DOMException && error.code === 1;
+ }
+ if (errorName !== expectedError || field.value !== expectedValue ||
+ (expectedError && (!isIndexSizeError || selection() !== beforeSelection))) {
+ failures.push({
+ type, connected, value, start, end, expectedError, expectedValue,
+ errorName, actualValue: field.value, isIndexSizeError,
+ beforeSelection, afterSelection: selection()
+ });
+ }
+ }
+ field.remove();
+ }
+ }
+ return JSON.stringify(failures);
+ })()
+ "#,
+ )
+ .expect("setRangeText range validation and clamping should evaluate");
+
+ assert_eq!(result, "[]");
+}
+
#[test]
fn set_range_text_preserve_mode_adjusts_selection_by_replacement_delta() {
let mut vm = new_storage_test_vm("https://forms-selection-set-range-text.test/");