Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

feat(locks): expose secure Lock and LockManager interfaces

ldm0744e050af807
diff --git a/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs b/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs
index 5d6fb4c45..0f7affb2c 100644
--- a/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs
+++ b/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs
@@ -54,6 +54,8 @@ pub(in crate::context_bootstrap) const WORKER_SHARED_INTERFACE_NAMES: &[&str] =
"CryptoKey",
"MediaCapabilities",
"NavigatorUAData",
+ "Lock",
+ "LockManager",
"WorkerNavigator",
"MessageChannel",
"MessagePort",
@@ -135,6 +137,8 @@ const SECURE_CONTEXT_ONLY_INTERFACE_NAMES: &[&str] = &[
"SubtleCrypto",
"CryptoKey",
"PaymentResponse",
+ "Lock",
+ "LockManager",
"IdleDetector",
"Worklet",
"AudioWorklet",
diff --git a/moli-renderer-v8/src/context_bootstrap/specs/registry.rs b/moli-renderer-v8/src/context_bootstrap/specs/registry.rs
index 21882caf3..9ff6b580b 100644
--- a/moli-renderer-v8/src/context_bootstrap/specs/registry.rs
+++ b/moli-renderer-v8/src/context_bootstrap/specs/registry.rs
@@ -636,6 +636,14 @@ const CONSTRUCTOR_SPECS_BEFORE_STREAMS: &[ConstructorSpec] = &[
interface: web_api_interfaces::NavigatorUAData::DESCRIPTOR,
kind: ConstructorKind::NavigatorUAData,
},
+ ConstructorSpec {
+ interface: web_api_interfaces::LockManager::DESCRIPTOR,
+ kind: ConstructorKind::Illegal,
+ },
+ ConstructorSpec {
+ interface: web_api_interfaces::Lock::DESCRIPTOR,
+ kind: ConstructorKind::Illegal,
+ },
ConstructorSpec {
interface: web_api_interfaces::StorageManager::DESCRIPTOR,
kind: ConstructorKind::StorageManager,
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index 9509e9461..f2aa3636d 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2201,6 +2201,7 @@ mod text_encoder_utf16_progress;
mod time_ranges;
mod url_components;
mod video_codecs_shell;
+mod web_lock_interface_exposure_interfaces;
mod webgl_interfaces;
mod webidl_collections;
mod webidl_fetch;
diff --git a/moli-renderer-v8/src/script_vm/tests/web_lock_interface_exposure_interfaces.rs b/moli-renderer-v8/src/script_vm/tests/web_lock_interface_exposure_interfaces.rs
new file mode 100644
index 000000000..11b114738
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/web_lock_interface_exposure_interfaces.rs
@@ -0,0 +1,83 @@
+use super::*;
+
+#[test]
+fn web_lock_interface_exposure_interfaces_have_realm_local_constructors_and_exposure() {
+ for url in [
+ "https://interface-exposure.test/",
+ "http://interface-exposure.test/",
+ ] {
+ let mut vm = new_storage_test_vm(url);
+ assert_eq!(vm.eval(r#"
+(() => {
+ const assert = (ok, message) => { if (!ok) throw Error(message); };
+ const names = ["Lock", "LockManager"];
+ const parents = {"Lock": null, "LockManager": null};
+ if (!document.documentElement) document.appendChild(document.createElement('html'));
+ if (!document.body) document.documentElement.appendChild(document.createElement('body'));
+ const child = document.createElement('iframe');
+ document.body.appendChild(child);
+ const other = child.contentWindow;
+ for (const realm of [window, other]) {
+ for (const name of names) {
+ if (!isSecureContext) {
+ assert(!(name in realm), name + ' unavailable outside secure contexts');
+ continue;
+ }
+ const C = realm[name];
+ assert(typeof C === 'function' && C.name === name && C.length === 0, name + ' constructor');
+ assert(C.prototype.constructor === C, name + ' prototype identity');
+ assert(Object.getPrototypeOf(C.prototype) === (parents[name] ? realm[parents[name]].prototype : realm.Object.prototype), name + ' prototype inheritance');
+ assert(realm[name] === C, name + ' stable lazy materialization');
+ for (const invoke of [() => C(), () => new C(), () => Reflect.construct(C, [], function Subclass() {})]) {
+ let error;
+ try { invoke(); } catch (caught) { error = caught; }
+ assert(error instanceof realm.TypeError, name + ' rejects construction in callee realm');
+ }
+ assert(C !== (realm === window ? other[name] : window[name]), name + ' distinct realm constructors');
+ }
+ }
+ return 'passed';
+})()
+"#).unwrap(), "passed", "{url}");
+ }
+}
+
+#[test]
+fn web_lock_interface_exposure_interfaces_worker_exposure_follows_realm_and_security_rules() {
+ use crate::context_bootstrap::exposed_interfaces::RealmKind;
+ use std::pin::pin;
+ crate::ensure_v8_for_test();
+ for realm in [
+ RealmKind::DedicatedWorker,
+ RealmKind::SharedWorker,
+ RealmKind::ServiceWorker,
+ ] {
+ let mut isolate = v8::Isolate::new(Default::default());
+ let scope = pin!(v8::HandleScope::new(&mut isolate));
+ let scope = &mut scope.init();
+ for secure in [false, true] {
+ let context = v8::Context::new(scope, Default::default());
+ let scope = &mut v8::ContextScope::new(scope, context);
+ let global = context.global(scope);
+ crate::context_bootstrap::install_worker_lazy_exposed_interfaces(
+ scope, global, realm, secure,
+ )
+ .expect("worker interfaces");
+ for name in ["Lock", "LockManager"] {
+ let expected = secure;
+ let key = crate::util::v8str(scope, name);
+ assert_eq!(
+ global.has_own_property(scope, key.into()),
+ Some(expected),
+ "{realm:?}/{secure}/{name}"
+ );
+ if expected {
+ assert!(
+ global.get(scope, key.into()).unwrap().is_function(),
+ "{name} materialization"
+ );
+ }
+ }
+ }
+ }
+}
diff --git a/moli-renderer-v8/src/web_api_interfaces.rs b/moli-renderer-v8/src/web_api_interfaces.rs
index c61c50268..f880052c6 100644
--- a/moli-renderer-v8/src/web_api_interfaces.rs
+++ b/moli-renderer-v8/src/web_api_interfaces.rs
@@ -300,6 +300,8 @@ interfaces! {
IntersectionObserverEntry;
KeyboardEvent: UIEvent;
KeyframeEffect: AnimationEffect;
+ Lock;
+ LockManager;
Location;
MathMLElement: Element;
MediaCapabilities;