Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(webidl): derive dom token list receiver checks

ldm0754508b66617
diff --git a/moli-renderer-v8/src/native_bridge/element/class_list/template.rs b/moli-renderer-v8/src/native_bridge/element/class_list/template.rs
index 1443b54cd..9b232c337 100644
--- a/moli-renderer-v8/src/native_bridge/element/class_list/template.rs
+++ b/moli-renderer-v8/src/native_bridge/element/class_list/template.rs
@@ -3,7 +3,7 @@ use crate::web_api_interfaces;
use moli_webapi_declare::WebApiFunctionTemplate;
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::DOMTokenList, enumerable)]
+#[webapi(interface = web_api_interfaces::DOMTokenList, enumerable, receiver)]
struct DomTokenListTemplateMethodsDeclaration {
#[webapi(
intrinsic_data_property = v8::Intrinsic::ArrayProtoEntries,
@@ -65,7 +65,7 @@ struct DomTokenListTemplateMethodsDeclaration {
}
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::DOMTokenList)]
+#[webapi(interface = web_api_interfaces::DOMTokenList, receiver)]
struct DomTokenListAttributeDescriptorsDeclaration {
#[webapi(
accessor_property,
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_token_list_native_receivers.rs b/moli-renderer-v8/src/script_vm/tests/dom_token_list_native_receivers.rs
new file mode 100644
index 000000000..5fc28d191
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/dom_token_list_native_receivers.rs
@@ -0,0 +1,55 @@
+use super::*;
+
+#[test]
+fn dom_token_list_native_receivers_reject_forgery_before_conversion_in_the_callee_realm() {
+ let mut vm = new_storage_html_test_vm("https://dom-token-list-native-receivers.test/");
+ let result = vm.eval(r#"
+ document.body.innerHTML = '<iframe></iframe>';
+ const other = document.querySelector('iframe').contentWindow;
+ const element = document.createElement('div'); const tokens = element.classList;
+ let conversions = 0;
+ let traps = 0;
+ const poison = {
+ [Symbol.toPrimitive]() { conversions++; return '3'; },
+ get subtree() { conversions++; throw new Error('unexpected options conversion'); }
+ };
+ const cases = [
+ ["DOMTokenList", "length", "get", tokens, [], [poison]],
+ ["DOMTokenList", "value", "get", tokens, [], [poison]],
+ ["DOMTokenList", "value", "set", tokens, ['alpha beta'], [poison]],
+ ["DOMTokenList", "contains", "method", tokens, ['alpha'], [poison]],
+ ["DOMTokenList", "add", "method", tokens, ['gamma'], [poison]],
+ ["DOMTokenList", "remove", "method", tokens, ['gamma'], [poison]],
+ ["DOMTokenList", "toggle", "method", tokens, ['delta', false], [poison]],
+ ];
+ for (const realm of [window, other]) {
+ for (const [interfaceName, name, kind, value, validArgs, invalidArgs] of cases) {
+ const prototype = realm[interfaceName].prototype;
+ const descriptor = Object.getOwnPropertyDescriptor(prototype, name);
+ const operation = kind === 'method' ? prototype[name] : descriptor && descriptor[kind];
+ if (typeof operation !== 'function')
+ throw new Error(interfaceName + '.' + name + ': missing prototype member');
+ const result = Reflect.apply(operation, value, validArgs);
+ if (kind === 'get' && result === undefined)
+ throw new Error(interfaceName + '.' + name + ': genuine receiver lost native state');
+ const author = new Proxy(value, {
+ get() { traps++; throw new Error('unexpected receiver get'); },
+ getPrototypeOf() { traps++; throw new Error('unexpected receiver prototype'); }
+ });
+ const revoked = Proxy.revocable(value, {}); revoked.revoke();
+ for (const receiver of [null, undefined, {}, Object.create(value),
+ Object.create(prototype), author, revoked.proxy]) {
+ let error;
+ try { Reflect.apply(operation, receiver, invalidArgs); }
+ catch (caught) { error = caught; }
+ if (!error || Object.getPrototypeOf(error) !== realm.TypeError.prototype)
+ throw new Error(interfaceName + '.' + name + ': expected callee TypeError');
+ }
+ }
+ }
+ if (conversions !== 0 || traps !== 0)
+ throw new Error('receiver validation ran author code before rejection');
+ 'ok';
+ "#).unwrap();
+ assert_eq!(result, "ok");
+}
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index 1bbaf3db1..123c0b20a 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2161,6 +2161,9 @@ mod bitmap_rendering_context_interface_interfaces;
mod blob_response_headers;
mod browser_api;
mod cache_interfaces;
+
+mod dom_token_list_native_receivers;
+
mod canvas_arguments;
mod canvas_fill_rect;
mod canvas_paths;