Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(cssom): remove all from detached and rule declarations
ldm07993cd48a119
diff --git a/moli-renderer-v8/src/detached_css_style.rs b/moli-renderer-v8/src/detached_css_style.rsindex 543458b22..fd529dfa1 100644--- a/moli-renderer-v8/src/detached_css_style.rs+++ b/moli-renderer-v8/src/detached_css_style.rs@@ -2423,7 +2423,8 @@ fn normalize_style_entry_value<'s>(if keyframe_style_property_write_is_ignored(scope, style, name) {return None;}- if name == "all" {+ // Empty text removes the declaration; it is not a keyword to parse.+ if name == "all" && !value.is_empty() {return css_wide_keyword(value);}if !name.starts_with("--") && moli_css_parse::css_value_may_contain_env_function(value) {diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/css_all_removal.js b/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/css_all_removal.jsnew file mode 100644index 000000000..f15f34dd8--- /dev/null+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/css_all_removal.js@@ -0,0 +1,45 @@+(() => {+ 'use strict';+ const equal = (actual, expected, label) => {+ if (!Object.is(actual, expected)) throw new Error(label);+ };+ const other = document.getElementById('child').contentWindow;+ const elements = [+ document.createElement('div'),+ document.createElementNS('http://www.w3.org/2000/svg', 'g'),+ document.createElementNS('http://www.w3.org/1998/Math/MathML', 'mi'),+ document.implementation.createHTMLDocument('').createElement('select'),+ other.document.createElement('div'),+ ];+ const sheets = [new CSSStyleSheet(), new other.CSSStyleSheet()];+ for (const sheet of sheets) sheet.replaceSync('div {}');+ const keyframes = new CSSStyleSheet();+ keyframes.replaceSync('@keyframes test { from {} }');+ const styles = [+ ...elements.map(element => element.style),+ ...sheets.map(sheet => sheet.cssRules[0].style),+ keyframes.cssRules[0].cssRules[0].style,+ ];+ for (const [index, style] of styles.entries()) {+ for (const value of ['initial', 'inherit', 'unset', 'revert', 'revert-layer']) {+ style.cssText = '';+ style.setProperty('all', value, index === 7 ? '' : 'important');+ equal(style.getPropertyValue('all'), value, `${index}: initial declaration`);+ equal(style.removeProperty('all'), value, `${index}: removed value`);+ equal(style.getPropertyValue('all'), '', `${index}: removed declaration`);+ equal(style.getPropertyPriority('all'), '', `${index}: removed priority`);+ equal(style.length, 0, `${index}: no property names`);+ equal(style.cssText, '', `${index}: no serialization`);+ equal(style.removeProperty('all'), '', `${index}: repeated removal`);+ }+ style.cssText = 'all: inherit; margin-left: 1px; direction: rtl; unicode-bidi: isolate; --token: kept';+ equal(style.removeProperty('all'), '', `${index}: overridden shorthand`);+ equal(style.getPropertyValue('all'), '', `${index}: shorthand gone`);+ equal(style.getPropertyValue('margin-left'), '', `${index}: longhand gone`);+ equal(style.getPropertyValue('direction'), 'rtl', `${index}: direction preserved`);+ equal(style.getPropertyValue('unicode-bidi'), 'isolate', `${index}: bidi preserved`);+ equal(style.getPropertyValue('--token'), 'kept', `${index}: custom property preserved`);+ equal(style.length, 3, `${index}: only exempt properties remain`);+ }+ return true;+})()diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/declarations.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/declarations.rsindex 5b5ecdc66..c63cf4419 100644--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/declarations.rs+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/cssom/extracted/declarations.rs@@ -1437,6 +1437,16 @@ fn live_inline_css_text_reset_preserves_all_adapter_with_pdb_storage() {"2|all,padding-left|inherit|1px|all: inherit; padding-left: 1px;|all: inherit; padding-left: 1px;/|inline|1px|all,padding-left,display|all: inherit; padding-left: 1px; display: inline;|all: inherit; padding-left: 1px; display: inline;/|||0||");}++#[test]+fn removing_all_clears_detached_and_rule_declarations() {+ let mut vm = new_parsed_test_vm(+ "https://css-all-removal.test/",+ "<!doctype html><body><iframe id=child></iframe>",+ );+ assert_eq!(vm.eval(include_str!("css_all_removal.js")).unwrap(), "true");+}+#[test]fn live_inline_all_mutations_update_pdb_storage_without_losing_cssom_order() {let mut vm = new_storage_test_vm("https://inline-style-pdb-all.test/");