Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(xhr): preserve response document modification times
ldm089146786984e
diff --git a/moli-renderer-v8/src/network_host/xhr/delivery/response.rs b/moli-renderer-v8/src/network_host/xhr/delivery/response.rsindex f5f1095db..6a214d9b1 100644--- a/moli-renderer-v8/src/network_host/xhr/delivery/response.rs+++ b/moli-renderer-v8/src/network_host/xhr/delivery/response.rs@@ -223,8 +223,12 @@ fn apply_xhr_response_body(XmlHttpRequestResponseType::Document => {let mime = xhr_response_mime_essence(scope, xhr, &head.headers).unwrap_or_else(|| "text/html".to_owned());- let document =- parse_xhr_response_document(scope, body_text.as_deref().unwrap_or(""), Some(&mime));+ let document = parse_xhr_response_document(+ scope,+ body_text.as_deref().unwrap_or(""),+ Some(&mime),+ &head.headers,+ );set_xhr_state_value(scope, xhr, XHR_RESPONSE_XML_SLOT, document);document}@@ -283,7 +287,8 @@ fn apply_xhr_response_text(XmlHttpRequestResponseType::Document => {let mime = xhr_response_mime_essence(scope, xhr, &head.headers).unwrap_or_else(|| "text/html".to_owned());- let document = parse_xhr_response_document(scope, &body_text, Some(&mime));+ let document =+ parse_xhr_response_document(scope, &body_text, Some(&mime), &head.headers);set_xhr_state_value(scope, xhr, XHR_RESPONSE_XML_SLOT, document);document}@@ -589,22 +594,38 @@ fn parse_default_xhr_response_xml<'s>(body_text: &str,) -> v8::Local<'s, v8::Value> {let mime = xhr_response_mime_essence(scope, xhr, headers);- parse_xhr_response_document(scope, body_text, mime.as_deref())+ parse_xhr_response_document(scope, body_text, mime.as_deref(), headers)}fn parse_xhr_response_document<'s>(scope: &mut v8::PinScope<'s, '_>,body_text: &str,mime: Option<&str>,+ headers: &[(String, String)],) -> v8::Local<'s, v8::Value> {let Some(mime) =mime.filter(|mime| is_html_document_mime(mime) || is_dom_parser_xml_mime(mime))else {return v8::null(scope).into();};- dom_parser::parse_detached_document_from_string(scope, body_text, mime)- .map(|value| value.into())- .unwrap_or_else(|| v8::null(scope).into())+ let Some(document) = dom_parser::parse_detached_document_from_string(scope, body_text, mime)+ else {+ return v8::null(scope).into();+ };+ let Ok((runtime_ptr, document_handle)) =+ crate::native_bridge::node_runtime_and_handle_from_object_or_detached(scope, document)+ else {+ return v8::null(scope).into();+ };+ // Response metadata belongs to this Document, independently of the+ // requesting Document and any later reuse of the XHR object.+ unsafe { &mut *runtime_ptr }+ .dom_host_mut()+ .set_document_source_last_modified_for_handle(+ document_handle,+ crate::document_last_modified::document_last_modified_from_headers(headers),+ );+ document.into()}fn xhr_response_blob_mime_type(diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/xhr.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/xhr.rsindex 249c29353..3e5893a6b 100644--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/xhr.rs+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/xhr.rs@@ -3434,3 +3434,164 @@ async fn window_xhr_open_freezes_base_url_and_applies_url_credentials() {Some("Basic YWxpY2U6c2VjcmV0"));}++#[test]+fn xhr_response_documents_keep_distinct_source_modification_times() {+ let environment = moli_v8_platform::ProcessEnvironmentOwner::default();+ for streaming in [false, true] {+ for (mime, response_type) in [+ ("application/xml", ""),+ ("application/xml", "document"),+ ("text/html", "document"),+ ] {+ let mut vm = new_storage_test_vm("https://xhr-document-modified.test/");+ vm.document_runtime+ .set_document_source_last_modified(Some(5_025_000.0));+ environment.set_timezone(Some("UTC")).unwrap();+ vm.set_fetch_subresource_interception(+ true,+ Some(crate::types::SubresourceResourceType::Xhr),+ );+ vm.eval(+ r#"+ globalThis.__modifiedXhr = new XMLHttpRequest();+ globalThis.__responseDocuments = [];+ __modifiedXhr.onload = () => __responseDocuments.push(__modifiedXhr.responseXML);+ "#,+ )+ .unwrap();+ for (header, expected) in [+ (+ Some("Sun, 06 Nov 1994 08:49:37 GMT"),+ Some("11/06/1994 08:49:37"),+ ),+ (+ Some("Thu, 01 Jan 1970 00:00:00 GMT"),+ Some("01/01/1970 00:00:00"),+ ),+ (Some("not a date"), None),+ (None, None),+ ] {+ vm.eval(&format!(+ r#"+ __modifiedXhr.open('GET', '/response');+ __modifiedXhr.responseType = '{response_type}';+ __modifiedXhr.send();+ "#+ ))+ .unwrap();+ let pending = vm.take_pending_subresource_fetch_infos();+ assert_eq!(pending.len(), 1);+ let request = &pending[0];+ let mut headers = vec![("Content-Type".to_owned(), mime.to_owned())];+ if let Some(header) = header {+ headers.push(("lAsT-mOdIfIeD".to_owned(), header.to_owned()));+ }+ let head = moli_fetch::ResponseHead {+ final_url: request.url.clone(),+ status: 200,+ headers,+ request_cookie_report: None,+ cookie_set_reports: Vec::new(),+ redirected: false,+ redirect_chain: Vec::new(),+ from_cache: false,+ negotiated_http_version: None,+ };+ if streaming {+ let body_source_id = crate::network_host::new_network_body_source_id();+ vm.start_streaming_async_subresource_fetch(+ crate::types::AsyncSubresourceStreamingStarted {+ internal_id: request.internal_id,+ request_url: request.url.clone(),+ request_method: "GET".to_owned(),+ request_headers: Default::default(),+ request_body: None,+ skip_fetch_security_validation: false,+ response_filter: None,+ body_source_id,+ head,+ network_request_headers: None,+ },+ )+ .unwrap();+ for chunk in [+ b"<html><body>".as_slice(),+ b"response</body></html>".as_slice(),+ ] {+ vm.append_streaming_async_subresource_fetch_chunk(+ body_source_id,+ chunk.to_vec(),+ );+ assert_eq!(+ vm.eval("__modifiedXhr.responseXML === null").unwrap(),+ "true"+ );+ }+ vm.finish_streaming_async_subresource_fetch(+ request.internal_id,+ body_source_id,+ Ok(()),+ )+ .unwrap();+ } else {+ vm.complete_async_subresource_fetch(+ crate::types::AsyncSubresourceFetchCompletion {+ internal_id: request.internal_id,+ request_url: request.url.clone(),+ request_method: "GET".to_owned(),+ request_headers: Default::default(),+ request_body: None,+ skip_fetch_security_validation: false,+ response_filter: None,+ response_status_text: None,+ network_error_text: None,+ result: Ok(+ crate::protocol_types::NavigationResponse::from_head_and_body(+ head,+ "<html><body>response</body></html>".to_owned(),+ b"<html><body>response</body></html>".to_vec(),+ ),+ )+ .into(),+ },+ )+ .unwrap();+ }+ if let Some(expected) = expected {+ assert_eq!(+ vm.eval("__modifiedXhr.responseXML.lastModified").unwrap(),+ expected+ );+ } else {+ assert_eq!(vm.eval(r#"(() => {+ const doc = __modifiedXhr.responseXML;+ const match = /^(\d\d)\/(\d\d)\/(\d{4}) (\d\d):(\d\d):(\d\d)$/.exec(doc.lastModified);+ const time = Date.UTC(+match[3], +match[1] - 1, +match[2], +match[4], +match[5], +match[6]);+ return Math.abs(Date.now() - time) < 5000;+ })()"#).unwrap(), "true", "mime={mime}, response_type={response_type}, header={header:?}");+ }+ }+ assert_eq!(+ vm.eval(+ r#"(() => {+ const [first, second, third, fourth] = __responseDocuments;+ __modifiedXhr.abort();+ first.documentElement.remove();+ return JSON.stringify([+ first.lastModified, second.lastModified,+ document.lastModified, first !== second && third !== fourth+ ]);+ })()"#+ )+ .unwrap(),+ r#"["11/06/1994 08:49:37","01/01/1970 00:00:00","01/01/1970 01:23:45",true]"#+ );+ environment.set_timezone(Some("Asia/Shanghai")).unwrap();+ assert_eq!(+ vm.eval("__responseDocuments[0].lastModified").unwrap(),+ "11/06/1994 16:49:37"+ );+ }+ }+}