Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(streams): mark internal rejections handled without author catch hooks
ldm08b08758bd1b2
diff --git a/moli-renderer-v8/src/context_bootstrap/stream_adapter/utils.rs b/moli-renderer-v8/src/context_bootstrap/stream_adapter/utils.rsindex 08b77b731..9d10c3feb 100644--- a/moli-renderer-v8/src/context_bootstrap/stream_adapter/utils.rs+++ b/moli-renderer-v8/src/context_bootstrap/stream_adapter/utils.rs@@ -269,22 +269,16 @@ pub(in crate::context_bootstrap) fn suppress_pending_read_unhandled_rejection<'s}pub(in crate::context_bootstrap) fn suppress_promise_unhandled_rejection<'s>(- scope: &mut v8::PinScope<'s, '_>,+ _: &mut v8::PinScope<'s, '_>,promise: v8::Local<'s, v8::Value>,) {let Ok(promise) = v8::Local::<v8::Promise>::try_from(promise) else {return;};- let Some(noop) = v8::Function::builder(promise_return_undefined_callback).build(scope) else {- return;- };- let Some(catch) = promise- .get(scope, v8str(scope, "catch").into())- .and_then(|value| v8::Local::<v8::Function>::try_from(value).ok())- else {- return;- };- let _ = catch.call(scope, promise.into(), &[noop.into()]);+ // Streams algorithms mark their internal promises handled directly. An+ // author can replace catch, its getter, or the Promise species constructor.+ // Looking them up here would add observable script to the native algorithm.+ promise.mark_as_handled();}pub(in crate::context_bootstrap) fn value_buffer_source_bytes(diff --git a/moli-renderer-v8/src/script_vm/tests/streams/intrinsic_promises.rs b/moli-renderer-v8/src/script_vm/tests/streams/intrinsic_promises.rsindex 6f1fd7307..d475c8cbf 100644--- a/moli-renderer-v8/src/script_vm/tests/streams/intrinsic_promises.rs+++ b/moli-renderer-v8/src/script_vm/tests/streams/intrinsic_promises.rs@@ -1,5 +1,39 @@use super::*;+#[test]+fn stream_internal_rejection_handling_does_not_read_author_promise_catch() {+ let mut vm = stream_test_vm();+ vm.eval(r#"+ globalThis.__handlingResult='pending';+ (async()=>{+ let hooks=0;+ const saved=Object.getOwnPropertyDescriptor(Promise.prototype,'catch');+ Object.defineProperty(Promise.prototype,'catch',{configurable:true,get(){hooks++;throw Error('author catch getter');}});+ try {+ const reader=new ReadableStream().getReader();+ const pending=reader.read().then(()=>false,error=>error instanceof TypeError);+ const readerClosed=reader.closed.then(()=>false,error=>error instanceof TypeError);+ reader.releaseLock();+ const writer=new WritableStream().getWriter();+ const writerClosed=writer.closed.then(()=>false,error=>error==='stop');+ await writer.abort('stop');+ const writerReady=writer.ready.then(()=>false,error=>error==='stop');+ const results=await Promise.all([pending,readerClosed,writerClosed,writerReady]);+ writer.releaseLock();+ return JSON.stringify({hooks,results});+ } finally {Object.defineProperty(Promise.prototype,'catch',saved);}+ })().then(value=>globalThis.__handlingResult=value,error=>globalThis.__handlingResult='error:'+error.name+':'+error.message);+ "#).unwrap();+ let mut result = String::new();+ for _ in 0..16 {+ result = vm.eval("__handlingResult").unwrap();+ if result != "pending" {+ break;+ }+ }+ assert_eq!(result, r#"{"hooks":0,"results":[true,true,true,true]}"#);+}+#[test]fn writable_stream_writer_promises_survive_missing_or_poisoned_global_promise() {for (label, replacement) in [diff --git a/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rs b/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rsindex e9d0317ef..65bf63947 100644--- a/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rs+++ b/moli-renderer-v8/src/webidl_callback_source_boundary_tests.rs@@ -130,7 +130,7 @@ const DIRECT_V8_CALL_ALLOWLIST: &[AllowedDirectCallFile] = &["context_bootstrap/stream_adapter/utils.rs",// Pending promise settlement and cancellation continuations use the// native Promise API; the remaining calls run stream algorithms.- 5,+ 4,DirectCallOwner::BrowserAlgorithm,),allowed(