Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(url): preserve query and fragment delimiters
ldm08bb43a1ccb3d
diff --git a/moli-renderer-v8/src/context_bootstrap/location_runtime/install.rs b/moli-renderer-v8/src/context_bootstrap/location_runtime/install.rsindex 20010dd0b..f26e5416c 100644--- a/moli-renderer-v8/src/context_bootstrap/location_runtime/install.rs+++ b/moli-renderer-v8/src/context_bootstrap/location_runtime/install.rs@@ -303,7 +303,7 @@ fn location_attribute_getter<'s>(LocationAttribute::Search => {let search = url::Url::parse(¤t_href).ok()- .and_then(|url| url.query().map(|query| format!("?{query}")))+ .map(|url| url::quirks::search(&url).to_owned()).unwrap_or_default();set_return_string(scope, rv, &search);}diff --git a/moli-renderer-v8/src/context_bootstrap/url_form/attributes.rs b/moli-renderer-v8/src/context_bootstrap/url_form/attributes.rsindex 9aa94239a..d0ed60016 100644--- a/moli-renderer-v8/src/context_bootstrap/url_form/attributes.rs+++ b/moli-renderer-v8/src/context_bootstrap/url_form/attributes.rs@@ -255,7 +255,7 @@ fn url_attribute_getter<'s>(}UrlAttribute::Search => {let search = url_object_value(scope, this)- .and_then(|url| url.query().map(|query| format!("?{query}")))+ .map(|url| url::quirks::search(&url).to_owned()).unwrap_or_default();set_return_string(scope, rv, &search);}@@ -266,7 +266,7 @@ fn url_attribute_getter<'s>(}UrlAttribute::Hash => {let hash = url_object_value(scope, this)- .and_then(|url| url.fragment().map(|fragment| format!("#{fragment}")))+ .map(|url| url::quirks::hash(&url).to_owned()).unwrap_or_default();set_return_string(scope, rv, &hash);}@@ -444,11 +444,7 @@ fn url_writable_attribute_setter_callback<'s>(if let Some(mut url) = url_object_value(scope, this)&& let Some(search) = url_attribute_usv_string(scope, args.get(0), attribute){- if search.is_empty() {- url.set_query(None);- } else {- url.set_query(Some(search.trim_start_matches('?')));- }+ url::quirks::set_search(&mut url, &search);apply_url_update(scope, this, &url);}}@@ -456,11 +452,7 @@ fn url_writable_attribute_setter_callback<'s>(if let Some(mut url) = url_object_value(scope, this)&& let Some(hash) = url_attribute_usv_string(scope, args.get(0), attribute){- if hash.is_empty() {- url.set_fragment(None);- } else {- url.set_fragment(Some(hash.trim_start_matches('#')));- }+ url::quirks::set_hash(&mut url, &hash);apply_url_update(scope, this, &url);}}diff --git a/moli-renderer-v8/src/native_bridge/element.rs b/moli-renderer-v8/src/native_bridge/element.rsindex f634ccd22..357da7fc3 100644--- a/moli-renderer-v8/src/native_bridge/element.rs+++ b/moli-renderer-v8/src/native_bridge/element.rs@@ -2445,11 +2445,7 @@ fn anchor_search_getter_function<'s>(anchor_url_string_function_getter(scope,args.this(),- |url| {- url.query()- .map(|query| format!("?{query}"))- .unwrap_or_default()- },+ |url| url::quirks::search(url).to_owned(),rv,);}@@ -2470,11 +2466,7 @@ fn anchor_search_setter_function<'s>(let Some(value) = property_string_value(scope, args.get(0)) else {return;};- if value.is_empty() {- url.set_query(None);- } else {- url.set_query(Some(value.trim_start_matches('?')));- }+ url::quirks::set_search(&mut url, &value);set_resolved_url_attribute(scope, runtime_ptr, handle, "href", &url);rv.set_undefined();}@@ -2487,11 +2479,7 @@ fn anchor_hash_getter_function<'s>(anchor_url_string_function_getter(scope,args.this(),- |url| {- url.fragment()- .map(|fragment| format!("#{fragment}"))- .unwrap_or_default()- },+ |url| url::quirks::hash(url).to_owned(),rv,);}@@ -2512,11 +2500,7 @@ fn anchor_hash_setter_function<'s>(let Some(value) = property_string_value(scope, args.get(0)) else {return;};- if value.is_empty() {- url.set_fragment(None);- } else {- url.set_fragment(Some(value.trim_start_matches('#')));- }+ url::quirks::set_hash(&mut url, &value);set_resolved_url_attribute(scope, runtime_ptr, handle, "href", &url);rv.set_undefined();}diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rsindex c7ee746a4..c017bb662 100644--- a/moli-renderer-v8/src/script_vm/tests/mod.rs+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs@@ -15220,6 +15220,7 @@ mod queue_microtask;mod rendering_update;mod script_terminal_completion;mod streams;+mod url_components;mod webidl_collections;mod webidl_fetch;mod webidl_receivers;diff --git a/moli-renderer-v8/src/script_vm/tests/url_components.rs b/moli-renderer-v8/src/script_vm/tests/url_components.rsnew file mode 100644index 000000000..9a4422dfd--- /dev/null+++ b/moli-renderer-v8/src/script_vm/tests/url_components.rs@@ -0,0 +1,169 @@+use super::*;++fn assert_url_components(script: &str) {+ let mut vm = new_parsed_test_vm(+ "https://url-components.test/base/index.html",+ "<!doctype html><html><body></body></html>",+ );+ let result = vm+ .eval(&format!(+ r#"(() => {{+const assert = (condition, message) => {{ if (!condition) throw new Error(message); }};+const frame = document.body.appendChild(document.createElement('iframe'));+const factories = [+ ['URL', href => new URL(href)],+ ['URL.parse', href => URL.parse(href)],+];+for (const [name, doc] of [+ ['main', document],+ ['child', frame.contentDocument],+ ['detached', document.implementation.createHTMLDocument('components')],+]) {{+ for (const tag of ['a', 'area']) {{+ for (const connected of [false, true]) {{+ factories.push([`${{name}}/${{tag}}/${{connected}}`, href => {{+ const node = doc.createElement(tag);+ node.href = href;+ if (connected) doc.body.appendChild(node);+ return node;+ }}]);+ }}+ }}+}}+{script}+return 'ok';+}})()"#+ ))+ .expect("URL component semantics should match across exposed interfaces");+ assert_eq!(result, "ok");+}++#[test]+fn url_components_empty_getters_preserve_href() {+ assert_url_components(+ r#"+const cases = [+ ['', '', ''], ['?', '', ''], ['#', '', ''], ['?#', '', ''],+ ['?q=%23#frag', '?q=%23', '#frag'], ['??', '??', ''], ['##', '', '##'],+ ['?%3F#%23', '?%3F', '#%23'], ['?%20#%20', '?%20', '#%20'],+];+for (const [name, create] of factories) {+ for (const base of ['https://example.test/path', 'file:///tmp/item', 'mailto:[email protected]']) {+ for (const [suffix, search, hash] of cases) {+ const href = base + suffix;+ const object = create(href);+ assert(object.search === search, `${name}: search for ${href}`);+ assert(object.hash === hash, `${name}: hash for ${href}`);+ assert(object.href === href, `${name}: getters preserve href including empty delimiters`);+ }+ }+}+"#,+ );+}++#[test]+fn url_components_setters_strip_only_one_delimiter() {+ assert_url_components(+ r#"+const base = 'https://example.test/path';+for (const [name, create] of factories) {+ for (const [property, delimiter] of [['search', '?'], ['hash', '#']]) {+ for (const value of [delimiter.repeat(2), delimiter.repeat(3) + 'payload', 'payload', '%23%3F']) {+ const object = create(base);+ const expected = value.startsWith(delimiter) ? value : delimiter + value;+ object[property] = value;+ assert(object[property] === expected, `${name}: ${property} retains payload in ${value}`);+ assert(object.href === base + expected, `${name}: setter preserves remaining delimiters`);+ }+ }+ const object = create(base + '#keep');+ const params = object.searchParams;+ object.search = '??q=value';+ assert(object.href === base + '??q=value#keep', `${name}: query update retains fragment`);+ if (params) {+ assert(object.searchParams === params && params.get('?q') === 'value', 'live URLSearchParams observes the unstripped query payload');+ params.set('?q', 'next');+ assert(object.search === '?%3Fq=next' && object.hash === '#keep', 'URLSearchParams encodes the literal query marker');+ }+}+"#,+ );+}++#[test]+fn url_components_clearing_distinguishes_empty_from_absent() {+ assert_url_components(+ r#"+const base = 'https://example.test/path';+for (const [name, create] of factories) {+ const object = create(base + '?q=value#frag');+ const params = object.searchParams;+ object.search = '?';+ assert(object.search === '' && object.href === base + '?#frag', `${name}: empty query preserves its delimiter`);+ if (params) assert(params.size === 0, 'empty query clears live URLSearchParams');+ object.hash = '#';+ assert(object.hash === '' && object.href === base + '?#', `${name}: empty fragment preserves its delimiter`);+ object.search = '';+ assert(object.search === '' && object.href === base + '#', `${name}: clearing query preserves empty fragment`);+ object.hash = '';+ assert(object.hash === '' && object.href === base, `${name}: clearing fragment removes its delimiter`);+}+"#,+ );+}++#[test]+fn location_components_empty_getters_preserve_document_urls() {+ assert_url_components(+ r#"+const cases = [+ ['', '', ''], ['?', '', ''], ['#', '', ''], ['?#', '', ''],+ ['??query##fragment', '??query', '##fragment'], ['?%3F#%23', '?%3F', '#%23'],+];+for (const [suffix, search, hash] of cases) {+ const href = 'https://url-components.test/base/index.html' + suffix;+ history.replaceState(null, '', href);+ assert(location.search === search && location.hash === hash, `main Location components for ${suffix}`);+ assert(location.href === href && document.URL === href, 'Location getters preserve the document URL');+}+"#,+ );+}++#[test]+fn location_components_child_getters_preserve_committed_urls() {+ for (suffix, search, hash) in [+ ("", "", ""),+ ("?", "", ""),+ ("#", "", ""),+ ("?#", "", ""),+ ("??query##fragment", "??query", "##fragment"),+ ("?%3F#%23", "?%3F", "#%23"),+ ] {+ let mut vm = new_parsed_test_vm(+ "https://url-components.test/base/index.html",+ "<!doctype html><html><body></body></html>",+ );+ let href = format!("about:blank{suffix}");+ vm.eval(&format!(+ "const child = document.createElement('iframe'); child.id = 'child'; \+ child.src = {href:?}; document.body.appendChild(child);"+ ))+ .expect("child URL setup should evaluate");+ vm.drain_pending_child_frame_work_for_test();+ let observed = vm+ .eval(+ "(() => { const child = document.getElementById('child'); \+ const location = child.contentWindow.location; \+ return JSON.stringify([location.search, location.hash, location.href, \+ child.contentDocument.URL]); })()",+ )+ .expect("committed child Location getters should evaluate");+ assert_eq!(+ observed,+ serde_json::json!([search, hash, href, href]).to_string(),+ "child URL {href}"+ );+ }+}