Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(worker): expose OffscreenCanvas WebGL surfaces

ldm094d49a37011f
diff --git a/moli-renderer-v8/src/context_bootstrap/canvas/objects.rs b/moli-renderer-v8/src/context_bootstrap/canvas/objects.rs
index 5384641ed..35e49d539 100644
--- a/moli-renderer-v8/src/context_bootstrap/canvas/objects.rs
+++ b/moli-renderer-v8/src/context_bootstrap/canvas/objects.rs
@@ -62,7 +62,32 @@ fn build_constructed_object<'s>(
pub(super) fn build_webgl_debug_renderer_info_object<'s>(
scope: &mut v8::PinScope<'s, '_>,
) -> Option<v8::Local<'s, v8::Object>> {
- build_constructed_object(scope, "WEBGL_debug_renderer_info")
+ if let Some(object) = build_constructed_object(scope, "WEBGL_debug_renderer_info") {
+ return Some(object);
+ }
+
+ // Extension interfaces are not exposed as Worker globals in Chromium.
+ // Construct the extension object directly when WebGL is running in a
+ // worker realm, where no public constructor exists to instantiate.
+ let object = v8::Object::new(scope);
+ for (name, value) in [
+ ("UNMASKED_VENDOR_WEBGL", 0x9245),
+ ("UNMASKED_RENDERER_WEBGL", 0x9246),
+ ] {
+ let name = v8::String::new(scope, name)?;
+ let defined = object.define_own_property(
+ scope,
+ name.into(),
+ v8::Integer::new(scope, value).into(),
+ v8::PropertyAttribute::READ_ONLY
+ | v8::PropertyAttribute::DONT_DELETE
+ | v8::PropertyAttribute::DONT_ENUM,
+ );
+ if defined != Some(true) {
+ return None;
+ }
+ }
+ Some(object)
}
pub(super) fn build_webgl_lose_context_object<'s>(
diff --git a/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs b/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs
index b00c40af7..81c6822ee 100644
--- a/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs
+++ b/moli-renderer-v8/src/context_bootstrap/exposed_interfaces/metadata.rs
@@ -56,6 +56,17 @@ pub(in crate::context_bootstrap) const WORKER_SHARED_INTERFACE_NAMES: &[&str] =
"CanvasGradient",
"CanvasPattern",
"TextMetrics",
+ "OffscreenCanvas",
+ "OffscreenCanvasRenderingContext2D",
+ "WebGLRenderingContext",
+ "WebGL2RenderingContext",
+ "WebGLObject",
+ "WebGLBuffer",
+ "WebGLFramebuffer",
+ "WebGLProgram",
+ "WebGLRenderbuffer",
+ "WebGLShader",
+ "WebGLUniformLocation",
"Path2D",
"Blob",
"File",
diff --git a/moli-renderer-v8/src/context_bootstrap/specs/registry.rs b/moli-renderer-v8/src/context_bootstrap/specs/registry.rs
index 9aae07190..4664f1ba4 100644
--- a/moli-renderer-v8/src/context_bootstrap/specs/registry.rs
+++ b/moli-renderer-v8/src/context_bootstrap/specs/registry.rs
@@ -1058,7 +1058,7 @@ const CONSTRUCTOR_SPECS_AFTER_STREAMS: &[ConstructorSpec] = &[
},
ConstructorSpec {
name: "OffscreenCanvasRenderingContext2D",
- parent: Some("CanvasRenderingContext2D"),
+ parent: None,
kind: ConstructorKind::OffscreenCanvasRenderingContext2D,
},
ConstructorSpec {
diff --git a/moli-renderer-v8/src/worker/thread/tests/postmessage.rs b/moli-renderer-v8/src/worker/thread/tests/postmessage.rs
index 52630eb37..23c70cd44 100644
--- a/moli-renderer-v8/src/worker/thread/tests/postmessage.rs
+++ b/moli-renderer-v8/src/worker/thread/tests/postmessage.rs
@@ -1862,6 +1862,43 @@ async fn worker_performance_now_uses_readonly_monotonic_time_origin() {
);
}
+#[tokio::test]
+async fn worker_offscreen_canvas_exposes_webgl_identity_consistently() {
+ ensure_v8();
+ let mut handle = spawn_worker(
+ r#"
+ const canvas = new OffscreenCanvas(1, 1);
+ const gl = canvas.getContext("webgl");
+ const debugInfo = gl.getExtension("WEBGL_debug_renderer_info");
+ const twoDimensional = new OffscreenCanvas(1, 1).getContext("2d");
+ postMessage({
+ offscreenCanvas: typeof OffscreenCanvas,
+ offscreen2d: typeof OffscreenCanvasRenderingContext2D,
+ webgl: typeof WebGLRenderingContext,
+ webgl2: typeof WebGL2RenderingContext,
+ extensionGlobal: typeof WEBGL_debug_renderer_info,
+ contextInstance: gl instanceof WebGLRenderingContext,
+ twoDimensionalInstance:
+ twoDimensional instanceof OffscreenCanvasRenderingContext2D,
+ vendor: gl.getParameter(debugInfo.UNMASKED_VENDOR_WEBGL),
+ renderer: gl.getParameter(debugInfo.UNMASKED_RENDERER_WEBGL)
+ });
+ close();
+ "#
+ .into(),
+ "test://worker_offscreen_canvas_webgl".into(),
+ );
+
+ let msg = timeout(TIMEOUT, handle.recv())
+ .await
+ .expect("timed out")
+ .expect("channel closed");
+ assert_eq!(
+ expect_post_json(msg),
+ r#"{"offscreenCanvas":"function","offscreen2d":"function","webgl":"function","webgl2":"function","extensionGlobal":"undefined","contextInstance":true,"twoDimensionalInstance":true,"vendor":"","renderer":""}"#
+ );
+}
+
#[tokio::test]
async fn shared_worker_message_port_handler_can_reply_with_performance_now() {
ensure_v8();