Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

perf(layout): reject out-of-viewport caret queries

ldm09cd3789f235d
diff --git a/moli-renderer-v8/src/native_bridge/context_host/layout.rs b/moli-renderer-v8/src/native_bridge/context_host/layout.rs
index c32777a90..960892e61 100644
--- a/moli-renderer-v8/src/native_bridge/context_host/layout.rs
+++ b/moli-renderer-v8/src/native_bridge/context_host/layout.rs
@@ -485,6 +485,9 @@ impl JsContextHost {
LayoutQuery::HitTestAll { point, .. } if !viewport.contains(*point) => {
LayoutQueryAnswer::HitTestAll(Vec::new())
}
+ LayoutQuery::CaretPosition { point } if !viewport.contains(*point) => {
+ LayoutQueryAnswer::CaretPosition(None)
+ }
_ => tree.answer_query(query),
})
.collect();
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_xhr/dom.rs b/moli-renderer-v8/src/script_vm/tests/dom_xhr/dom.rs
index 358ff8e4f..474d9730d 100644
--- a/moli-renderer-v8/src/script_vm/tests/dom_xhr/dom.rs
+++ b/moli-renderer-v8/src/script_vm/tests/dom_xhr/dom.rs
@@ -2450,6 +2450,12 @@ fn point_queries_use_current_viewport_bounds_with_reused_geometry() {
point: LayoutPoint::new(150.0, 20.0),
ignore_pointer_events_none: false,
},
+ LayoutQuery::CaretPosition {
+ point: LayoutPoint::new(-1.0, -1.0),
+ },
+ LayoutQuery::CaretPosition {
+ point: LayoutPoint::new(150.0, 20.0),
+ },
]);
for (width, expect_hit) in [(320, true), (100, false), (320, true)] {
let answers = GeometryProvider::answer(
@@ -2472,6 +2478,11 @@ fn point_queries_use_current_viewport_bounds_with_reused_geometry() {
panic!("expected hit list")
};
assert_eq!(!hits.is_empty(), expect_hit);
+ assert_eq!(answers.answers[4], LayoutQueryAnswer::CaretPosition(None));
+ let LayoutQueryAnswer::CaretPosition(position) = &answers.answers[5] else {
+ panic!("expected caret position")
+ };
+ assert_eq!(position.is_some(), expect_hit);
assert_eq!(
vm.layout_pass_observability_for_test().1,
before + 1,