Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(images): preserve infinite candidate density

ldm0a0df208ac92a
diff --git a/moli-renderer-v8/src/native_bridge/context_host/image_resources/state.rs b/moli-renderer-v8/src/native_bridge/context_host/image_resources/state.rs
index 2a11aa32d..fc6210ed2 100644
--- a/moli-renderer-v8/src/native_bridge/context_host/image_resources/state.rs
+++ b/moli-renderer-v8/src/native_bridge/context_host/image_resources/state.rs
@@ -337,7 +337,7 @@ impl ImageResourceStore {
}
pub(super) fn intrinsic_dimensions(resource: &ReadyImageResource) -> (f32, f32) {
- let density = if resource.density.is_finite() && resource.density > 0.0 {
+ let density = if resource.density > 0.0 {
resource.density as f32
} else {
1.0
@@ -385,5 +385,11 @@ mod tests {
..resource
};
assert_eq!(intrinsic_dimensions(&high_density_resource), (150.0, 18.75));
+
+ let infinite_density_resource = ReadyImageResource {
+ density: f64::INFINITY,
+ ..high_density_resource
+ };
+ assert_eq!(intrinsic_dimensions(&infinite_density_resource), (0.0, 0.0));
}
}
diff --git a/moli-renderer-v8/src/native_bridge/element/images/src.rs b/moli-renderer-v8/src/native_bridge/element/images/src.rs
index 521b832f1..1bb07ee48 100644
--- a/moli-renderer-v8/src/native_bridge/element/images/src.rs
+++ b/moli-renderer-v8/src/native_bridge/element/images/src.rs
@@ -1343,4 +1343,14 @@ mod tests {
assert_eq!(selected.url, "retina.png");
assert_eq!(selected.density, 2.0);
}
+
+ #[test]
+ fn srcset_zero_source_size_produces_infinite_density() {
+ let selected =
+ selected_srcset_candidate("image.png 256w", Some("0px"), None, false, TEST_VIEWPORT)
+ .expect("a responsive image candidate");
+
+ assert_eq!(selected.url, "image.png");
+ assert!(selected.density.is_infinite());
+ }
}
diff --git a/moli-renderer-v8/src/types.rs b/moli-renderer-v8/src/types.rs
index ff0aac1c8..0f5a05be3 100644
--- a/moli-renderer-v8/src/types.rs
+++ b/moli-renderer-v8/src/types.rs
@@ -287,7 +287,10 @@ pub(super) struct ImageRequestKey {
impl ImageRequestKey {
pub(super) fn with_density(url: String, cors_mode: ImageRequestCorsMode, density: f64) -> Self {
let density = if density == 0.0 { 0.0 } else { density };
- debug_assert!(density.is_finite() && density >= 0.0);
+ // A width descriptor divided by a zero source size has positive
+ // infinite density. Preserve it so the image's natural dimensions
+ // become zero instead of incorrectly falling back to 1x.
+ debug_assert!(!density.is_nan() && density >= 0.0);
Self {
url,
cors_mode,
@@ -1626,6 +1629,13 @@ mod tests {
ImageRequestKey::with_density(url, ImageRequestCorsMode::NoCors, 2.0),
"responsive-image identity must include the selected candidate density"
);
+
+ let infinite_density = ImageRequestKey::with_density(
+ "https://example.test/zero-source-size.png".to_owned(),
+ ImageRequestCorsMode::NoCors,
+ f64::INFINITY,
+ );
+ assert!(infinite_density.density().is_infinite());
}
#[test]