Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(cssom): retain adopted stylesheet array realms after conversion

ldm0a3875b4310c3
diff --git a/moli-renderer-v8/src/native_bridge/document/css_state/accessors.rs b/moli-renderer-v8/src/native_bridge/document/css_state/accessors.rs
index 9f7c9f691..342de9e11 100644
--- a/moli-renderer-v8/src/native_bridge/document/css_state/accessors.rs
+++ b/moli-renderer-v8/src/native_bridge/document/css_state/accessors.rs
@@ -164,6 +164,7 @@ fn set_document_adopted_style_sheets_for_receiver<'s>(
let holder = receiver;
let Some(next_array) = normalize_adopted_style_sheets_assignment(
scope,
+ receiver,
value,
AdoptedStyleSheetsArrayOwner::Document {
validation_document: handle,
@@ -189,6 +190,7 @@ fn set_document_adopted_style_sheets_for_receiver<'s>(
pub(in crate::native_bridge) fn normalize_adopted_style_sheets_assignment<'s>(
scope: &mut v8::PinScope<'s, '_>,
+ receiver: v8::Local<'s, v8::Object>,
value: v8::Local<'s, v8::Value>,
owner: AdoptedStyleSheetsArrayOwner,
target_document: Option<DomHandle>,
@@ -214,11 +216,18 @@ pub(in crate::native_bridge) fn normalize_adopted_style_sheets_assignment<'s>(
.into_iter()
.map(|sheet| sheet.0.into())
.collect::<Vec<_>>();
- let array = v8::Array::new_with_elements(scope, &values);
+ let context = receiver.get_creation_context(scope)?;
+ let array = {
+ let scope = &mut v8::ContextScope::new(scope, context);
+ v8::Array::new_with_elements(scope, &values)
+ };
if !validate_adopted_style_sheet_array(scope, array, target_document) {
return None;
}
- install_adopted_style_sheets_array_mutation_methods(scope, array, owner);
+ {
+ let scope = &mut v8::ContextScope::new(scope, context);
+ install_adopted_style_sheets_array_mutation_methods(scope, array, owner);
+ }
Some(array)
}
diff --git a/moli-renderer-v8/src/native_bridge/element/shadow_dom/root_accessors.rs b/moli-renderer-v8/src/native_bridge/element/shadow_dom/root_accessors.rs
index 841663eff..6832b3fe8 100644
--- a/moli-renderer-v8/src/native_bridge/element/shadow_dom/root_accessors.rs
+++ b/moli-renderer-v8/src/native_bridge/element/shadow_dom/root_accessors.rs
@@ -655,6 +655,7 @@ fn set_shadow_root_adopted_style_sheets_for_receiver<'s>(
.and_then(crate::dom::native::Node::owner_document);
let Some(next_array) = normalize_adopted_style_sheets_assignment(
scope,
+ receiver,
value,
AdoptedStyleSheetsArrayOwner::ShadowRoot(handle),
owner_document,
diff --git a/moli-renderer-v8/src/script_vm/tests/browser_api/adopted_style_sheets.rs b/moli-renderer-v8/src/script_vm/tests/browser_api/adopted_style_sheets.rs
index 7a406597f..2844f065f 100644
--- a/moli-renderer-v8/src/script_vm/tests/browser_api/adopted_style_sheets.rs
+++ b/moli-renderer-v8/src/script_vm/tests/browser_api/adopted_style_sheets.rs
@@ -20,3 +20,50 @@ fn adopted_stylesheet_setters_convert_iterables_and_preserve_conversion_exceptio
.unwrap(),
);
}
+
+#[test]
+fn adopted_stylesheet_assignment_keeps_arrays_and_mutation_methods_in_receiver_realm() {
+ let mut vm = new_parsed_test_vm(
+ "https://adopted-stylesheet-array-realms.test/",
+ "<!doctype html><iframe id=child></iframe>",
+ );
+ assert_eq!(vm.eval(r#"(() => {
+ const realms = [window, document.querySelector('#child').contentWindow];
+ for (const owner of realms) for (const callee of realms) {
+ for (const kind of ['Document', 'ShadowRoot']) {
+ const doc = owner.document, host = doc.body.appendChild(doc.createElement('div'));
+ const receiver = kind === 'Document' ? doc : host.attachShadow({mode:'open'});
+ const own = Object.getOwnPropertyDescriptor(owner[kind].prototype, 'adoptedStyleSheets');
+ const borrowed = Object.getOwnPropertyDescriptor(callee[kind].prototype, 'adoptedStyleSheets');
+ const sheet = new owner.CSSStyleSheet(), input = new owner.Array(sheet);
+ try {
+ own.get.call(receiver);
+ borrowed.set.call(receiver, input);
+ const result = borrowed.get.call(receiver);
+ if (result === input || result.length !== 1 || result[0] !== sheet)
+ throw Error(kind + ': owned contents');
+ if (Object.getPrototypeOf(result) !== owner.Array.prototype)
+ throw Error(kind + ': receiver Array realm');
+ if (Object.getPrototypeOf(result.push) !== owner.Function.prototype)
+ throw Error(kind + ': receiver mutation-method realm');
+ if (Object.hasOwn(input, 'push') || input.push !== owner.Array.prototype.push)
+ throw Error(kind + ': author input changed');
+ input.length = 0;
+ if (result.length !== 1) throw Error(kind + ': input container aliases state');
+ let caught;
+ try {borrowed.set.call(receiver, null);} catch (error) {caught = error;}
+ if (Object.getPrototypeOf(caught) !== callee.TypeError.prototype)
+ throw Error(kind + ': conversion error realm');
+ const marker = {};
+ try {
+ borrowed.set.call(receiver, {get [Symbol.iterator]() {throw marker;}});
+ throw Error(kind + ': accepted abrupt iterator');
+ } catch (error) {if (error !== marker) throw error;}
+ if (borrowed.get.call(receiver) !== result)
+ throw Error(kind + ': failed assignment changed state');
+ } finally {own.set.call(receiver, []); host.remove();}
+ }
+ }
+ return true;
+ })()"#).unwrap(), "true");
+}