Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(webidl): derive idb object store receiver checks

ldm0a5fdccbe6b49
diff --git a/moli-renderer-v8/src/context_bootstrap/indexed_db/install/constructors/object_store_index/object_store.rs b/moli-renderer-v8/src/context_bootstrap/indexed_db/install/constructors/object_store_index/object_store.rs
index a9fb4456f..a3160e334 100644
--- a/moli-renderer-v8/src/context_bootstrap/indexed_db/install/constructors/object_store_index/object_store.rs
+++ b/moli-renderer-v8/src/context_bootstrap/indexed_db/install/constructors/object_store_index/object_store.rs
@@ -3,7 +3,7 @@ use crate::web_api_interfaces;
use moli_webapi_declare::WebApiFunctionTemplate;
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::IDBObjectStore, enumerable)]
+#[webapi(interface = web_api_interfaces::IDBObjectStore, enumerable, receiver)]
struct IdbObjectStorePrototypeDeclaration {
#[webapi(method, length = 1, callback = idb_object_store_get_callback)]
get: (),
diff --git a/moli-renderer-v8/src/script_vm/tests/idb_object_store_native_receivers.rs b/moli-renderer-v8/src/script_vm/tests/idb_object_store_native_receivers.rs
new file mode 100644
index 000000000..0b540a5ad
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/idb_object_store_native_receivers.rs
@@ -0,0 +1,75 @@
+use super::*;
+
+#[test]
+fn idb_object_store_native_receivers_reject_forgery_before_conversion_in_the_callee_realm() {
+ let mut vm =
+ new_storage_page_task_executor_test_vm("https://idb-object-store-native-receivers.test/");
+ vm.eval(r#"
+ document.body.innerHTML = '<iframe></iframe>';
+ const other = document.querySelector('iframe').contentWindow;
+ globalThis.receiverResult = "pending";
+ const open = indexedDB.open("native-receivers", 1);
+ open.onerror = () => {receiverResult = "open:" + open.error.name;};
+ open.onupgradeneeded = () => {
+ function checkReceivers() {
+ const store = open.result.createObjectStore("values");
+ let conversions = 0;
+ let traps = 0;
+ const poison = {
+ [Symbol.toPrimitive]() { conversions++; return '3'; },
+ get subtree() { conversions++; throw new Error('unexpected options conversion'); }
+ };
+ const cases = [
+ ["IDBObjectStore", "count", "method", store, [], [poison]],
+ ["IDBObjectStore", "getAll", "method", store, [], [poison]],
+ ["IDBObjectStore", "getAllKeys", "method", store, [], [poison]],
+ ["IDBObjectStore", "get", "method", store, ["missing"], [poison]],
+ ["IDBObjectStore", "getKey", "method", store, ["missing"], [poison]],
+ ["IDBObjectStore", "put", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "add", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "delete", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "clear", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "createIndex", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "index", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "deleteIndex", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "openCursor", "method", store, null, [poison, poison]],
+ ["IDBObjectStore", "openKeyCursor", "method", store, null, [poison, poison]],
+ ];
+ for (const realm of [window, other]) {
+ for (const [interfaceName, name, kind, value, validArgs, invalidArgs] of cases) {
+ const prototype = realm[interfaceName].prototype;
+ const descriptor = Object.getOwnPropertyDescriptor(prototype, name);
+ const operation = kind === 'method' ? prototype[name] : descriptor && descriptor[kind];
+ if (typeof operation !== 'function')
+ throw new Error(interfaceName + '.' + name + ': missing prototype member');
+ const result = validArgs === null ? null : Reflect.apply(operation, value, validArgs);
+ if (validArgs !== null && (!result || typeof result !== 'object'))
+ throw new Error(interfaceName + '.' + name + ': genuine request/object result');
+ if (kind === 'get' && result === undefined)
+ throw new Error(interfaceName + '.' + name + ': genuine receiver lost native state');
+ const author = new Proxy(value, {
+ get() { traps++; throw new Error('unexpected receiver get'); },
+ getPrototypeOf() { traps++; throw new Error('unexpected receiver prototype'); }
+ });
+ const revoked = Proxy.revocable(value, {}); revoked.revoke();
+ for (const receiver of [null, undefined, {}, Object.create(value),
+ Object.create(prototype), author, revoked.proxy]) {
+ let error;
+ try { Reflect.apply(operation, receiver, invalidArgs); }
+ catch (caught) { error = caught; }
+ if (!error || Object.getPrototypeOf(error) !== realm.TypeError.prototype)
+ throw new Error(interfaceName + '.' + name + ': expected callee TypeError');
+ }
+ }
+ }
+ if (conversions !== 0 || traps !== 0)
+ throw new Error('receiver validation ran author code before rejection');
+ return 'ok';
+ }
+ try { receiverResult = checkReceivers(); }
+ catch (error) { receiverResult = String(error); }
+ };
+ "#).unwrap();
+ let result = vm.eval_after_selected_page_tasks("receiverResult").unwrap();
+ assert_eq!(result, "ok");
+}
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index b5da0153b..12135bacb 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2250,6 +2250,9 @@ mod web_lock_interface_exposure_interfaces;
mod webgl_interfaces;
mod webidl_collections;
mod webidl_fetch;
+
+mod idb_object_store_native_receivers;
+
mod webidl_receivers;
mod webidl_trusted_types;
mod websocket;