Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(webidl): derive svg animated value receiver checks

ldm0abcb484652e6
diff --git a/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs b/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs
index a1253e966..a8e6ebc42 100644
--- a/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs
+++ b/moli-renderer-v8/src/context_bootstrap/svg_runtime/bindings.rs
@@ -1108,7 +1108,7 @@ struct SvgNumberTemplateAccessorsDeclaration {
}
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::SVGAnimatedLengthList, enumerable)]
+#[webapi(interface = web_api_interfaces::SVGAnimatedLengthList, enumerable, receiver)]
struct SvgAnimatedLengthListTemplateAccessorsDeclaration {
#[webapi(
accessor_property = "baseVal",
@@ -1164,7 +1164,7 @@ struct SvgAnimatedIntegerTemplateAccessorsDeclaration {
}
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::SVGAnimatedNumberList, enumerable)]
+#[webapi(interface = web_api_interfaces::SVGAnimatedNumberList, enumerable, receiver)]
struct SvgAnimatedNumberListTemplateAccessorsDeclaration {
#[webapi(
accessor_property = "baseVal",
@@ -1253,7 +1253,7 @@ struct SvgStringListTemplateAccessorsDeclaration {
}
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::SVGAnimatedTransformList, enumerable)]
+#[webapi(interface = web_api_interfaces::SVGAnimatedTransformList, enumerable, receiver)]
struct SvgAnimatedTransformListTemplateAccessorsDeclaration {
#[webapi(
accessor_property = "baseVal",
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index 6a937c9b7..6994767e8 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2215,6 +2215,9 @@ mod lazy_window_surfaces;
mod midi_owner_interfaces;
mod mouse_snapshot;
mod native_bridge_identity;
+
+mod svg_animated_value_native_receivers;
+
mod native_exception_stack_capture;
mod no_cors_header_fill;
mod node_event_worlds;
diff --git a/moli-renderer-v8/src/script_vm/tests/svg_animated_value_native_receivers.rs b/moli-renderer-v8/src/script_vm/tests/svg_animated_value_native_receivers.rs
new file mode 100644
index 000000000..ca4b1657a
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/svg_animated_value_native_receivers.rs
@@ -0,0 +1,57 @@
+use super::*;
+
+#[test]
+fn svg_animated_value_native_receivers_reject_forgery_before_conversion_in_the_callee_realm() {
+ let mut vm = new_storage_html_test_vm("https://svg-animated-value-native-receivers.test/");
+ let result = vm.eval(r#"
+ document.body.innerHTML = '<iframe></iframe>';
+ const other = document.querySelector('iframe').contentWindow;
+ const ns = 'http://www.w3.org/2000/svg';
+ const svg = document.createElementNS(ns, 'svg'); document.body.append(svg);
+ const createSvg = name => {const node=document.createElementNS(ns,name); svg.append(node); return node;};
+ const lengths = createSvg('text').x; const numbers = createSvg('text').rotate; const transforms = createSvg('rect').transform;
+ let conversions = 0;
+ let traps = 0;
+ const poison = {
+ [Symbol.toPrimitive]() { conversions++; return '3'; },
+ get subtree() { conversions++; throw new Error('unexpected options conversion'); }
+ };
+ const cases = [
+ ["SVGAnimatedLengthList", "baseVal", "get", lengths, [], [poison]],
+ ["SVGAnimatedLengthList", "animVal", "get", lengths, [], [poison]],
+ ["SVGAnimatedNumberList", "baseVal", "get", numbers, [], [poison]],
+ ["SVGAnimatedNumberList", "animVal", "get", numbers, [], [poison]],
+ ["SVGAnimatedTransformList", "baseVal", "get", transforms, [], [poison]],
+ ["SVGAnimatedTransformList", "animVal", "get", transforms, [], [poison]],
+ ];
+ for (const realm of [window, other]) {
+ for (const [interfaceName, name, kind, value, validArgs, invalidArgs] of cases) {
+ const prototype = realm[interfaceName].prototype;
+ const descriptor = Object.getOwnPropertyDescriptor(prototype, name);
+ const operation = kind === 'method' ? prototype[name] : descriptor && descriptor[kind];
+ if (typeof operation !== 'function')
+ throw new Error(interfaceName + '.' + name + ': missing prototype member');
+ const result = Reflect.apply(operation, value, validArgs);
+ if (kind === 'get' && result === undefined)
+ throw new Error(interfaceName + '.' + name + ': genuine receiver lost native state');
+ const author = new Proxy(value, {
+ get() { traps++; throw new Error('unexpected receiver get'); },
+ getPrototypeOf() { traps++; throw new Error('unexpected receiver prototype'); }
+ });
+ const revoked = Proxy.revocable(value, {}); revoked.revoke();
+ for (const receiver of [null, undefined, {}, Object.create(value),
+ Object.create(prototype), author, revoked.proxy]) {
+ let error;
+ try { Reflect.apply(operation, receiver, invalidArgs); }
+ catch (caught) { error = caught; }
+ if (!error || Object.getPrototypeOf(error) !== realm.TypeError.prototype)
+ throw new Error(interfaceName + '.' + name + ': expected callee TypeError');
+ }
+ }
+ }
+ if (conversions !== 0 || traps !== 0)
+ throw new Error('receiver validation ran author code before rejection');
+ 'ok';
+ "#).unwrap();
+ assert_eq!(result, "ok");
+}