Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(fetch): create buffered response clones in the receiver realm

ldm0ae8c16eaaa26
diff --git a/moli-renderer-v8/src/network_host/fetch_surface.rs b/moli-renderer-v8/src/network_host/fetch_surface.rs
index af285a833..79aa1faed 100644
--- a/moli-renderer-v8/src/network_host/fetch_surface.rs
+++ b/moli-renderer-v8/src/network_host/fetch_surface.rs
@@ -838,7 +838,10 @@ fn response_clone_callback<'s>(
);
return;
}
- let global = scope.get_current_context().global(scope);
+ let Some(realm) = this.get_creation_context(scope) else {
+ return;
+ };
+ let global = realm.global(scope);
let Some(ctor) = global.get(scope, v8str(scope, "Response").into()) else {
rv.set_undefined();
return;
diff --git a/moli-renderer-v8/src/script_vm/tests/webidl_fetch/webidl_interfaces_and_url_params.rs b/moli-renderer-v8/src/script_vm/tests/webidl_fetch/webidl_interfaces_and_url_params.rs
index 1806a725a..e11ef28f4 100644
--- a/moli-renderer-v8/src/script_vm/tests/webidl_fetch/webidl_interfaces_and_url_params.rs
+++ b/moli-renderer-v8/src/script_vm/tests/webidl_fetch/webidl_interfaces_and_url_params.rs
@@ -665,7 +665,7 @@ fn request_and_response_headers_share_intrinsic_prototype_methods() {
}
#[tokio::test]
-async fn response_headers_keep_receiver_realm_across_borrowed_getters() {
+async fn response_headers_keep_receiver_realm_across_borrowed_getters_and_clones() {
let mut vm = new_storage_test_vm("https://headers-owner-realm.test/");
vm.eval(
r#"
@@ -694,12 +694,12 @@ body.appendChild(headersFrame);
configurable: true, get() { throw new Error('public Headers lookup'); }
});
try {
- for (const [response, ctor, getter, value] of [
- [parentResponse, parentHeaders, childGetter, 'parent'],
- [childResponse, childHeaders, parentGetter, 'child']
+ for (const [response, clone, ctor, getter, value] of [
+ [parentResponse, child.Response.prototype.clone.call(parentResponse), parentHeaders, childGetter, 'parent'],
+ [childResponse, Response.prototype.clone.call(childResponse), childHeaders, parentGetter, 'child']
]) {
check(getter.call(response) === response.headers, 'borrowed getter returns associated Headers');
- for (const entry of [response]) {
+ for (const entry of [response, clone]) {
const headers = entry.headers;
check(Object.getPrototypeOf(headers) === ctor.prototype && headers instanceof ctor,
'Headers must use the response realm');