Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(dom): match class-name collections using document quirks mode

ldm0bc116c16dc08
diff --git a/moli-dom/src/native/element/mod.rs b/moli-dom/src/native/element/mod.rs
index e62f3c56e..0de3f42eb 100644
--- a/moli-dom/src/native/element/mod.rs
+++ b/moli-dom/src/native/element/mod.rs
@@ -16,6 +16,7 @@ use attribute::{normalized_option_text_content, split_class_names};
use html5ever::{LocalName, Namespace, Prefix};
use indexmap::IndexSet;
use rare_data::ElementRareData;
+use selectors::attr::CaseSensitivity;
use thin_vec::ThinVec;
use super::NativeDom;
@@ -451,6 +452,14 @@ impl Element {
}
pub fn matches_class_names(&self, class_name: &str) -> bool {
+ self.matches_class_names_with_case_sensitivity(class_name, CaseSensitivity::CaseSensitive)
+ }
+
+ pub fn matches_class_names_with_case_sensitivity(
+ &self,
+ class_name: &str,
+ case_sensitivity: CaseSensitivity,
+ ) -> bool {
let expected_classes = split_class_names(class_name);
if expected_classes.is_empty() {
return false;
@@ -460,9 +469,12 @@ impl Element {
return false;
};
let actual_classes = split_class_names(actual);
- expected_classes
- .iter()
- .all(|expected| actual_classes.iter().any(|actual| actual == expected))
+ expected_classes.iter().all(|expected| {
+ actual_classes.iter().any(|actual| match case_sensitivity {
+ CaseSensitivity::CaseSensitive => actual == expected,
+ CaseSensitivity::AsciiCaseInsensitive => actual.eq_ignore_ascii_case(expected),
+ })
+ })
}
pub fn matches_name(&self, name: &str) -> bool {
diff --git a/moli-dom/src/native/queries.rs b/moli-dom/src/native/queries.rs
index 0ad0c9d56..45787dfb2 100644
--- a/moli-dom/src/native/queries.rs
+++ b/moli-dom/src/native/queries.rs
@@ -2,6 +2,7 @@ use super::NativeDom;
use super::element::Element;
use super::node::{NativeNodeId, Node};
use crate::forms::parse_non_negative_integer_prefix;
+use selectors::attr::CaseSensitivity;
impl NativeDom {
pub fn is_html_element_named(&self, node_id: NativeNodeId, local_name: &str) -> bool {
@@ -127,8 +128,21 @@ impl NativeDom {
class_name: &str,
include_root: bool,
) -> Vec<NativeNodeId> {
+ let document = self.node(root).and_then(|node| {
+ node.as_document().or_else(|| {
+ self.node(node.owner_document()?)
+ .and_then(Node::as_document)
+ })
+ });
+ let case_sensitivity = if document.is_some_and(|document| {
+ document.quirks_mode() == selectors::matching::QuirksMode::Quirks
+ }) {
+ CaseSensitivity::AsciiCaseInsensitive
+ } else {
+ CaseSensitivity::CaseSensitive
+ };
self.collect_matching_elements(root, include_root, |element, _| {
- element.matches_class_names(class_name)
+ element.matches_class_names_with_case_sensitivity(class_name, case_sensitivity)
})
}
diff --git a/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_collections.rs b/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_collections.rs
index 20d9e84ab..5d7a98bfc 100644
--- a/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_collections.rs
+++ b/moli-renderer-v8/src/script_vm/tests/dom_elements/live_document/document_collections.rs
@@ -682,3 +682,34 @@ fn document_write_parses_variadic_webidl_strings() {
assert_eq!(result, "value:null|TypeError|value:null");
}
+
+#[test]
+fn class_name_collections_follow_the_owner_document_quirks_mode() {
+ for (doctype, mode, lowercase_matches) in [
+ ("", "BackCompat", 2),
+ ("<!doctype html>", "CSS1Compat", 1),
+ (
+ r#"<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">"#,
+ "CSS1Compat",
+ 1,
+ ),
+ ] {
+ let mut vm = new_parsed_test_vm(
+ "https://class-name-queries.test/",
+ &format!(
+ "{doctype}<main id='root'><i class='FOO BAR'></i><i class='foo bar'></i><i class='É'></i></main>"
+ ),
+ );
+ assert_eq!(vm.eval(r#"(() => {
+ const root = document.getElementById('root');
+ const live = root.getElementsByClassName('foo bar');
+ const before = live.length;
+ root.firstElementChild.setAttribute('class', 'other');
+ const xml = new DOMParser().parseFromString('<root><item class="FOO BAR"/></root>', 'application/xml');
+ return [document.compatMode, document.getElementsByClassName('foo bar').length,
+ before, live.length, root.getElementsByClassName('é').length,
+ xml.getElementsByClassName('foo bar').length,
+ xml.getElementsByClassName('FOO BAR').length].join('|');
+ })()"#).unwrap(), format!("{mode}|1|{lowercase_matches}|1|0|0|1"), "doctype {doctype}");
+ }
+}