Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(style): preserve legacy table alignment semantics
ldm0c11ce0ce3f70
diff --git a/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs b/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rsindex b56106aed..3fcab8f21 100644--- a/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs+++ b/moli-renderer-v8/src/runtime/page_vm/tests/rendering_update.rs@@ -2897,7 +2897,7 @@ return [})()"#;assert_eq!(page_vm.vm_mut().eval(read_table)?,- "0px|rgb(246, 246, 239)|rgb(255, 102, 0)|right|170",+ "0px|rgb(246, 246, 239)|rgb(255, 102, 0)|-moz-right|170","legacy table attributes must participate in the presentation-hint cascade",);@@ -2928,7 +2928,7 @@ header.setAttribute('align', 'left');.expect("mutated legacy table fixture must retain a layout root");assert_eq!(page_vm.vm_mut().eval(read_table)?,- "5px|rgb(1, 2, 3)|rgb(4, 5, 6)|left|100",+ "5px|rgb(1, 2, 3)|rgb(4, 5, 6)|-moz-left|100","legacy table attribute mutations must recascade their presentation hints",);Ok::<_, anyhow::Error>(())@@ -2937,6 +2937,118 @@ header.setAttribute('align', 'left');.expect("legacy table presentational-style fixture should run");}+#[tokio::test(flavor = "current_thread")]+async fn screenshot_aligns_legacy_table_block_descendants() {+ run_page_vm_async_test(async move {+ let loader =+ crate::network::ResourceRequestClient::new(&FetchConfig::default()).expect("loader");+ let mut page_vm = test_page_vm_with_loader_and_document_url(+ &loader,+ Vec::new(),+ Url::parse("https://example.com/table-descendant-alignment.html")?,+ );+ page_vm.vm_mut().eval(+ r##"+document.head.innerHTML = `<style>+html,body{margin:0}+table{border-spacing:0}+td{padding:0;width:100px;height:10px}+.box{width:10px;height:10px}+</style>`;+document.body.innerHTML = `+<table>+ <tr><td id=right align=right><div id=right-block class=box></div></td></tr>+ <tr><td id=left align=left style="direction:rtl"><div id=left-block class=box></div></td></tr>+</table>`;+'installed'+"##,+ )?;+ page_vm.vm_mut().sync_live_document_style_sources();++ page_vm+ .vm_mut()+ .screenshot_layout_snapshot(moli_layout::PaintViewport::new(200, 100, 1.0))?+ .expect("legacy descendant-alignment fixture must retain a layout root");+ assert_eq!(+ page_vm.vm_mut().eval(+ r#"(() => {+const right = document.getElementById('right').getBoundingClientRect();+const rightBlock = document.getElementById('right-block').getBoundingClientRect();+const left = document.getElementById('left').getBoundingClientRect();+const leftBlock = document.getElementById('left-block').getBoundingClientRect();+return [+ getComputedStyle(document.getElementById('right')).textAlign,+ right.width,+ rightBlock.x - right.x,+ getComputedStyle(document.getElementById('left')).textAlign,+ left.width,+ leftBlock.x - left.x,+].join('|');+})()"#,+ )?,+ "-moz-right|100|90|-moz-left|100|0",+ "legacy table alignment must affect fixed-width block descendants in both directions",+ );+ Ok::<_, anyhow::Error>(())+ })+ .await+ .expect("legacy table descendant-alignment fixture should run");+}++#[tokio::test(flavor = "current_thread")]+async fn screenshot_centers_table_headers_only_without_inherited_alignment() {+ run_page_vm_async_test(async move {+ let loader =+ crate::network::ResourceRequestClient::new(&FetchConfig::default()).expect("loader");+ let mut page_vm = test_page_vm_with_loader_and_document_url(+ &loader,+ Vec::new(),+ Url::parse("https://example.com/table-header-alignment.html")?,+ );+ page_vm.vm_mut().eval(+ r##"+document.head.innerHTML = `<style>+html,body{margin:0}+table{border-spacing:0}+th{padding:0;width:100px;height:10px;font-size:0}+.box{display:inline-block;width:10px;height:10px}+</style>`;+document.body.innerHTML = `+<table><tr><th id=default-header><span id=centered class=box></span></th></tr></table>+<table><tr align=right><th id=inherited-header><span id=right-aligned class=box></span></th></tr></table>`;+'installed'+"##,+ )?;+ page_vm.vm_mut().sync_live_document_style_sources();++ page_vm+ .vm_mut()+ .screenshot_layout_snapshot(moli_layout::PaintViewport::new(200, 100, 1.0))?+ .expect("table-header alignment fixture must retain a layout root");+ assert_eq!(+ page_vm.vm_mut().eval(+ r#"(() => {+const centered = document.getElementById('centered').getBoundingClientRect();+const defaultHeader = document.getElementById('default-header').getBoundingClientRect();+const rightAligned = document.getElementById('right-aligned').getBoundingClientRect();+const inheritedHeader = document.getElementById('inherited-header').getBoundingClientRect();+return [+ getComputedStyle(document.getElementById('default-header')).textAlign,+ centered.x - defaultHeader.x,+ getComputedStyle(document.getElementById('inherited-header')).textAlign,+ rightAligned.x - inheritedHeader.x,+].join('|');+})()"#,+ )?,+ "center|45|-moz-right|90",+ "table headers must center by default but inherit an explicit row alignment",+ );+ Ok::<_, anyhow::Error>(())+ })+ .await+ .expect("table-header alignment fixture should run");+}+#[tokio::test(flavor = "current_thread")]async fn screenshot_preserves_nested_table_cell_height_and_vertical_alignment() {run_page_vm_async_test(async move {diff --git a/moli-renderer-v8/src/style_engine/ua/html.css b/moli-renderer-v8/src/style_engine/ua/html.cssindex 32831c632..8132564a1 100644--- a/moli-renderer-v8/src/style_engine/ua/html.css+++ b/moli-renderer-v8/src/style_engine/ua/html.css@@ -139,7 +139,7 @@ th:not(table th) {th {font-weight: bold;- text-align: -moz-center;+ text-align: -moz-center-or-inherit;}caption {diff --git a/moli-selector/src/stylo/presentation.rs b/moli-selector/src/stylo/presentation.rsindex e2612271c..9901d8152 100644--- a/moli-selector/src/stylo/presentation.rs+++ b/moli-selector/src/stylo/presentation.rs@@ -222,8 +222,8 @@ fn append_html_table_part_alignment_declarations(let text_align = match text_align.to_ascii_lowercase().as_str() {"middle" | "center" => "-moz-center","absmiddle" => "center",- "left" => "left",- "right" => "right",+ "left" => "-moz-left",+ "right" => "-moz-right",_ => text_align,};append_parsed_presentation_declaration(element, "text-align", text_align, block);