Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(geometry): preserve exact DOMMatrix inverse identities

ldm0c7cc93fb0316
diff --git a/moli-geometry/src/lib.rs b/moli-geometry/src/lib.rs
index a7fb2deec..4abb232ce 100644
--- a/moli-geometry/src/lib.rs
+++ b/moli-geometry/src/lib.rs
@@ -73,6 +73,42 @@ mod tests {
assert_close(product.m43, 0.0);
}
+ #[test]
+ fn inverse_product_preserves_exact_identity_for_affine_3d_matrix() {
+ let matrix = DomMatrixComponents {
+ m11: 1.0,
+ m12: -0.5,
+ m13: 0.5,
+ m14: 0.0,
+ m21: 0.5,
+ m22: 2.0,
+ m23: -0.5,
+ m24: 0.0,
+ m31: 0.0,
+ m32: 0.0,
+ m33: 1.0,
+ m34: 0.0,
+ m41: 10.0,
+ m42: 20.0,
+ m43: 10.0,
+ m44: 1.0,
+ };
+ let product = matrix.multiply(matrix.inverse());
+
+ assert!(product.is_identity(), "unexpected product: {product:?}");
+ }
+
+ #[test]
+ fn inverse_preserves_exact_2d_structure() {
+ let inverse = DomMatrixComponents::identity()
+ .scaled_2d(0.1, 0.1)
+ .inverse();
+
+ assert!(inverse.is_2d());
+ assert_eq!(inverse.m33, 1.0);
+ assert_eq!(inverse.m44, 1.0);
+ }
+
#[test]
fn combined_rotation_applies_z_then_y_then_x() {
let combined = DomMatrixComponents::identity().rotated(90.0, 90.0, 90.0);
diff --git a/moli-geometry/src/matrix.rs b/moli-geometry/src/matrix.rs
index cd9399dd9..90bf32dfa 100644
--- a/moli-geometry/src/matrix.rs
+++ b/moli-geometry/src/matrix.rs
@@ -301,6 +301,13 @@ impl DomMatrixComponents {
}
pub fn inverse(self) -> Self {
+ if let Some(inverse) = self.inverse_2d() {
+ return inverse;
+ }
+ if let Some(inverse) = self.affine_inverse() {
+ return inverse;
+ }
+
let mut matrix = [
[self.m11, self.m21, self.m31, self.m41],
[self.m12, self.m22, self.m32, self.m42],
@@ -371,6 +378,108 @@ impl DomMatrixComponents {
}
}
+ fn inverse_2d(self) -> Option<Self> {
+ if !self.is_2d() {
+ return None;
+ }
+
+ let determinant = self.m11 * self.m22 - self.m12 * self.m21;
+ if determinant == 0.0 || !determinant.is_finite() {
+ return None;
+ }
+ let inverse_determinant = 1.0 / determinant;
+ let inverse = Self {
+ m11: self.m22 * inverse_determinant,
+ m12: -self.m12 * inverse_determinant,
+ m21: -self.m21 * inverse_determinant,
+ m22: self.m11 * inverse_determinant,
+ m41: (self.m21 * self.m42 - self.m22 * self.m41) * inverse_determinant,
+ m42: (self.m12 * self.m41 - self.m11 * self.m42) * inverse_determinant,
+ ..Self::identity()
+ };
+ let values = [
+ inverse.m11,
+ inverse.m12,
+ inverse.m21,
+ inverse.m22,
+ inverse.m41,
+ inverse.m42,
+ ];
+
+ values
+ .iter()
+ .all(|value| value.is_finite())
+ .then_some(inverse)
+ }
+
+ fn affine_inverse(self) -> Option<Self> {
+ if self.m14 != 0.0 || self.m24 != 0.0 || self.m34 != 0.0 || self.m44 != 1.0 {
+ return None;
+ }
+
+ let a = self.m11;
+ let b = self.m21;
+ let c = self.m31;
+ let d = self.m12;
+ let e = self.m22;
+ let f = self.m32;
+ let g = self.m13;
+ let h = self.m23;
+ let i = self.m33;
+ let determinant = a * (e * i - f * h) - b * (d * i - f * g) + c * (d * h - e * g);
+ if determinant == 0.0 || !determinant.is_finite() {
+ return None;
+ }
+ let inverse_determinant = 1.0 / determinant;
+
+ let m11 = (e * i - f * h) * inverse_determinant;
+ let m21 = (c * h - b * i) * inverse_determinant;
+ let m31 = (b * f - c * e) * inverse_determinant;
+ let m12 = (f * g - d * i) * inverse_determinant;
+ let m22 = (a * i - c * g) * inverse_determinant;
+ let m32 = (c * d - a * f) * inverse_determinant;
+ let m13 = (d * h - e * g) * inverse_determinant;
+ let m23 = (b * g - a * h) * inverse_determinant;
+ let m33 = (a * e - b * d) * inverse_determinant;
+ let inverse = Self {
+ m11,
+ m12,
+ m13,
+ m14: 0.0,
+ m21,
+ m22,
+ m23,
+ m24: 0.0,
+ m31,
+ m32,
+ m33,
+ m34: 0.0,
+ m41: -(m11 * self.m41 + m21 * self.m42 + m31 * self.m43),
+ m42: -(m12 * self.m41 + m22 * self.m42 + m32 * self.m43),
+ m43: -(m13 * self.m41 + m23 * self.m42 + m33 * self.m43),
+ m44: 1.0,
+ };
+ let values = [
+ inverse.m11,
+ inverse.m12,
+ inverse.m13,
+ inverse.m21,
+ inverse.m22,
+ inverse.m23,
+ inverse.m31,
+ inverse.m32,
+ inverse.m33,
+ inverse.m41,
+ inverse.m42,
+ inverse.m43,
+ ];
+
+ values
+ .iter()
+ .all(|value| value.is_finite())
+ .then_some(inverse)
+ }
+
pub fn is_2d(self) -> bool {
self.m13 == 0.0
&& self.m14 == 0.0