Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(canvas): preserve isolated realms for TextMetrics

ldm0cdf84d5dcfb4
diff --git a/moli-renderer-v8/src/native_bridge/node.rs b/moli-renderer-v8/src/native_bridge/node.rs
index bf741802c..0e56c09c7 100644
--- a/moli-renderer-v8/src/native_bridge/node.rs
+++ b/moli-renderer-v8/src/native_bridge/node.rs
@@ -1344,12 +1344,15 @@ pub(crate) fn node_relevant_context<'s>(
scope: &mut v8::PinScope<'s, '_>,
object: v8::Local<'s, v8::Object>,
) -> Option<v8::Local<'s, v8::Context>> {
- node_runtime_and_handle_from_object(scope, object)
- .ok()
- .and_then(|(runtime_ptr, handle)| {
- node_owner_document_relevant_context(scope, runtime_ptr, handle)
- })
- .or_else(|| object.get_creation_context(scope))
+ // Wrappers are created in their owning realm. In particular an isolated
+ // world's Document must not resolve back to the frame's default context.
+ object.get_creation_context(scope).or_else(|| {
+ node_runtime_and_handle_from_object(scope, object)
+ .ok()
+ .and_then(|(runtime_ptr, handle)| {
+ node_owner_document_relevant_context(scope, runtime_ptr, handle)
+ })
+ })
}
pub(super) fn node_arg_handle(
diff --git a/moli-renderer-v8/src/script_vm/tests/canvas_webgl.rs b/moli-renderer-v8/src/script_vm/tests/canvas_webgl.rs
index 3464ef2ed..a515aed40 100644
--- a/moli-renderer-v8/src/script_vm/tests/canvas_webgl.rs
+++ b/moli-renderer-v8/src/script_vm/tests/canvas_webgl.rs
@@ -659,6 +659,66 @@ fn canvas_text_metrics_uses_the_context_realm() {
assert_eq!(result, "true|true|true|true");
}
+#[test]
+fn canvas_text_metrics_keep_the_isolated_world_realm() {
+ let mut vm = new_parsed_test_vm(
+ "https://text-metrics-isolated.test/",
+ "<!doctype html><html><body></body></html>",
+ );
+ vm.eval(
+ r#"
+ globalThis.frame = document.body.appendChild(document.createElement("iframe"));
+ frame.contentDocument.body.innerHTML = "<canvas id='shared-canvas'></canvas>";
+ "#,
+ )
+ .expect("child canvas should initialize");
+ let child_context_id =
+ materialize_single_child_default_realm_for_test(&mut vm, "isolated canvas setup");
+ let frame_id = vm
+ .child_default_frame_id_for_execution_context_id(child_context_id)
+ .expect("child frame id should exist");
+ let isolated_context_id = vm
+ .create_isolated_world_for_frame(&frame_id, "canvas-utility", false)
+ .expect("isolated world should initialize");
+ assert_eq!(
+ vm.eval_in_isolated_context(
+ isolated_context_id,
+ r#"
+ (() => {
+ TextMetrics.prototype.isolatedMarker = true;
+ const canvases = [
+ document.getElementById("shared-canvas"),
+ document.createElement("canvas"),
+ new OffscreenCanvas(10, 10),
+ ];
+ return canvases.every(canvas => {
+ const metrics = canvas.getContext("2d").measureText("Hello");
+ return Object.getPrototypeOf(metrics) === TextMetrics.prototype &&
+ metrics.isolatedMarker === true && metrics.width > 0;
+ });
+ })()
+ "#,
+ )
+ .expect("TextMetrics should keep the canvas wrapper's isolated realm"),
+ "true"
+ );
+ assert_eq!(
+ vm.eval(
+ r#"
+ (() => {
+ const child = frame.contentWindow;
+ const canvas = child.document.getElementById("shared-canvas");
+ const metrics = canvas.getContext("2d").measureText("Hello");
+ return Object.getPrototypeOf(metrics) === child.TextMetrics.prototype &&
+ metrics.isolatedMarker === undefined && metrics.width > 0;
+ })()
+ "#,
+ )
+ .expect("default-world TextMetrics should keep separate prototypes"),
+ "true"
+ );
+}
+
#[test]
fn html_canvas_linear_gradient_surface_is_available_for_fingerprinting_scripts() {
let mut vm = new_storage_test_vm("https://canvas-linear-gradient-surface.test/");