Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(webidl): validate XMLSerializer receivers through native bindings

ldm0d41d8bdb627b
diff --git a/moli-renderer-v8/src/context_bootstrap/media_file_template.rs b/moli-renderer-v8/src/context_bootstrap/media_file_template.rs
index 3421c2349..5d78b0451 100644
--- a/moli-renderer-v8/src/context_bootstrap/media_file_template.rs
+++ b/moli-renderer-v8/src/context_bootstrap/media_file_template.rs
@@ -125,7 +125,7 @@ struct FileReaderTemplateMethodsDeclaration {
}
#[derive(WebApiFunctionTemplate)]
-#[webapi(interface = web_api_interfaces::XMLSerializer, enumerable)]
+#[webapi(interface = web_api_interfaces::XMLSerializer, enumerable, receiver)]
struct XmlSerializerTemplateMethodsDeclaration {
#[webapi(
method,
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index 987ec67a4..163e7b94f 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2344,3 +2344,5 @@ mod file_reader_handlers;
mod streams_sync_protocol;
mod performance_user_timing;
+
+mod xml_serializer_receivers;
diff --git a/moli-renderer-v8/src/script_vm/tests/xml_serializer_receivers.rs b/moli-renderer-v8/src/script_vm/tests/xml_serializer_receivers.rs
new file mode 100644
index 000000000..77747199c
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/xml_serializer_receivers.rs
@@ -0,0 +1,33 @@
+use super::*;
+
+#[test]
+fn xml_serializer_native_receivers_reject_forgery_and_author_proxies_in_the_callee_realm() {
+ let mut vm = new_storage_html_test_vm("https://xml-serializer-receivers.test/");
+ let result = vm.eval(r#"
+ document.body.innerHTML = '<iframe></iframe>';
+ const other = document.querySelector('iframe').contentWindow;
+ const serializer = new XMLSerializer();
+ const node = document.createElement('div');
+ let traps = 0;
+ const author = new Proxy(serializer, {
+ get() { traps++; throw new Error('unexpected get trap'); },
+ getPrototypeOf() { traps++; throw new Error('unexpected prototype trap'); }
+ });
+ const revoked = Proxy.revocable(serializer, {}); revoked.revoke();
+ for (const realm of [window, other]) {
+ const serialize = realm.XMLSerializer.prototype.serializeToString;
+ if (serialize.call(serializer, node) !== serialize.call(new realm.XMLSerializer(), node))
+ throw new Error('genuine cross-realm serializer');
+ for (const receiver of [null, undefined, {}, Object.create(serializer),
+ Object.create(XMLSerializer.prototype), author, revoked.proxy]) {
+ let error;
+ try { serialize.call(receiver, node); } catch (caught) { error = caught; }
+ if (!error || Object.getPrototypeOf(error) !== realm.TypeError.prototype)
+ throw new Error('invalid receiver must throw the callee TypeError');
+ }
+ }
+ if (traps !== 0) throw new Error('receiver validation invoked an author Proxy trap');
+ 'ok';
+ "#).unwrap();
+ assert_eq!(result, "ok");
+}