Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(webidl): validate MessageChannel getter receivers
ldm0d56bbd7c2870
diff --git a/moli-renderer-v8/src/context_bootstrap/message_ports/state.rs b/moli-renderer-v8/src/context_bootstrap/message_ports/state.rsindex d8cbcc576..f287b3a5b 100644--- a/moli-renderer-v8/src/context_bootstrap/message_ports/state.rs+++ b/moli-renderer-v8/src/context_bootstrap/message_ports/state.rs@@ -191,7 +191,7 @@ struct MessagePortPrototypeDeclaration {}#[derive(WebApiFunctionTemplate)]-#[webapi(interface = web_api_interfaces::MessageChannel)]+#[webapi(interface = web_api_interfaces::MessageChannel, receiver)]struct MessageChannelPrototypeDeclaration {#[webapi(accessor_property,diff --git a/moli-renderer-v8/src/script_vm/tests/browser_api/message_channel.rs b/moli-renderer-v8/src/script_vm/tests/browser_api/message_channel.rsnew file mode 100644index 000000000..be9e47278--- /dev/null+++ b/moli-renderer-v8/src/script_vm/tests/browser_api/message_channel.rs@@ -0,0 +1,139 @@+use super::service_worker_drain::drain_service_worker_test_turn;+use super::*;++const RECEIVER_PROBE: &str = r#"+function messageChannelReceiverProbe(realms = [globalThis]) {+ const failures = [], records = [];+ const check = (value, label) => { if (!value) failures.push(label); };+ for (const realm of realms) {+ class Subchannel extends realm.MessageChannel {}+ for (const channel of [new realm.MessageChannel(), new Subchannel(),+ Reflect.construct(realm.MessageChannel, [], function Custom() {})]) {+ const getters = ['port1', 'port2'].map(name =>+ Object.getOwnPropertyDescriptor(realm.MessageChannel.prototype, name).get);+ const ports = getters.map(getter => getter.call(channel));+ check(ports[0] !== ports[1], 'distinct ports');+ check(ports.every(port => port instanceof realm.MessagePort), 'port creation realm');+ records.push({channel, ports});+ }+ }+ const real = records[0].channel;+ const revoked = Proxy.revocable(real, {}); revoked.revoke();+ let traps = 0, invalid = 0, valid = 0;+ const trap = () => { traps++; throw new Error('receiver inspection reached author code'); };+ const receivers = [undefined, null, false, 0, 0n, '', Symbol(), {},+ MessageChannel.prototype, Object.create(MessageChannel.prototype), Object.create(real),+ new Proxy(real, {}), revoked.proxy,+ new Proxy(real, {get: trap, getPrototypeOf: trap, has: trap}),+ records[0].ports[0], new EventTarget()];+ for (const [realmIndex, realm] of realms.entries()) {+ for (const name of ['port1', 'port2']) {+ const getter = Object.getOwnPropertyDescriptor(realm.MessageChannel.prototype, name).get;+ for (const [index, receiver] of receivers.entries()) {+ invalid++;+ const label = realmIndex + ':' + name + ':' + index;+ try { getter.call(receiver); failures.push('accepted ' + label); }+ catch (error) {+ check(Object.getPrototypeOf(error) === realm.TypeError.prototype, 'error realm ' + label);+ }+ }+ }+ }+ for (const phase of ['original', 'null-prototype', 'foreign-prototype']) {+ for (const record of records) {+ if (phase === 'null-prototype') Object.setPrototypeOf(record.channel, null);+ if (phase === 'foreign-prototype') {+ Object.setPrototypeOf(record.channel, realms[realms.length - 1].Object.prototype);+ Object.freeze(record.channel);+ }+ for (const realm of realms) {+ for (const [index, name] of ['port1', 'port2'].entries()) {+ const getter = Object.getOwnPropertyDescriptor(realm.MessageChannel.prototype, name).get;+ valid++;+ check(getter.call(record.channel) === record.ports[index], phase + ' ' + name);+ check(getter.call(record.channel) === record.ports[index], 'same object ' + name);+ }+ }+ }+ }+ for (const record of records) for (const port of record.ports) port.close();+ return {failures, invalid, valid, traps};+}+"#;++fn assert_receiver_probe(value: &str, realms: usize) {+ let value: serde_json::Value = serde_json::from_str(value).unwrap();+ assert_eq!(value["failures"], serde_json::json!([]), "{value}");+ assert_eq!(value["invalid"], 32 * realms, "{value}");+ assert_eq!(value["valid"], 18 * realms * realms, "{value}");+ assert_eq!(value["traps"], 0, "{value}");+}++#[test]+fn message_channel_getters_use_native_brands_and_callee_realm_errors() {+ let mut vm = new_parsed_test_vm(+ "https://message-channel-brands.test/",+ "<!doctype html><body>",+ );+ let value = vm+ .eval(&format!(+ r#"{RECEIVER_PROBE}+const frame = document.createElement('iframe');+document.body.appendChild(frame);+const result = messageChannelReceiverProbe([window, frame.contentWindow]);+frame.remove();+JSON.stringify(result)+"#+ ))+ .unwrap();+ assert_receiver_probe(&value, 2);+}++#[tokio::test]+async fn message_channel_worker_getters_reject_unbranded_receivers() {+ for shared in [false, true] {+ let loader = ResourceRequestClient::new(&moli_fetch::FetchConfig::default()).unwrap();+ let (mut vm, browser_context_runtime) =+ new_service_worker_page_test_vm_with_loader_and_browser_context_runtime(+ "https://message-channel-worker.test/",+ &loader,+ );+ let (constructor, endpoint, cleanup, source) = if shared {+ (+ "SharedWorker",+ "worker.port",+ "port.close()",+ format!(+ "{RECEIVER_PROBE}\nonconnect=e=>e.ports[0].postMessage(messageChannelReceiverProbe());"+ ),+ )+ } else {+ (+ "Worker",+ "worker",+ "worker.terminate()",+ format!("{RECEIVER_PROBE}\npostMessage(messageChannelReceiverProbe());"),+ )+ };+ let source = serde_json::to_string(&source).unwrap();+ vm.eval(&format!(+ r#"+const url = URL.createObjectURL(new Blob([{source}], {{type:'text/javascript'}}));+const worker = new {constructor}(url), port = {endpoint};+port.onmessage = e => {{ globalThis.channelResult=e.data; {cleanup}; URL.revokeObjectURL(url); }};+worker.onerror = e => {{ globalThis.channelResult=String(e.message); }};+"#+ ))+ .unwrap();+ tokio::time::timeout(std::time::Duration::from_secs(10), async {+ while vm.eval("globalThis.channelResult !== undefined").unwrap() != "true" {+ browser_context_runtime.drain_shared_worker_service_lane();+ drain_service_worker_test_turn(&mut vm, &browser_context_runtime, &loader).await;+ }+ })+ .await+ .unwrap_or_else(|_| panic!("shared={shared}: MessageChannel probe did not settle"));+ let value = vm.eval("JSON.stringify(globalThis.channelResult)").unwrap();+ assert_receiver_probe(&value, 1);+ }+}diff --git a/moli-renderer-v8/src/script_vm/tests/browser_api/mod.rs b/moli-renderer-v8/src/script_vm/tests/browser_api/mod.rsindex ae3505c82..f8940f565 100644--- a/moli-renderer-v8/src/script_vm/tests/browser_api/mod.rs+++ b/moli-renderer-v8/src/script_vm/tests/browser_api/mod.rs@@ -23,6 +23,7 @@ mod idle_detection;mod images;mod media;mod media_devices;+mod message_channel;mod misc;mod navigation;mod performance;