Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(v8): fix undefined image url

SpringCoreld58d26e8fb67
diff --git a/moli-renderer-v8/src/native_bridge/element/images/src.rs b/moli-renderer-v8/src/native_bridge/element/images/src.rs
index 1bb07ee48..3ba4c69ff 100644
--- a/moli-renderer-v8/src/native_bridge/element/images/src.rs
+++ b/moli-renderer-v8/src/native_bridge/element/images/src.rs
@@ -287,7 +287,7 @@ fn image_selected_source_candidate(
.attribute("href")
.or_else(|| element.attribute("xlink:href"))
.map(str::trim)
- .filter(|href| !href.is_empty())
+ .filter(|href| image_source_is_fetchable(href))
.map(|href| SelectedImageSource {
url: href.to_owned(),
density: 1.0,
@@ -313,7 +313,7 @@ fn image_selected_source_candidate(
element
.attribute("src")
.map(str::trim)
- .filter(|src| !src.is_empty())
+ .filter(|src| image_source_is_fetchable(src))
.map(|src| SelectedImageSource {
url: src.to_owned(),
density: 1.0,
@@ -701,6 +701,7 @@ fn selected_srcset_candidate(
viewport: ImageSelectionViewport,
) -> Option<SelectedImageSource> {
let mut candidates = parse_srcset_candidates(srcset);
+ candidates.retain(|candidate| image_source_is_fetchable(&candidate.url));
if candidates.is_empty() {
return None;
}
@@ -751,6 +752,10 @@ fn selected_srcset_candidate(
})
}
+fn image_source_is_fetchable(source: &str) -> bool {
+ !source.is_empty() && source != "undefined"
+}
+
#[derive(Clone, Copy, Debug)]
struct ImageSelectionViewport {
width: f64,
@@ -1282,6 +1287,18 @@ mod tests {
assert_eq!(select("data:,a 1w 1h", None).as_deref(), Some("data:,a"));
}
+ #[test]
+ fn image_selection_drops_undefined_template_binding_sources() {
+ assert_eq!(select("undefined", None), None);
+ assert_eq!(select("undefined 1x", None), None);
+ assert_eq!(
+ select("undefined 1x, actual.png 2x", None).as_deref(),
+ Some("actual.png")
+ );
+ assert!(!image_source_is_fetchable("undefined"));
+ assert!(image_source_is_fetchable("undefined.png"));
+ }
+
#[test]
fn srcset_parser_selects_by_density_and_width() {
assert_eq!(