Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(cdp): explain layout requirements for capture (#181)

Donough Liudc0571da435a
diff --git a/moli-cdp-smoke/moli_cdp_smoke/groups/layout_screenshot.py b/moli-cdp-smoke/moli_cdp_smoke/groups/layout_screenshot.py
index cb50d0df3..d56b1e1ec 100644
--- a/moli-cdp-smoke/moli_cdp_smoke/groups/layout_screenshot.py
+++ b/moli-cdp-smoke/moli_cdp_smoke/groups/layout_screenshot.py
@@ -13,7 +13,8 @@ from ..serve import start_moli_serve, stop_moli_serve, wait_for_moli_endpoint
SCREENSHOT_UNSUPPORTED = (
- "Page.captureScreenshot is not supported: renderer screenshots are not implemented."
+ "Page.captureScreenshot is not supported: renderer layout is disabled; "
+ "start Moli with --layout."
)
SCREENCAST_UNSUPPORTED = (
"Page.startScreencast is not supported: renderer layout is disabled."
diff --git a/moli-protocol-server/src/protocol_server/tests/screenshot.rs b/moli-protocol-server/src/protocol_server/tests/screenshot.rs
index 08c5b0aa0..4d6e9434c 100644
--- a/moli-protocol-server/src/protocol_server/tests/screenshot.rs
+++ b/moli-protocol-server/src/protocol_server/tests/screenshot.rs
@@ -337,7 +337,9 @@ async fn websocket_cdp_capture_screenshot_preserves_default_mock_boundary() {
assert_eq!(response["error"]["code"], json!(-32000));
assert_eq!(
response["error"]["message"],
- json!("Page.captureScreenshot is not supported: renderer screenshots are not implemented.")
+ json!(
+ "Page.captureScreenshot is not supported: renderer layout is disabled; start Moli with --layout."
+ )
);
assert!(response.get("result").is_none());
diff --git a/moli-protocol/src/conn/dispatch_tests.rs b/moli-protocol/src/conn/dispatch_tests.rs
index 4b4817b93..ae65412c7 100644
--- a/moli-protocol/src/conn/dispatch_tests.rs
+++ b/moli-protocol/src/conn/dispatch_tests.rs
@@ -7136,7 +7136,7 @@ fn command_dispatch_preserves_page_screenshot_unsupported_for_mock_layout() {
"id": 42,
"error": {
"code": -32000,
- "message": "Page.captureScreenshot is not supported: renderer screenshots are not implemented."
+ "message": "Page.captureScreenshot is not supported: renderer layout is disabled; start Moli with --layout."
}
})]
);
@@ -7188,7 +7188,7 @@ fn command_dispatch_completes_additional_page_sync_commands_without_legacy_fallb
"id": 413,
"error": {
"code": -32000,
- "message": "Page.printToPDF is not supported: renderer layout is disabled."
+ "message": "Page.printToPDF is not supported: renderer layout is disabled; start Moli with --layout."
}
})]
);
diff --git a/moli-protocol/src/domains/page.rs b/moli-protocol/src/domains/page.rs
index a4566b8e8..36ee5adcd 100644
--- a/moli-protocol/src/domains/page.rs
+++ b/moli-protocol/src/domains/page.rs
@@ -120,10 +120,11 @@ const DEFAULT_PRINT_PAGE_WIDTH_INCHES: f64 = 8.5;
const DEFAULT_PRINT_PAGE_HEIGHT_INCHES: f64 = 11.0;
const CAPTURE_SCREENSHOT_UNSUPPORTED_MESSAGE: &str =
"Page.captureScreenshot is not supported: renderer screenshots are not implemented.";
+const CAPTURE_SCREENSHOT_LAYOUT_DISABLED_MESSAGE: &str = "Page.captureScreenshot is not supported: renderer layout is disabled; start Moli with --layout.";
const START_SCREENCAST_LAYOUT_DISABLED_MESSAGE: &str =
"Page.startScreencast is not supported: renderer layout is disabled.";
const PRINT_TO_PDF_LAYOUT_DISABLED_MESSAGE: &str =
- "Page.printToPDF is not supported: renderer layout is disabled.";
+ "Page.printToPDF is not supported: renderer layout is disabled; start Moli with --layout.";
const PRINT_TO_PDF_UNSUPPORTED_MESSAGE: &str =
"Page.printToPDF is not supported: PDF generation is not implemented.";
@@ -6669,7 +6670,7 @@ fn start_devtools_capture_screenshot_command(
if conn.layout_policy() == moli_core::LayoutPolicy::Mock {
return PageCommandTaskStep::Complete(CommandOutputPlan::error(
-32000,
- CAPTURE_SCREENSHOT_UNSUPPORTED_MESSAGE,
+ CAPTURE_SCREENSHOT_LAYOUT_DISABLED_MESSAGE,
));
}
@@ -7331,7 +7332,9 @@ mod protocol_neutral_tests {
assert_eq!(out[0]["error"]["code"], json!(-32000));
assert_eq!(
out[0]["error"]["message"],
- json!("Page.printToPDF is not supported: renderer layout is disabled.")
+ json!(
+ "Page.printToPDF is not supported: renderer layout is disabled; start Moli with --layout."
+ )
);
}
@@ -7803,7 +7806,7 @@ async fn complete_pending_page_command_inner(
)
}
Ok(RendererCaptureScreenshotReply::LayoutDisabled) => {
- CommandOutputPlan::error(-32000, CAPTURE_SCREENSHOT_UNSUPPORTED_MESSAGE)
+ CommandOutputPlan::error(-32000, CAPTURE_SCREENSHOT_LAYOUT_DISABLED_MESSAGE)
}
Ok(RendererCaptureScreenshotReply::NoDocument) => {
CommandOutputPlan::error(-32000, "NoDocumentLoaded")