Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(renderer): construct intersection entries in the callback Realm
ldm0dd0fedcd2a08
diff --git a/moli-renderer-v8/src/observer_runtime/mod.rs b/moli-renderer-v8/src/observer_runtime/mod.rsindex e586b5d11..ab14069f5 100644--- a/moli-renderer-v8/src/observer_runtime/mod.rs+++ b/moli-renderer-v8/src/observer_runtime/mod.rs@@ -872,8 +872,16 @@ fn invoke_intersection_deliveries<'s>(if !delivery.callback.is_current(scope) {continue;}- let entries =- build_intersection_entries_array(scope, host_ptr, &delivery.options, &delivery.entries);+ let Some(callback_context) = delivery.callback.relevant_context(scope) else {+ continue;+ };+ // Web IDL argument conversion uses the callback's relevant Realm,+ // which can differ from the observer's creation Realm. Enter it before+ // projecting native targets and binding the entry/rect/array wrappers.+ let entries = {+ let scope = &mut v8::ContextScope::new(scope, callback_context);+ build_intersection_entries_array(scope, host_ptr, &delivery.options, &delivery.entries)+ };let observer_value: v8::Local<'_, v8::Value> = delivery.observer.into();delivery.callback.invoke_and_report(scope,diff --git a/moli-renderer-v8/src/script_vm/tests/observer_callbacks.rs b/moli-renderer-v8/src/script_vm/tests/observer_callbacks.rsindex e63a9ca13..a84806f30 100644--- a/moli-renderer-v8/src/script_vm/tests/observer_callbacks.rs+++ b/moli-renderer-v8/src/script_vm/tests/observer_callbacks.rs@@ -255,6 +255,136 @@ JSON.stringify({);}+#[tokio::test(flavor = "current_thread")]+async fn intersection_entries_use_the_borrowed_callback_realm_in_both_layout_modes() {+ for policy in [+ moli_page_types::LayoutPolicy::Mock,+ moli_page_types::LayoutPolicy::OnDemand,+ ] {+ let mut vm = observer_callback_test_vm("https://intersection-entry-realm.test/");+ vm.set_layout_policy(policy);+ vm.eval(+ r#"+ globalThis.rows = [];+ globalThis.child = __observerCallbackFrame.contentWindow;+ const target = document.body.appendChild(document.createElement('div'));+ target.id = 'intersection-target';+ target.style.cssText = 'width:100px;height:20px;padding:0;border:0';+ "#,+ )+ .unwrap();+ let before_ready = vm.layout_pass_observability_for_test().1;+ if policy == moli_page_types::LayoutPolicy::OnDemand {+ // Legacy observers sample an already-published tree. Establish the+ // initial sample after fixture setup, before observer registration.+ assert_eq!(+ vm.eval(+ "document.getElementById('intersection-target').getBoundingClientRect().width"+ )+ .unwrap(),+ "100"+ );+ }+ let builds = vm.layout_pass_observability_for_test().1;+ assert_eq!(+ builds,+ before_ready + u64::from(policy == moli_page_types::LayoutPolicy::OnDemand),+ "readiness publishes one initial real layout and none for Mock: {policy:?}"+ );+ vm.eval(+ r#"+ globalThis.rootIO = new IntersectionObserver(child.Function('entries', 'observer', `+ const entry = entries[0];+ parent.rows.push({+ callbackRealm: window === parent.child,+ observerRealm: Object.getPrototypeOf(observer) === parent.IntersectionObserver.prototype,+ receiver: this === observer && observer === parent.rootIO,+ arrayRealm: Object.getPrototypeOf(entries) === Array.prototype,+ entryRealm: Object.getPrototypeOf(entry) === IntersectionObserverEntry.prototype,+ rectRealm: [entry.boundingClientRect, entry.intersectionRect, entry.rootBounds].every(+ rect => rect !== null && DOMRectReadOnly.prototype.isPrototypeOf(rect)),+ target: entry.target === parent.document.getElementById('intersection-target'),+ count: entries.length,+ argc: arguments.length+ });+ parent.entryWidth = entry.boundingClientRect.width;+ `));+ rootIO.observe(target);+ "#,+ )+ .unwrap();+ assert_eq!(+ vm.eval("JSON.stringify(rows)").unwrap(),+ r#"[{"callbackRealm":true,"observerRealm":true,"receiver":true,"arrayRealm":true,"entryRealm":true,"rectRealm":true,"target":true,"count":1,"argc":2}]"#,+ "{policy:?}"+ );+ if policy == moli_page_types::LayoutPolicy::OnDemand {+ assert_eq!(vm.eval("entryWidth").unwrap(), "100");+ }+ assert_eq!(+ vm.layout_pass_observability_for_test().1,+ builds,+ "observer registration, delivery and record reads must reuse the initial sample: {policy:?}"+ );+ }+}++#[tokio::test(flavor = "current_thread")]+async fn intersection_entries_project_targets_into_the_isolated_callback_world() {+ for policy in [+ moli_page_types::LayoutPolicy::Mock,+ moli_page_types::LayoutPolicy::OnDemand,+ ] {+ let mut vm = new_storage_test_vm("https://intersection-isolated-world.test/");+ vm.set_layout_policy(policy);+ vm.eval(+ r#"+ const root = document.documentElement || document.appendChild(document.createElement('html'));+ const body = document.body || root.appendChild(document.createElement('body'));+ const target = body.appendChild(document.createElement('div'));+ target.id = 'intersection-target';+ target.style.cssText = 'width:100px;height:20px;padding:0;border:0';+ "#,+ )+ .unwrap();+ let isolated = vm+ .create_isolated_world("intersection-entry-realm", false)+ .unwrap();+ vm.eval_in_isolated_context(+ isolated,+ r#"+ globalThis.rows = [];+ globalThis.observer = new IntersectionObserver(function(entries, observer) {+ const entry = entries[0];+ rows.push([+ this === observer && observer === globalThis.observer,+ Object.getPrototypeOf(entries) === Array.prototype,+ Object.getPrototypeOf(entry) === IntersectionObserverEntry.prototype,+ [entry.boundingClientRect, entry.intersectionRect, entry.rootBounds].every(+ rect => rect !== null && DOMRectReadOnly.prototype.isPrototypeOf(rect)),+ entry.target === document.getElementById('intersection-target'),+ HTMLDivElement.prototype.isPrototypeOf(entry.target),+ entries.length === 1 && arguments.length === 2+ ]);+ });+ observer.observe(document.getElementById('intersection-target'));+ "#,+ )+ .unwrap();+ assert_eq!(+ vm.eval_in_isolated_context(isolated, "JSON.stringify(rows)")+ .unwrap(),+ "[[true,true,true,true,true,true,true]]",+ "{policy:?}"+ );+ vm.destroy_isolated_world_context(isolated);+ assert_eq!(+ vm.eval("'default-realm-still-live'").unwrap(),+ "default-realm-still-live"+ );+ }+}+#[test]fn observer_callback_exceptions_are_reported_to_the_callback_relevant_window() {let mut vm = observer_callback_test_vm("https://observer-callback-exception-realm.test/");