Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(selection): validate range membership with native DOM ownership

ldm0fa1bf1d3beb9
diff --git a/moli-dom/src/native/host/document.rs b/moli-dom/src/native/host/document.rs
index 1d9301c61..26deabe90 100644
--- a/moli-dom/src/native/host/document.rs
+++ b/moli-dom/src/native/host/document.rs
@@ -511,6 +511,27 @@ impl DomHost {
.is_some_and(|node| node.flags().connected())
}
+ pub fn is_connected_to_document(&self, handle: DomHandle) -> bool {
+ let Some(mut root) = self.root_node_handle(handle) else {
+ return false;
+ };
+ loop {
+ if self.node(root).is_some_and(Node::is_document) {
+ return true;
+ }
+ if !self.is_shadow_root(root) {
+ return false;
+ }
+ let Some(host) = self.shadow_root_host(root) else {
+ return false;
+ };
+ let Some(outer_root) = self.root_node_handle(host) else {
+ return false;
+ };
+ root = outer_root;
+ }
+ }
+
pub fn active_element_handle(&self) -> Option<DomHandle> {
self.active_element.get().filter(|handle| {
self.node(*handle)
diff --git a/moli-renderer-v8/src/context_bootstrap/selection_callbacks/ranges.rs b/moli-renderer-v8/src/context_bootstrap/selection_callbacks/ranges.rs
index 97d5a3021..cde00b088 100644
--- a/moli-renderer-v8/src/context_bootstrap/selection_callbacks/ranges.rs
+++ b/moli-renderer-v8/src/context_bootstrap/selection_callbacks/ranges.rs
@@ -107,32 +107,22 @@ fn range_belongs_to_current_document<'s>(
else {
return true;
};
- let start_root = selection_tree_root(scope, start_node);
- let end_root = selection_tree_root(scope, end_node);
- let document_value: v8::Local<'s, v8::Value> = document.into();
- start_root.strict_equals(end_root.into()) && start_root.strict_equals(document_value)
-}
-
-fn selection_tree_root<'s>(
- scope: &mut v8::PinScope<'s, '_>,
- node: v8::Local<'s, v8::Object>,
-) -> v8::Local<'s, v8::Object> {
- let mut current = node;
- loop {
- if let Some(parent) = object_property_as_object(scope, current, "parentNode")
- && !parent.strict_equals(current.into())
- {
- current = parent;
- continue;
- }
- if object_number_property(scope, current, "nodeType").unwrap_or(0.0) as u32 == 11
- && let Some(host) = object_property_as_object(scope, current, "host")
- {
- current = host;
- continue;
- }
- return current;
- }
+ let Some(host_ptr) = context_host_ptr_from_global_bridge(scope) else {
+ return false;
+ };
+ let Some(document) = callback_value_dom_handle(scope, document.into()) else {
+ return false;
+ };
+ // Connectivity and ownership are native relationships. Author properties
+ // named parentNode, nodeType or host must not change Selection membership
+ // (or run script while checking an associated Range).
+ let dom = unsafe { &*host_ptr }.dom_host();
+ [start_node, end_node].into_iter().all(|node| {
+ callback_value_dom_handle(scope, node.into()).is_some_and(|handle| {
+ dom.is_connected_to_document(handle)
+ && (handle == document || dom.owner_document_handle(handle) == Some(document))
+ })
+ })
}
pub(in crate::context_bootstrap) fn selection_get_range_at_callback<'s>(
diff --git a/moli-renderer-v8/src/script_vm/tests/browser_api/events_selection_storage/postmessage_selection_and_errors.rs b/moli-renderer-v8/src/script_vm/tests/browser_api/events_selection_storage/postmessage_selection_and_errors.rs
index 32ed22c5e..297274bd4 100644
--- a/moli-renderer-v8/src/script_vm/tests/browser_api/events_selection_storage/postmessage_selection_and_errors.rs
+++ b/moli-renderer-v8/src/script_vm/tests/browser_api/events_selection_storage/postmessage_selection_and_errors.rs
@@ -1890,3 +1890,15 @@ fn report_error_uses_the_receiver_realm_without_observing_exception_getters() {
r#"{"topEvents":0,"eventCount":2,"exactErrors":[true,true],"receiverRealm":true,"messagesAreNonEmpty":true,"getterCalls":0,"missingArgumentError":"TypeError","detachedCallCompleted":true}"#,
);
}
+
+#[test]
+fn selection_range_membership_uses_native_document_relationships() {
+ let mut vm = new_storage_test_vm("https://selection-native-membership.test/");
+ assert_eq!(
+ vm.eval(include_str!(
+ "../../../../../tests/fixtures/selection-native-membership.js"
+ ))
+ .expect("selection membership should ignore author relationship properties"),
+ ""
+ );
+}
diff --git a/moli-renderer-v8/tests/fixtures/selection-native-membership.js b/moli-renderer-v8/tests/fixtures/selection-native-membership.js
new file mode 100644
index 000000000..ab9e2f297
--- /dev/null
+++ b/moli-renderer-v8/tests/fixtures/selection-native-membership.js
@@ -0,0 +1,55 @@
+(() => {
+ const root = document.documentElement || document.appendChild(document.createElement('html'));
+ const body = document.body || root.appendChild(document.createElement('body'));
+ const fixture = body.appendChild(document.createElement('div'));
+ const selection = getSelection();
+ const failures = [];
+ const check = (condition, label) => { if (!condition) failures.push(label); };
+ let calls = 0;
+ const forbidden = () => { calls++; throw new Error('author relationship getter entered'); };
+ for (const mode of ['light', 'open', 'closed']) {
+ const host = fixture.appendChild(document.createElement('div'));
+ const parent = mode === 'light' ? host : host.attachShadow({mode});
+ const text = parent.appendChild(document.createTextNode('selected'));
+ const range = document.createRange();
+ range.setStart(text, 1);
+ range.setEnd(text, 4);
+ selection.removeAllRanges();
+ const nodes = [...new Set([host, parent, text])];
+ try {
+ for (const node of nodes) for (const key of ['parentNode', 'nodeType', 'host', 'ownerDocument']) {
+ Object.defineProperty(node, key, {configurable: true, get: forbidden});
+ }
+ selection.addRange(range);
+ check(selection.rangeCount === 1, mode + ': connected range accepted');
+ if (selection.rangeCount) check(selection.getRangeAt(0) === range, mode + ': associated range returned');
+ } catch (error) {
+ failures.push(mode + ': ' + error.name);
+ } finally {
+ for (const node of nodes) for (const key of ['parentNode', 'nodeType', 'host', 'ownerDocument']) delete node[key];
+ }
+ check(calls === 0, mode + ': no author getters');
+ host.remove();
+ }
+ const frame = fixture.appendChild(document.createElement('iframe'));
+ const doc = frame.contentDocument;
+ const foreign = doc.body.appendChild(doc.createTextNode('foreign'));
+ const detached = document.createTextNode('detached');
+ for (const [label, node] of [['foreign', foreign], ['detached', detached]]) {
+ const range = document.createRange();
+ range.setStart(node, 0);
+ range.setEnd(node, 1);
+ selection.removeAllRanges();
+ try {
+ Object.defineProperty(node, 'parentNode', {configurable: true, value: document});
+ Object.defineProperty(node, 'ownerDocument', {configurable: true, value: document});
+ selection.addRange(range);
+ check(selection.rangeCount === 0, label + ': forged document relationship ignored');
+ } finally {
+ delete node.parentNode;
+ delete node.ownerDocument;
+ }
+ }
+ fixture.remove();
+ return failures.join('\n');
+})()