Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust
Rust ai-agentsai-toolsbrowserbrowser-automationcloud-browserheadlessheadless-browserkitesurfplaywrightpuppeteerrustservoweb-crawlerweb-crawlingweb-scraperweb-scraping
fix(events): preserve rejection event object identity
ldm0fdda8a460da8
diff --git a/moli-renderer-v8/src/context_bootstrap/events/subclasses/data.rs b/moli-renderer-v8/src/context_bootstrap/events/subclasses/data.rsindex f0dcc8386..87cc937dc 100644--- a/moli-renderer-v8/src/context_bootstrap/events/subclasses/data.rs+++ b/moli-renderer-v8/src/context_bootstrap/events/subclasses/data.rs@@ -225,7 +225,7 @@ struct PromiseRejectionEventInitDeclaration<'scope> {#[webidl(prefix = "PromiseRejectionEventInit")]struct PromiseRejectionEventInitMembers<'s> {#[webidl(required)]- promise: v8::Local<'s, v8::Promise>,+ promise: v8::Local<'s, v8::Object>,#[webidl(converter = "raw")]reason: Option<v8::Local<'s, v8::Value>>,}diff --git a/moli-renderer-v8/src/script_vm/tests/browser_api/misc/extracted/events_errors.rs b/moli-renderer-v8/src/script_vm/tests/browser_api/misc/extracted/events_errors.rsindex b410a960a..43316d8c0 100644--- a/moli-renderer-v8/src/script_vm/tests/browser_api/misc/extracted/events_errors.rs+++ b/moli-renderer-v8/src/script_vm/tests/browser_api/misc/extracted/events_errors.rs@@ -59,6 +59,7 @@ fn promise_rejection_event_constructor_parses_required_promise_and_optional_reasr#"(() => {const promise = Promise.resolve("settled");+ Object.defineProperty(promise, "then", {get() {throw Error("promise is an object member");}});const omitted = new PromiseRejectionEvent("unhandledrejection", { promise });const explicitUndefined = new PromiseRejectionEvent("unhandledrejection", {promise,@@ -68,7 +69,20 @@ fn promise_rejection_event_constructor_parses_required_promise_and_optional_reaspromise,reason: null});- const wrapped = new PromiseRejectionEvent("unhandledrejection", { promise: 42 });+ const revoked = Proxy.revocable({}, {});+ revoked.revoke();+ const objects = [{get then() {throw Error("then must not be read");}}, [], () => {},+ new Proxy({}, {get() {throw Error("payload must not be read");}}), revoked.proxy];+ const objectIdentityPreserved = objects.every(value =>+ new PromiseRejectionEvent("unhandledrejection", {promise: value}).promise === value);+ const primitivesRejected = [undefined, null, false, 42, "promise", Symbol(), 1n].every(value => {+ try {+ new PromiseRejectionEvent("unhandledrejection", {promise: value});+ } catch (error) {+ return error instanceof TypeError;+ }+ return false;+ });let missingPromiseThrows = false;try {@@ -92,7 +106,8 @@ fn promise_rejection_event_constructor_parses_required_promise_and_optional_reasomitted.reason === undefined,explicitUndefined.reason === undefined,explicitNull.reason === null,- wrapped.promise instanceof Promise,+ objectIdentityPreserved,+ primitivesRejected,missingPromiseThrows,getterErrorPreserved].join("|");@@ -101,7 +116,7 @@ fn promise_rejection_event_constructor_parses_required_promise_and_optional_reas).expect("PromiseRejectionEvent constructor probe should evaluate");- assert_eq!(result, "true|true|true|true|true|true|true");+ assert_eq!(result, "true|true|true|true|true|true|true|true");}#[test]fn host_dispatched_events_ignore_user_replaced_event_constructor() {