Skip to content

armgit / moli

Public Imported from GitHub
0

Best headless browser for AI agents. Lite, Fast, High-Compatibility. Built in Rust

fix(audio): convert offline sample rates with WebIDL float

ldm0ff4bc3aa0471
diff --git a/moli-renderer-v8/src/context_bootstrap/web_audio_runtime.rs b/moli-renderer-v8/src/context_bootstrap/web_audio_runtime.rs
index 2137b13a3..234df22f2 100644
--- a/moli-renderer-v8/src/context_bootstrap/web_audio_runtime.rs
+++ b/moli-renderer-v8/src/context_bootstrap/web_audio_runtime.rs
@@ -346,7 +346,7 @@ struct OfflineAudioContextConstructorArgs {
#[webidl(required)]
length: f64,
#[webidl(required)]
- sample_rate: f64,
+ sample_rate: f32,
}
#[derive(webidl::WebIdlArgs)]
@@ -1297,7 +1297,7 @@ pub(in crate::context_bootstrap) fn offline_audio_context_constructor_callback<'
let channel_count = parsed.channel_count.trunc();
let length = parsed.length.trunc();
- let sample_rate = parsed.sample_rate;
+ let sample_rate = f64::from(parsed.sample_rate);
if !channel_count.is_finite()
|| !length.is_finite()
|| !sample_rate.is_finite()
diff --git a/moli-renderer-v8/src/script_vm/tests/mod.rs b/moli-renderer-v8/src/script_vm/tests/mod.rs
index c6babb382..306bc17f0 100644
--- a/moli-renderer-v8/src/script_vm/tests/mod.rs
+++ b/moli-renderer-v8/src/script_vm/tests/mod.rs
@@ -2155,6 +2155,7 @@ mod mouse_snapshot;
mod no_cors_header_fill;
mod observer_callbacks;
mod observer_receivers;
+mod offline_audio_float;
mod post_parse;
mod queue_microtask;
mod rendering_update;
diff --git a/moli-renderer-v8/src/script_vm/tests/offline_audio_float.rs b/moli-renderer-v8/src/script_vm/tests/offline_audio_float.rs
new file mode 100644
index 000000000..1382a0bdb
--- /dev/null
+++ b/moli-renderer-v8/src/script_vm/tests/offline_audio_float.rs
@@ -0,0 +1,51 @@
+use super::*;
+
+#[test]
+fn offline_audio_sample_rate_uses_restricted_float_conversion() {
+ let mut vm = new_storage_test_vm("https://offline-float.test/");
+ vm.exec(
+ r#"
+globalThis.__offlineFloatRenderChecks = [];
+(() => {
+ function assert(ok, message) { if (!ok) throw new Error(message); }
+ const iframe = document.createElement('iframe');
+ if (!document.documentElement) document.appendChild(document.createElement('html'));
+ if (!document.body) document.documentElement.appendChild(document.createElement('body'));
+ document.body.appendChild(iframe);
+ for (const realm of [window, iframe.contentWindow]) {
+ for (const value of [NaN, Infinity, -Infinity, 1e100, Symbol(), 1n]) {
+ let caught;
+ try { new realm.OfflineAudioContext(1, 16, value); } catch (error) { caught = error; }
+ assert(caught instanceof realm.TypeError, 'restricted float rejects ' + typeof value);
+ }
+ for (const value of [44100.1, 48000.01]) {
+ const context = new realm.OfflineAudioContext(1, 16, value);
+ assert(context.sampleRate === Math.fround(value), 'sample rate preserves Float32 rounding');
+ const rate = context.sampleRate;
+ context.startRendering().then(buffer => {
+ __offlineFloatRenderChecks.push(buffer.sampleRate === rate && buffer.length === 16);
+ });
+ }
+ let reads = 0;
+ const context = new realm.OfflineAudioContext(1, 16, {valueOf() { ++reads; return 44100.1; }});
+ assert(reads === 1 && context.sampleRate === Math.fround(44100.1), 'single numeric conversion');
+ const sentinel = new realm.Error('sample rate conversion');
+ let caught;
+ try { new realm.OfflineAudioContext(1, 16, {valueOf() { throw sentinel; }}); }
+ catch (error) { caught = error; }
+ assert(caught === sentinel, 'numeric exception identity');
+ }
+})()
+"#,
+ None,
+ )
+ .expect("offline sample rate conversion");
+ assert_eq!(
+ vm.eval(
+ "__offlineFloatRenderChecks.length === 4 && __offlineFloatRenderChecks.every(Boolean)"
+ )
+ .unwrap(),
+ "true",
+ "rendered buffers retain the converted rate in both realms"
+ );
+}