Skip to content

An AI-powered search engine with a generative UI

fix(feedback): send Langfuse score once per feedback action (#925)

Yoshiki Miura2b2fafd15ab1
diff --git a/app/api/feedback/__tests__/route.test.ts b/app/api/feedback/__tests__/route.test.ts
index f0211cc3..89573ea5 100644
--- a/app/api/feedback/__tests__/route.test.ts
+++ b/app/api/feedback/__tests__/route.test.ts
@@ -90,6 +90,7 @@ describe('Feedback API Route', () => {
expect(response.status).toBe(200)
expect(text).toBe('Feedback recorded successfully')
+ expect(mockScoreCreate).toHaveBeenCalledTimes(1)
expect(mockScoreCreate).toHaveBeenCalledWith({
traceId: 'test-trace-id',
name: 'user_feedback',
diff --git a/lib/actions/__tests__/feedback.test.ts b/lib/actions/__tests__/feedback.test.ts
index 49246936..276b9d2d 100644
--- a/lib/actions/__tests__/feedback.test.ts
+++ b/lib/actions/__tests__/feedback.test.ts
@@ -3,13 +3,11 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
// Mock the modules before any imports
vi.mock('@/lib/db')
vi.mock('@langfuse/client')
-vi.mock('@/lib/utils/telemetry')
// Import after mocking
import { LangfuseClient } from '@langfuse/client'
import { db } from '@/lib/db'
-import { isTracingEnabled } from '@/lib/utils/telemetry'
import { getMessageFeedback, updateMessageFeedback } from '../feedback'
@@ -40,9 +38,6 @@ describe('Feedback Actions', () => {
const mockSet = vi.fn().mockReturnValue({ where: mockUpdateWhere })
vi.mocked(db).update = vi.fn().mockReturnValue({ set: mockSet })
- // Mock tracing disabled
- vi.mocked(isTracingEnabled).mockReturnValue(false)
-
const result = await updateMessageFeedback(messageId, score)
expect(result).toEqual({ success: true })
@@ -84,26 +79,11 @@ describe('Feedback Actions', () => {
expect(result.error).toBe('Database error')
})
- it('should send feedback to Langfuse when tracing is enabled', async () => {
+ it('should not send a Langfuse score (the API route owns score submission)', async () => {
const messageId = 'test-message-id'
const chatId = 'test-chat-id'
const score = 1
- // Enable tracing
- vi.mocked(isTracingEnabled).mockReturnValue(true)
-
- // Mock LangfuseClient
- const mockScoreCreate = vi.fn()
- const mockFlush = vi.fn().mockResolvedValue(undefined)
- vi.mocked(LangfuseClient).mockImplementation(function () {
- return {
- score: {
- create: mockScoreCreate,
- flush: mockFlush
- }
- } as any
- } as any)
-
// Mock db.select
const mockLimit = vi.fn().mockResolvedValue([
{
@@ -123,14 +103,7 @@ describe('Feedback Actions', () => {
const result = await updateMessageFeedback(messageId, score)
expect(result).toEqual({ success: true })
- expect(LangfuseClient).toHaveBeenCalled()
- expect(mockScoreCreate).toHaveBeenCalledWith({
- traceId: 'test-trace-id',
- name: 'user-feedback',
- value: score,
- comment: 'Thumbs up'
- })
- expect(mockFlush).toHaveBeenCalled()
+ expect(LangfuseClient).not.toHaveBeenCalled()
})
})
diff --git a/lib/actions/feedback.ts b/lib/actions/feedback.ts
index 0173ae01..f7e9f34e 100644
--- a/lib/actions/feedback.ts
+++ b/lib/actions/feedback.ts
@@ -1,13 +1,11 @@
'use server'
-import { LangfuseClient } from '@langfuse/client'
import { eq } from 'drizzle-orm'
import { db } from '@/lib/db'
import { messages } from '@/lib/db/schema'
import { withOptionalRLS } from '@/lib/db/with-rls'
import type { UIMessageMetadata } from '@/lib/types/ai'
-import { isTracingEnabled } from '@/lib/utils/telemetry'
export async function updateMessageFeedback(
messageId: string,
@@ -43,28 +41,10 @@ export async function updateMessageFeedback(
.set({ metadata: updatedMetadata })
.where(eq(messages.id, messageId))
- return { success: true, metadata: currentMessage.metadata }
+ return { success: true }
})
- if (!result.success) {
- return result
- }
-
- // Send feedback to Langfuse if trace ID exists and tracing is enabled
- const traceId = (result.metadata as UIMessageMetadata)?.traceId
- if (traceId && isTracingEnabled()) {
- const langfuse = new LangfuseClient()
- langfuse.score.create({
- traceId,
- name: 'user-feedback',
- value: score,
- comment: score === 1 ? 'Thumbs up' : 'Thumbs down'
- })
- // Flush before the server action returns so the score is not lost
- await langfuse.score.flush()
- }
-
- return { success: true }
+ return result
} catch (error) {
console.error('Error updating message feedback:', error)
return {