Skip to content

An AI-powered search engine with a generative UI

fix: address review comments and improve type safety

Yoshiki Miuraa1b18a11c618
diff --git a/app/api/feedback/__tests__/route.test.ts b/app/api/feedback/__tests__/route.test.ts
index cdebeaf3..8a6c0fc6 100644
--- a/app/api/feedback/__tests__/route.test.ts
+++ b/app/api/feedback/__tests__/route.test.ts
@@ -17,9 +17,10 @@ vi.mock('langfuse', () => ({
}))
// Import after mocking
+import { Langfuse } from 'langfuse'
+
import { updateMessageFeedback } from '@/lib/actions/feedback'
import { isTracingEnabled } from '@/lib/utils/telemetry'
-import { Langfuse } from 'langfuse'
import { POST } from '../route'
@@ -191,7 +192,9 @@ describe('Feedback API Route', () => {
}) as any
)
- const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation()
+ const consoleErrorSpy = vi
+ .spyOn(console, 'error')
+ .mockImplementation(() => {})
const request = new Request('http://localhost:3000/api/feedback', {
method: 'POST',
@@ -247,7 +250,9 @@ describe('Feedback API Route', () => {
})
it('should handle JSON parsing errors', async () => {
- const consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation()
+ const consoleErrorSpy = vi
+ .spyOn(console, 'error')
+ .mockImplementation(() => {})
const request = new Request('http://localhost:3000/api/feedback', {
method: 'POST',
diff --git a/lib/actions/__tests__/feedback.test.ts b/lib/actions/__tests__/feedback.test.ts
index 1fc190b4..d7308b79 100644
--- a/lib/actions/__tests__/feedback.test.ts
+++ b/lib/actions/__tests__/feedback.test.ts
@@ -7,10 +7,11 @@ vi.mock('langfuse')
vi.mock('@/lib/utils/telemetry')
// Import after mocking
+import { Langfuse } from 'langfuse'
+
import { chatCache } from '@/lib/cache/memory-cache'
import { db } from '@/lib/db'
import { isTracingEnabled } from '@/lib/utils/telemetry'
-import { Langfuse } from 'langfuse'
import { getMessageFeedback, updateMessageFeedback } from '../feedback'
diff --git a/lib/utils/message-mapping.ts b/lib/utils/message-mapping.ts
index 967cc608..97b95ad0 100644
--- a/lib/utils/message-mapping.ts
+++ b/lib/utils/message-mapping.ts
@@ -1,5 +1,10 @@
import { generateId } from '@/lib/db/schema'
-import type { UIDataTypes, UIMessage, UITools } from '@/lib/types/ai'
+import type {
+ UIDataTypes,
+ UIMessage,
+ UIMessageMetadata,
+ UITools
+} from '@/lib/types/ai'
import type { DynamicToolPart } from '@/lib/types/dynamic-tools'
import type {
DBMessagePart,
@@ -727,13 +732,13 @@ export function mapUIMessageToDBMessage(
id: string
chatId: string
role: string
- metadata?: Record<string, any> | null
+ metadata?: UIMessageMetadata | null
} {
return {
id: message.id,
chatId: message.chatId,
role: message.role,
- metadata: message.metadata as Record<string, any> | undefined
+ metadata: message.metadata || null
}
}
@@ -744,13 +749,13 @@ export function buildUIMessageFromDB(
dbMessage: {
id: string
role: string
- metadata?: Record<string, any> | null
+ metadata?: UIMessageMetadata | null
createdAt?: Date | string
},
dbParts: DBMessagePartSelect[]
): UIMessage {
// Merge metadata from DB with createdAt
- const metadata: Record<string, any> = {
+ const metadata: UIMessageMetadata = {
...(dbMessage.metadata || {}),
...(dbMessage.createdAt && {
createdAt: