Skip to content

An AI-powered search engine with a generative UI

refactor: address Copilot type safety review comments

Yoshiki Miuraa7df869209b5
diff --git a/components/artifact/search-artifact-content.tsx b/components/artifact/search-artifact-content.tsx
index 39ca056d..4f850e2a 100644
--- a/components/artifact/search-artifact-content.tsx
+++ b/components/artifact/search-artifact-content.tsx
@@ -6,7 +6,7 @@ import type { ToolPart } from '@/lib/types/ai'
import { SearchResults } from '@/components/search-results'
import { SearchResultsImageSection } from '@/components/search-results-image'
import { Section, ToolArgsSection } from '@/components/section'
-import { VideoSearchResults } from '@/components/video-search-results'
+import { createVideoSearchResults,VideoSearchResults } from '@/components/video-search-results'
export function SearchArtifactContent({ tool }: { tool: ToolPart<'search'> }) {
const searchResults: TypeSearchResults | undefined =
@@ -45,15 +45,7 @@ export function SearchArtifactContent({ tool }: { tool: ToolPart<'search'> }) {
{searchResults.videos && searchResults.videos.length > 0 && (
<Section title="Videos">
<VideoSearchResults
- results={{
- ...searchResults,
- videos: searchResults.videos,
- searchParameters: {
- q: query || '',
- type: 'video',
- engine: 'google'
- }
- }}
+ results={createVideoSearchResults(searchResults, query)}
displayMode="artifact"
/>
</Section>
diff --git a/components/search-section.tsx b/components/search-section.tsx
index defa5dcf..9bc3e7c7 100644
--- a/components/search-section.tsx
+++ b/components/search-section.tsx
@@ -12,7 +12,7 @@ import { SearchSkeleton } from './default-skeleton'
import { SearchResults } from './search-results'
import { SearchResultsImageSection } from './search-results-image'
import { Section, ToolArgsSection } from './section'
-import { VideoSearchResults } from './video-search-results'
+import { createVideoSearchResults,VideoSearchResults } from './video-search-results'
interface SearchSectionProps {
tool: ToolPart<'search'>
@@ -82,15 +82,7 @@ export function SearchSection({
searchResults.videos.length > 0 && (
<Section title="Videos">
<VideoSearchResults
- results={{
- ...searchResults,
- videos: searchResults.videos,
- searchParameters: {
- q: query || '',
- type: 'video',
- engine: 'google'
- }
- }}
+ results={createVideoSearchResults(searchResults, query)}
/>
</Section>
)}
diff --git a/components/video-search-results.tsx b/components/video-search-results.tsx
index 3a535714..e42fa1cc 100644
--- a/components/video-search-results.tsx
+++ b/components/video-search-results.tsx
@@ -10,6 +10,22 @@ export interface VideoSearchResultsProps {
displayMode?: 'chat' | 'artifact'
}
+// Utility function to ensure searchParameters are present
+export function createVideoSearchResults(
+ searchResults: any,
+ query: string | undefined
+): SerperSearchResults {
+ return {
+ ...searchResults,
+ videos: searchResults.videos || [],
+ searchParameters: searchResults.searchParameters || {
+ q: query || '',
+ type: 'video',
+ engine: 'google'
+ }
+ }
+}
+
export function VideoSearchResults({
results,
displayMode = 'chat'
diff --git a/lib/tools/search/providers/brave.ts b/lib/tools/search/providers/brave.ts
index 63d89a09..e1116d98 100644
--- a/lib/tools/search/providers/brave.ts
+++ b/lib/tools/search/providers/brave.ts
@@ -50,6 +50,15 @@ export class BraveSearchProvider implements SearchProvider {
this.apiKey = process.env.BRAVE_SEARCH_API_KEY
}
+ private getImageThumbnailUrl(result: BraveImageResult): string {
+ return (
+ result.thumbnail?.src ??
+ result.properties?.thumbnail ??
+ result.url ??
+ ''
+ )
+ }
+
async search(
query: string,
maxResults: number = 10,
@@ -160,17 +169,17 @@ export class BraveSearchProvider implements SearchProvider {
// Convert to SerperSearchResultItem format for compatibility
results.videos = (data.results || []).slice(0, maxResults).map(
- (result: BraveVideoResult) =>
+ (result: BraveVideoResult, index: number) =>
({
- title: result.title || 'No title',
- link: result.url || '',
- snippet: result.description || 'No description available',
- imageUrl: result.thumbnail?.src,
- duration: result.video?.duration || result.duration,
- source: result.publisher || '',
- channel: result.publisher || '',
- date: result.date || '',
- position: 0
+ title: result.title ?? 'No title',
+ link: result.url ?? '',
+ snippet: result.description ?? 'No description available',
+ imageUrl: result.thumbnail?.src ?? '',
+ duration: result.video?.duration ?? result.duration ?? '',
+ source: result.publisher ?? '',
+ channel: result.publisher ?? '',
+ date: result.date ?? '',
+ position: index
}) as SerperSearchResultItem
)
} catch (error) {
@@ -208,8 +217,7 @@ export class BraveSearchProvider implements SearchProvider {
({
title: result.title || 'No title',
link: result.url || result.source || '',
- thumbnailUrl:
- result.thumbnail?.src || result.properties?.thumbnail || ''
+ thumbnailUrl: this.getImageThumbnailUrl(result)
}) as SearchImageItem
)
} catch (error) {