Skip to content

An AI-powered search engine with a generative UI

fix(search): surface complete Brave failures (#964)

Sushant Tiwarib00bcfeb50e1
diff --git a/lib/tools/search/providers/__tests__/brave.test.ts b/lib/tools/search/providers/__tests__/brave.test.ts
new file mode 100644
index 00000000..e4298f4d
--- /dev/null
+++ b/lib/tools/search/providers/__tests__/brave.test.ts
@@ -0,0 +1,99 @@
+import { afterEach, describe, expect, it, vi } from 'vitest'
+
+import {
+ getToolFailureMessage,
+ serializeToolFailure,
+ ToolFailureError
+} from '@/lib/errors/tool-error'
+
+import { BraveSearchProvider } from '../brave'
+
+describe('BraveSearchProvider', () => {
+ afterEach(() => {
+ vi.unstubAllEnvs()
+ vi.unstubAllGlobals()
+ vi.restoreAllMocks()
+ })
+
+ it('surfaces a classified failure when every requested search fails', async () => {
+ vi.stubEnv('BRAVE_SEARCH_API_KEY', 'test-key')
+ vi.stubGlobal(
+ 'fetch',
+ vi.fn(async () =>
+ Promise.resolve(
+ new Response(null, {
+ status: 429,
+ statusText: 'Too Many Requests'
+ })
+ )
+ )
+ )
+ vi.spyOn(console, 'error').mockImplementation(() => undefined)
+
+ const error = await new BraveSearchProvider()
+ .search('query', 5, 'basic', [], [], {
+ content_types: ['web', 'image']
+ })
+ .catch(error => error)
+
+ expect(error).toBeInstanceOf(Error)
+ expect(error.status).toBe(429)
+
+ const toolError = new ToolFailureError('search', error)
+ expect(getToolFailureMessage(toolError)).toBe(
+ 'The search service is rate limiting requests. Please try again shortly.'
+ )
+ expect(JSON.parse(serializeToolFailure(toolError))).toMatchObject({
+ error:
+ 'The search service is rate limiting requests. Please try again shortly.',
+ retryable: true
+ })
+ })
+
+ it('returns partial results when at least one requested search succeeds', async () => {
+ vi.stubEnv('BRAVE_SEARCH_API_KEY', 'test-key')
+ vi.stubGlobal(
+ 'fetch',
+ vi.fn(async (input: string | URL | Request) => {
+ if (input.toString().includes('/images/')) {
+ return new Response(null, {
+ status: 503,
+ statusText: 'Service Unavailable'
+ })
+ }
+
+ return Response.json({
+ web: {
+ results: [
+ {
+ title: 'Result title',
+ description: 'Result description',
+ url: 'https://example.com/result'
+ }
+ ]
+ }
+ })
+ })
+ )
+ vi.spyOn(console, 'error').mockImplementation(() => undefined)
+
+ const result = await new BraveSearchProvider().search(
+ 'query',
+ 5,
+ 'basic',
+ [],
+ [],
+ { content_types: ['web', 'image'] }
+ )
+
+ expect(result.results).toEqual([
+ {
+ title: 'Result title',
+ content: 'Result description',
+ url: 'https://example.com/result'
+ }
+ ])
+ expect(result.images).toEqual([])
+ expect(result.number_of_results).toBe(1)
+ })
+})
diff --git a/lib/tools/search/providers/brave.ts b/lib/tools/search/providers/brave.ts
index 883ecb83..95aeffae 100644
--- a/lib/tools/search/providers/brave.ts
+++ b/lib/tools/search/providers/brave.ts
@@ -96,7 +96,17 @@ export class BraveSearchProvider extends BaseSearchProvider {
promises.push(this.searchImages(query, maxResults, results))
}
- await Promise.all(promises)
+ const settledSearches = await Promise.allSettled(promises)
+ const failedSearches = settledSearches.filter(
+ (result): result is PromiseRejectedResult => result.status === 'rejected'
+ )
+
+ if (
+ failedSearches.length > 0 &&
+ failedSearches.length === settledSearches.length
+ ) {
+ throw failedSearches[0].reason
+ }
// Update total count
results.number_of_results = results.results.length
@@ -138,6 +148,7 @@ export class BraveSearchProvider extends BaseSearchProvider {
}))
} catch (error) {
console.error('Brave web search error:', error)
+ throw error
}
}
@@ -184,7 +195,7 @@ export class BraveSearchProvider extends BaseSearchProvider {
)
} catch (error) {
console.error('Brave video search error:', error)
- results.videos = []
+ throw error
}
}
@@ -223,7 +234,7 @@ export class BraveSearchProvider extends BaseSearchProvider {
)
} catch (error) {
console.error('Brave image search error:', error)
- results.images = []
+ throw error
}
}
}