Skip to content

An AI-powered search engine with a generative UI

fix(ui): shrink message save action (#1036)

Yoshiki Miurab3a77b49d4ff
diff --git a/components/__tests__/message-actions.test.tsx b/components/__tests__/message-actions.test.tsx
index b0fd9264..b68c5d95 100644
--- a/components/__tests__/message-actions.test.tsx
+++ b/components/__tests__/message-actions.test.tsx
@@ -1,6 +1,7 @@
import { fireEvent, render, screen, waitFor } from '@testing-library/react'
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest'
+import { saveNote } from '@/lib/actions/notes'
import { captureClient } from '@/lib/analytics/posthog-client'
import { MessageActions } from '../message-actions'
@@ -9,6 +10,10 @@ vi.mock('@/lib/analytics/posthog-client', () => ({
captureClient: vi.fn()
}))
+vi.mock('@/lib/actions/notes', () => ({
+ saveNote: vi.fn()
+}))
+
vi.mock('../library/library-context', () => ({
useLibrary: () => ({
openLibrary: vi.fn(),
@@ -28,6 +33,102 @@ describe('MessageActions', () => {
global.fetch = originalFetch
})
+ test('renders the save control in the same action group as copy', () => {
+ const { container } = render(
+ <MessageActions
+ message="Answer"
+ messageId="save-group-1"
+ status="ready"
+ visible
+ />
+ )
+
+ const saveButton = screen.getByRole('button', {
+ name: 'Save to library'
+ })
+ const copyButton = container
+ .querySelector('.tabler-icon-copy')
+ ?.closest('button')
+
+ expect(copyButton).toBeTruthy()
+ expect(saveButton.parentElement).toBe(copyButton?.parentElement)
+ })
+
+ test('does not render the save control when the library is unavailable', () => {
+ render(
+ <MessageActions
+ message="Answer"
+ messageId="save-unavailable-1"
+ libraryAvailable={false}
+ status="ready"
+ visible
+ />
+ )
+
+ expect(
+ screen.queryByRole('button', { name: 'Save to library' })
+ ).not.toBeInTheDocument()
+ })
+
+ test('does not render the save control for a local guest', () => {
+ render(
+ <MessageActions
+ message="Answer"
+ messageId="save-local-guest-1"
+ isGuest
+ status="ready"
+ visible
+ />
+ )
+
+ expect(
+ screen.queryByRole('button', { name: 'Save to library' })
+ ).not.toBeInTheDocument()
+ })
+
+ test('opens the auth dialog for a cloud guest', () => {
+ render(
+ <MessageActions
+ message="Answer"
+ messageId="save-cloud-guest-1"
+ isGuest
+ isCloudDeployment
+ status="ready"
+ visible
+ />
+ )
+
+ fireEvent.click(screen.getByRole('button', { name: 'Save to library' }))
+
+ expect(
+ screen.getByRole('heading', { name: 'Save notes to your library' })
+ ).toBeInTheDocument()
+ expect(saveNote).not.toHaveBeenCalled()
+ })
+
+ test('saves the message from the save control', async () => {
+ vi.mocked(saveNote).mockResolvedValue({ success: true })
+ render(
+ <MessageActions
+ message="Answer"
+ messageId="save-message-1"
+ chatId="chat-1"
+ status="ready"
+ visible
+ />
+ )
+
+ fireEvent.click(screen.getByRole('button', { name: 'Save to library' }))
+
+ await waitFor(() => {
+ expect(saveNote).toHaveBeenCalledWith({
+ content: 'Answer',
+ chatId: 'chat-1',
+ sourceMessageId: 'save-message-1'
+ })
+ })
+ })
+
test('does not record an event when the feedback control is shown', () => {
render(
<MessageActions
diff --git a/components/message-actions.tsx b/components/message-actions.tsx
index 29e242e6..d3c577e9 100644
--- a/components/message-actions.tsx
+++ b/components/message-actions.tsx
@@ -30,6 +30,12 @@ import {
DialogHeader,
DialogTitle
} from './ui/dialog'
+import {
+ Tooltip,
+ TooltipContent,
+ TooltipProvider,
+ TooltipTrigger
+} from './ui/tooltip'
import { ChatShare } from './chat-share'
import { RetryButton } from './retry-button'
@@ -216,7 +222,7 @@ export function MessageActions({
<div
aria-hidden={!visible}
className={cn(
- 'flex w-full items-center justify-between gap-3 self-stretch transition-opacity duration-200',
+ 'flex w-full items-center gap-3 self-stretch transition-opacity duration-200',
visible ? 'opacity-100' : 'pointer-events-none opacity-0 invisible',
className
)}
@@ -266,22 +272,28 @@ export function MessageActions({
)}
</>
)}
+ {showSaveButton && (
+ <TooltipProvider delayDuration={200}>
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <Button
+ variant="ghost"
+ size="icon"
+ onClick={handleSaveNote}
+ disabled={isSavingNote}
+ className="rounded-full"
+ aria-label="Save to library"
+ >
+ <Bookmark size={14} />
+ </Button>
+ </TooltipTrigger>
+ <TooltipContent className="text-xs">
+ Save to library
+ </TooltipContent>
+ </Tooltip>
+ </TooltipProvider>
+ )}
</div>
- {showSaveButton ? (
- <Button
- variant="outline"
- size="sm"
- onClick={handleSaveNote}
- disabled={isSavingNote}
- className="h-8 shrink-0 gap-1.5 rounded-full px-3"
- aria-label="Save to library"
- >
- <Bookmark size={14} />
- Save
- </Button>
- ) : (
- <div />
- )}
</div>
<Dialog open={authPromptOpen} onOpenChange={setAuthPromptOpen}>